Feed Advanced Search

Jan 5 2019

eduisters added inline comments to D17859: Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11.
Jan 5 2019, 7:13 PM · KDE Connect
eduisters added a comment to D17976: Fix file opening.

+1. (Weird though that DocumentFile.getType() returns something different than what it was created with)

Jan 5 2019, 6:47 AM · KDE Connect

Jan 2 2019

eduisters updated the diff for D17859: Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11.
  • Improved state saving
Jan 2 2019, 10:52 AM · KDE Connect

Jan 1 2019

eduisters updated the diff for D17859: Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11.
  • Fix NPE
Jan 1 2019, 5:30 PM · KDE Connect

Dec 31 2018

eduisters updated the diff for D17886: Make tapping on a pair notification work again.
  • Fixed NPE on orientation change
Dec 31 2018, 3:07 PM · KDE Connect
eduisters planned changes to D17886: Make tapping on a pair notification work again.

Crash on orientation change

Dec 31 2018, 2:42 PM · KDE Connect
eduisters requested review of D17886: Make tapping on a pair notification work again.
Dec 31 2018, 2:38 PM · KDE Connect
eduisters updated the diff for D17878: Use ButterKnife for view binding.
  • Unbind views in onDestroyView()
Dec 31 2018, 11:29 AM · KDE Connect

Dec 30 2018

eduisters requested review of D17878: Use ButterKnife for view binding.
Dec 30 2018, 7:05 PM · KDE Connect
eduisters requested review of D17875: Do not continue displaying the previous track's album art image when the new track's albumArtUrl is empty.
Dec 30 2018, 5:45 PM · KDE Connect

Dec 29 2018

eduisters added a reviewer for D17859: Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11: KDE Connect.
Dec 29 2018, 7:38 PM · KDE Connect
eduisters requested review of D17859: Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11.
Dec 29 2018, 7:30 PM · KDE Connect

Dec 27 2018

eduisters committed R225:f684fbe8eff5: Migrate from android support libraries to androidx (authored by eduisters).
Migrate from android support libraries to androidx
Dec 27 2018, 3:43 PM
eduisters closed D17818: Migrate from android support libraries to androidx.
Dec 27 2018, 3:43 PM · KDE Connect
eduisters requested review of D17818: Migrate from android support libraries to androidx.
Dec 27 2018, 2:43 PM · KDE Connect

Dec 21 2018

eduisters committed R225:78c69a0cdcfc: Allow browsing sdcard when there is an unreadable file in it (eg . (authored by eduisters).
Allow browsing sdcard when there is an unreadable file in it (eg .
Dec 21 2018, 5:42 PM
eduisters closed D17644: Allow browsing sdcard when there is an unreadable file in it (eg .android_secure).
Dec 21 2018, 5:42 PM · KDE Connect

Dec 20 2018

eduisters accepted D17688: Reorder placeholders for i18n c-format compatibility.
Dec 20 2018, 2:36 PM · KDE Connect

Dec 17 2018

eduisters added a comment to D17644: Allow browsing sdcard when there is an unreadable file in it (eg .android_secure).

Awesome! Unfortunately I don't have a phone with an SD Card to test. Does this also fix writing to the SD card?

Dec 17 2018, 9:00 PM · KDE Connect
eduisters requested review of D17644: Allow browsing sdcard when there is an unreadable file in it (eg .android_secure).
Dec 17 2018, 7:12 PM · KDE Connect
eduisters updated the diff for D16491: Allow shares from desktop to be canceled.
  • Removed debug log statement
Dec 17 2018, 9:44 AM · KDE Connect

Dec 16 2018

eduisters updated the test plan for D16491: Allow shares from desktop to be canceled.
Dec 16 2018, 4:48 PM · KDE Connect
eduisters updated the test plan for D16491: Allow shares from desktop to be canceled.
Dec 16 2018, 4:47 PM · KDE Connect
eduisters added a dependency for D16491: Allow shares from desktop to be canceled: D17627: Simplify receiving multiple files using only 1 notification.
Dec 16 2018, 4:46 PM · KDE Connect
eduisters added a dependent revision for D17627: Simplify receiving multiple files using only 1 notification: D16491: Allow shares from desktop to be canceled.
Dec 16 2018, 4:46 PM · KDE Connect
eduisters added a reviewer for D17628: Do not close m_socket in socketError(): KDE Connect.
Dec 16 2018, 4:45 PM · KDE Connect
eduisters added a dependency for D17628: Do not close m_socket in socketError(): D16491: Allow shares from desktop to be canceled.
Dec 16 2018, 4:44 PM · KDE Connect
eduisters added a dependent revision for D16491: Allow shares from desktop to be canceled: D17628: Do not close m_socket in socketError().
Dec 16 2018, 4:44 PM · KDE Connect
eduisters updated the test plan for D17628: Do not close m_socket in socketError().
Dec 16 2018, 4:44 PM · KDE Connect
eduisters updated the diff for D16491: Allow shares from desktop to be canceled.
  • Rebased onto simplify_receiving_files
Dec 16 2018, 4:43 PM · KDE Connect
eduisters requested review of D17628: Do not close m_socket in socketError().
Dec 16 2018, 4:40 PM · KDE Connect
eduisters requested review of D17627: Simplify receiving multiple files using only 1 notification.
Dec 16 2018, 4:33 PM · KDE Connect

Dec 9 2018

eduisters committed R225:15ff0fca2b56: Make DeviceFragments listview use full screen width so the over scroll… (authored by eduisters).
Make DeviceFragments listview use full screen width so the over scroll…
Dec 9 2018, 5:55 PM
eduisters closed D17456: Make DeviceFragments listview use full screen width so the over scroll indicator looks better.
Dec 9 2018, 5:55 PM · KDE Connect
eduisters closed D17452: Fix some lint warnings.
Dec 9 2018, 5:53 PM · KDE Connect
eduisters committed R225:87ec4f2078e6: Fix some lint warnings (authored by eduisters).
Fix some lint warnings
Dec 9 2018, 5:53 PM
eduisters committed R225:2402b116089b: Incorporate more Material Design components (authored by eduisters).
Incorporate more Material Design components
Dec 9 2018, 5:51 PM
eduisters closed D17451: Incorporate more Material Design components.
Dec 9 2018, 5:51 PM · KDE Connect
eduisters committed R225:53422e090019: Use android:theme instead of app:theme because it is deprecated (authored by eduisters).
Use android:theme instead of app:theme because it is deprecated
Dec 9 2018, 5:40 PM
eduisters closed D17434: Use android:theme instead of app:theme because it is deprecated.
Dec 9 2018, 5:40 PM · KDE Connect
eduisters updated the summary of D17456: Make DeviceFragments listview use full screen width so the over scroll indicator looks better.
Dec 9 2018, 5:23 PM · KDE Connect
eduisters requested review of D17456: Make DeviceFragments listview use full screen width so the over scroll indicator looks better.
Dec 9 2018, 5:20 PM · KDE Connect
eduisters added a reviewer for D17452: Fix some lint warnings: KDE Connect.
Dec 9 2018, 11:38 AM · KDE Connect
eduisters requested review of D17452: Fix some lint warnings.
Dec 9 2018, 11:37 AM · KDE Connect
eduisters requested review of D17451: Incorporate more Material Design components.
Dec 9 2018, 11:34 AM · KDE Connect

Dec 8 2018

eduisters requested review of D17434: Use android:theme instead of app:theme because it is deprecated.
Dec 8 2018, 5:02 PM · KDE Connect
eduisters committed R225:d4d4849f158a: Closing a SSLSockets input or output stream does not close the socket (https… (authored by eduisters).
Closing a SSLSockets input or output stream does not close the socket (https…
Dec 8 2018, 1:28 PM
eduisters closed D17320: Closing a SSLSockets input or output stream does not close the socket (https://issuetracker.google.com/issues/37018094).
Dec 8 2018, 1:28 PM · KDE Connect
eduisters updated the diff for D17320: Closing a SSLSockets input or output stream does not close the socket (https://issuetracker.google.com/issues/37018094).
  • Rebased onto master
Dec 8 2018, 1:27 PM · KDE Connect
eduisters closed D17409: Do not create a new content fragment on orientation change.
Dec 8 2018, 1:14 PM · KDE Connect
eduisters committed R225:3a189d1af4d0: Do not create a new content fragment on orientation change (authored by eduisters).
Do not create a new content fragment on orientation change
Dec 8 2018, 1:14 PM
eduisters committed R225:9f498f81277d: Use butterknife for view binding (authored by eduisters).
Use butterknife for view binding
Dec 8 2018, 1:13 PM
eduisters closed D17411: Use butterknife for view binding.
Dec 8 2018, 1:13 PM · KDE Connect

Dec 7 2018

eduisters added inline comments to D17411: Use butterknife for view binding.
Dec 7 2018, 7:53 PM · KDE Connect
eduisters closed D17400: Make toast work from a background thread.
Dec 7 2018, 6:22 PM · KDE Connect
eduisters committed R225:087b7ce875ae: Make toast work from a background thread (authored by eduisters).
Make toast work from a background thread
Dec 7 2018, 6:22 PM
eduisters requested review of D17411: Use butterknife for view binding.
Dec 7 2018, 6:05 PM · KDE Connect
eduisters requested review of D17409: Do not create a new content fragment on orientation change.
Dec 7 2018, 5:22 PM · KDE Connect
eduisters updated the summary of D17400: Make toast work from a background thread.
Dec 7 2018, 11:07 AM · KDE Connect
eduisters retitled D17400: Make toast work from a background thread from Make toast work from a background threat to Make toast work from a background thread.
Dec 7 2018, 11:07 AM · KDE Connect
eduisters requested review of D17400: Make toast work from a background thread.
Dec 7 2018, 11:00 AM · KDE Connect

Dec 6 2018

eduisters committed R225:96a1edfb764d: Fix lint warning: Avoid non-default constructors in fragments (authored by eduisters).
Fix lint warning: Avoid non-default constructors in fragments
Dec 6 2018, 7:29 PM
eduisters closed D17390: Fix lint warning: Avoid non-default constructors in fragments.
Dec 6 2018, 7:29 PM · KDE Connect
eduisters updated the diff for D17390: Fix lint warning: Avoid non-default constructors in fragments.

Rebased onto master

Dec 6 2018, 7:28 PM · KDE Connect
eduisters committed R225:6e8d9e8419dd: Remove not used constructor (authored by eduisters).
Remove not used constructor
Dec 6 2018, 6:39 PM
eduisters closed D17389: Remove not used constructor.
Dec 6 2018, 6:39 PM · KDE Connect
eduisters committed R225:27f8c57c50e3: Do not send null NetworkPackets (authored by eduisters).
Do not send null NetworkPackets
Dec 6 2018, 6:38 PM
eduisters closed D17384: Do not send null NetworkPackets.
Dec 6 2018, 6:38 PM · KDE Connect
eduisters added a dependency for D17390: Fix lint warning: Avoid non-default constructors in fragments: D17389: Remove not used constructor.
Dec 6 2018, 6:29 PM · KDE Connect
eduisters added a dependent revision for D17389: Remove not used constructor: D17390: Fix lint warning: Avoid non-default constructors in fragments.
Dec 6 2018, 6:29 PM · KDE Connect
eduisters requested review of D17390: Fix lint warning: Avoid non-default constructors in fragments.
Dec 6 2018, 6:28 PM · KDE Connect
eduisters requested review of D17389: Remove not used constructor.
Dec 6 2018, 5:44 PM · KDE Connect
eduisters updated the diff for D17384: Do not send null NetworkPackets.
  • Use np
Dec 6 2018, 3:56 PM · KDE Connect
eduisters requested review of D17384: Do not send null NetworkPackets.
Dec 6 2018, 3:45 PM · KDE Connect

Dec 3 2018

eduisters updated the diff for D17320: Closing a SSLSockets input or output stream does not close the socket (https://issuetracker.google.com/issues/37018094).
  • Encapsulate mPayload, mPayloadSocket and mPayloadSize in a NetworkPacket.Payload object for easier handling
Dec 3 2018, 7:21 PM · KDE Connect

Dec 2 2018

eduisters committed R225:04e605bcf90f: Handle receiving an empty file (authored by eduisters).
Handle receiving an empty file
Dec 2 2018, 6:36 PM
eduisters closed D17235: Handle receiving an empty file.
Dec 2 2018, 6:36 PM · KDE Connect
eduisters updated the diff for D17235: Handle receiving an empty file.
  • Removed log statement
Dec 2 2018, 6:34 PM · KDE Connect
eduisters requested review of D17320: Closing a SSLSockets input or output stream does not close the socket (https://issuetracker.google.com/issues/37018094).
Dec 2 2018, 6:30 PM · KDE Connect

Nov 30 2018

eduisters requested review of D17235: Handle receiving an empty file.
Nov 30 2018, 5:06 PM · KDE Connect
eduisters planned changes to D17235: Handle receiving an empty file.

Forgot to remove a string

Nov 30 2018, 5:03 PM · KDE Connect
eduisters updated the diff for D17235: Handle receiving an empty file.
  • Rebased onto masters
  • add assert back
Nov 30 2018, 5:02 PM · KDE Connect
eduisters committed R225:6fb6ea7e2bcb: Clear currentShareInfo when transfer is complete (authored by eduisters).
Clear currentShareInfo when transfer is complete
Nov 30 2018, 4:54 PM
eduisters closed D17259: Clear currentShareInfo when transfer is complete.
Nov 30 2018, 4:54 PM · KDE Connect
eduisters updated the diff for D17259: Clear currentShareInfo when transfer is complete.
  • Always clear currentShareInfo in FinishReceivingRunnable
Nov 30 2018, 3:30 PM · KDE Connect
eduisters planned changes to D17259: Clear currentShareInfo when transfer is complete.

Needs to be done in onError as well

Nov 30 2018, 3:06 PM · KDE Connect
eduisters requested review of D17259: Clear currentShareInfo when transfer is complete.
Nov 30 2018, 2:53 PM · KDE Connect
eduisters planned changes to D16491: Allow shares from desktop to be canceled.

This needs a bit of work because of all the changes to master

Nov 30 2018, 1:49 PM · KDE Connect
eduisters committed R225:4dd651b386ea: Align NetworkPacket.hasPayload with desktop (authored by eduisters).
Align NetworkPacket.hasPayload with desktop
Nov 30 2018, 7:41 AM
eduisters closed D17236: Align NetworkPacket.hasPayload with desktop.
Nov 30 2018, 7:41 AM · KDE Connect
eduisters updated the diff for D17236: Align NetworkPacket.hasPayload with desktop.

Rebased onto master

Nov 30 2018, 7:39 AM · KDE Connect
eduisters committed R225:9b426fe4a53d: Receive multiple files using 1 notification (authored by eduisters).
Receive multiple files using 1 notification
Nov 30 2018, 7:36 AM
eduisters closed D17157: Receive multiple files using 1 notification.
Nov 30 2018, 7:36 AM · KDE Connect
eduisters updated the diff for D17157: Receive multiple files using 1 notification.
  • Rebased onto master
Nov 30 2018, 7:34 AM · KDE Connect
eduisters committed R224:b6c15289f511: Combine multiple upload jobs into a single KCompositeJob so only 1 notification… (authored by eduisters).
Combine multiple upload jobs into a single KCompositeJob so only 1 notification…
Nov 30 2018, 7:27 AM
eduisters closed D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.
Nov 30 2018, 7:27 AM · KDE Connect
eduisters updated the diff for D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.
  • Rebased onto master
Nov 30 2018, 7:25 AM · KDE Connect

Nov 29 2018

eduisters added a comment to D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.

The only thing, but seems hard to fix is: when there is a transfer in progress and I add another file, the job is updated to say "sending N+1 files", but on Android it still says "receiving N files".

Nov 29 2018, 8:59 PM · KDE Connect
eduisters planned changes to D17235: Handle receiving an empty file.

Waiting for D17236 so requested change by albertvaka can be implemented

Nov 29 2018, 4:43 PM · KDE Connect
eduisters requested review of D17236: Align NetworkPacket.hasPayload with desktop.
Nov 29 2018, 3:39 PM · KDE Connect