Make tapping on a pair notification work again
ClosedPublic

Authored by eduisters on Dec 31 2018, 2:38 PM.

Details

Summary

The Simplify pairing from notification patch D16518 broke the functionality that
tapping on the notification provided

This patch makes tapping on the pairing notification work again as expected

Test Plan

Before applying this patch initiate a pairing from kde
On android tap on the notification (not the action buttons) and notice that nothing happens

Apply the path and repeat the above test. Now the DeviceFragment should be displayed allowing
the the pairing to be accepted or rejected

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eduisters created this revision.Dec 31 2018, 2:38 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 31 2018, 2:38 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Dec 31 2018, 2:38 PM
eduisters planned changes to this revision.Dec 31 2018, 2:42 PM

Crash on orientation change

eduisters updated this revision to Diff 48447.Dec 31 2018, 3:07 PM
  • Fixed NPE on orientation change
nicolasfella accepted this revision.Jan 5 2019, 6:47 PM
nicolasfella added a subscriber: nicolasfella.
nicolasfella added inline comments.
src/org/kde/kdeconnect/Device.java
387

Remove it instead of commenting it out

This revision is now accepted and ready to land.Jan 5 2019, 6:47 PM
This revision was automatically updated to reflect the committed changes.