Sequentially receiving multiple files was overly complicated sometimes leading to a progress
notification being shown indefinitely. When files are shared using an older kdeconnect-kde version
fallback to receiving each file individually
Details
Details
- Reviewers
albertvaka nicolasfella - Group Reviewers
KDE Connect - Commits
- R225:4c6b74a2eb11: Simplify receiving multiple files using only 1 notification
Send multiple files from desktop to android and observe that android receives the files
sequentially using only 1 notification
Send multiple files from an kdeconnect-kde installation and observe that android receives the
files in parallel using multiple notifications
Diff Detail
Diff Detail
- Repository
- R225 KDE Connect - Android application
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java | ||
|---|---|---|
| 214 | Why only save it if it hasNumberOfFiles? If I understand correctly, we could still add more files to it from another networkpacket. | |
| src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java | ||
|---|---|---|
| 214 | That was a while ago but when the packet comes from an old kdeconnect-kde version or the file should be opened the new job is scheduled and forgotten. If not keep it around so additional packets can be added to it | |