In D18212#426766, @albertvaka wrote:

This has been stuck for super long, I'm really sorry... testing now.

I don't get any relevant place to pick from as a "storage location" on OnePlus 6 (only "Downloads"):

Why?

Also, really minor but I think the first field shouldn't be editable:

Mar 7 2019, 7:07 PM · KDE Connect

Mar 4 2019

eduisters committed R225:085fb1025b9b: Capture PairingHandlerCallback and call its pairingDone method instead of… (authored by eduisters).

Capture PairingHandlerCallback and call its pairingDone method instead of…

Mar 4 2019, 6:25 PM

eduisters committed R225:bc2836f45f77: Also verify that Device.PairingCallback.unpaired() is called (authored by eduisters).

Also verify that Device.PairingCallback.unpaired() is called

Mar 4 2019, 6:23 PM

eduisters committed R225:b135ffa92a66: Also verify that Device.PairingCallback.pairingSuccessful() is called (authored by eduisters).

Also verify that Device.PairingCallback.pairingSuccessful() is called

Mar 4 2019, 6:21 PM

Mar 3 2019

eduisters committed R225:9d5a6fa0fd2e: Fixed NPE when contentIntent is triggered (authored by eduisters).

Fixed NPE when contentIntent is triggered

Mar 3 2019, 2:52 PM

eduisters committed R225:024a084b9a67: Add DeviceType test (authored by eduisters).

Add DeviceType test

Mar 3 2019, 1:10 PM

Mar 2 2019

eduisters committed R225:ff51544e467f: Clean up formatting (authored by eduisters).

Clean up formatting

Mar 2 2019, 4:32 PM

Mar 1 2019

eduisters committed R225:7afbbb452baf: Removed vectorDrawables.useSupportLibrary = true (authored by eduisters).

Removed vectorDrawables.useSupportLibrary = true

Mar 1 2019, 10:52 AM

Feb 21 2019

eduisters added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

In D18212#416410, @sredman wrote:

Cool! I like the warning popup!

Does the system automatically configure the device 'root' now? I can't tell if that was there by default or if it was just left over from when I had this before...

Feb 21 2019, 7:32 AM · KDE Connect

Feb 20 2019

eduisters added a comment to D16491: Allow shares from desktop to be canceled.

ping -c2 -s3G

Feb 20 2019, 8:40 PM · KDE Connect

eduisters added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Kling klokje klingelingeling

Feb 20 2019, 8:39 PM · KDE Connect

Feb 2 2019

eduisters committed R225:56f129ddf454: Use an AlertDialogFragment instead of a AlertDialog for Plugin.getErrorDialog() (authored by eduisters).

Use an AlertDialogFragment instead of a AlertDialog for Plugin.getErrorDialog()

Feb 2 2019, 11:49 PM

eduisters committed R225:d364401ea939: Use DialogFragment instead of an AlertDialog for runtime permissions (authored by eduisters).

Use DialogFragment instead of an AlertDialog for runtime permissions

Feb 2 2019, 11:38 AM

eduisters committed R225:fc119515323e: Fix keyboard input on Pie (Android 9/API 28) BUG: 401726 (authored by eduisters).

Fix keyboard input on Pie (Android 9/API 28) BUG: 401726

Feb 2 2019, 11:38 AM

eduisters committed R225:f4c80dd839c0: Use an EditTextPreference for changing the device name instead of an AlertDialog (authored by eduisters).

Use an EditTextPreference for changing the device name instead of an AlertDialog

Feb 2 2019, 11:38 AM

eduisters committed R225:da9b4ea19eeb: Do not query for contacts when there are no contacts (authored by eduisters).

Do not query for contacts when there are no contacts

Feb 2 2019, 11:38 AM

eduisters committed R225:874e100e9135: Add packet type "kdeconnect.share.request.update" to allow android to update… (authored by eduisters).

Add packet type "kdeconnect.share.request.update" to allow android to update…

Feb 2 2019, 11:38 AM

eduisters committed R225:6864cec3fad5: Merge branch 'improve_multi_file_sharing' of invent.kde.org… (authored by eduisters).

Merge branch 'improve_multi_file_sharing' of invent.kde.org…

Feb 2 2019, 11:38 AM

eduisters committed R225:e098ebdaf458: Add packet type "kdeconnect.share.request.update" to allow android to update… (authored by eduisters).

Add packet type "kdeconnect.share.request.update" to allow android to update…

Feb 2 2019, 11:38 AM

Jan 31 2019

eduisters committed R224:805795af073f: Do not send an update packet until we have actually begun processing sub-jobs (authored by eduisters).

Do not send an update packet until we have actually begun processing sub-jobs

Jan 31 2019, 12:31 AM

eduisters committed R224:975dd6e907d9: Rebased onto master (authored by eduisters).

Rebased onto master

Jan 31 2019, 12:31 AM

eduisters committed R224:a9958eca74a6: Add packet type "kdeconnect.share.request.update" to allow android to update… (authored by eduisters).

Add packet type "kdeconnect.share.request.update" to allow android to update…

Jan 31 2019, 12:31 AM

eduisters committed R224:d1734286ad1a: Merge branch 'improve_multi_file_sharing' of invent.kde.org… (authored by eduisters).

Merge branch 'improve_multi_file_sharing' of invent.kde.org…

Jan 31 2019, 12:31 AM

eduisters committed R224:87e241d2c127: Add packet type "kdeconnect.share.request.update" to allow android to update… (authored by eduisters).

Add packet type "kdeconnect.share.request.update" to allow android to update…

Jan 31 2019, 12:31 AM

eduisters committed R224:0f2a60065a12: Add packet type "kdeconnect.share.request.update" to allow android to update… (authored by eduisters).

Add packet type "kdeconnect.share.request.update" to allow android to update…

Jan 31 2019, 12:31 AM

Jan 27 2019

eduisters updated the diff for D16491: Allow shares from desktop to be canceled.

Removed debug logging
Intercept Device.SendPacketStatusCallback callbacks to prevent "Failed to send file to" notification from being shown when cancelling locally
Remove cancel Action when done
Rebased onto master
Rebased onto master
Delete ReceiveFileRunnable.java erroneously brought back by rebase
Rebased onto simplify_receiving_files
Removed debug log statement
Rebased onto master
Rebased onto master

Jan 27 2019, 3:22 PM · KDE Connect

Jan 24 2019

eduisters committed R224:273c9bb6e403: Handle errorMessage in kdeconnect.sftp packet (authored by eduisters).

Handle errorMessage in kdeconnect.sftp packet

Jan 24 2019, 5:41 PM

Jan 22 2019

eduisters updated the diff for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Properly handle the situation where no storage locations have been configured
Handle preference changes
Allow deleting of the last storage location
Always create the right FileSystemView depending on Build.VERSION
Remove erroneous leftover from re-fractoring SftpSettingsActivity into SftpSettingsFragment
Commented out entries needed to debug org.apache.sshd
Remove unused variables
Remove optional WRITE_EXTERNAL_STORAGE permission because it is always granted on Build.VERSION < KITKAT
Remove required WRITE_EXTERNAL_STORAGE permission because it is always granted on Build.VERSION < 23 at installation time and we now use SaF starting Build.VERSION >= 21
Remove unneeded PreferenceFragmentCompat.OnPreferenceStartScreenCallback
Show plugin as failed on KitKat and older devices when no sdcard is detected

Jan 22 2019, 3:54 PM · KDE Connect

Jan 21 2019

eduisters committed R225:4c6b74a2eb11: Simplify receiving multiple files using only 1 notification (authored by eduisters).

Simplify receiving multiple files using only 1 notification

Jan 21 2019, 5:52 PM

eduisters closed D17627: Simplify receiving multiple files using only 1 notification.

Jan 21 2019, 5:52 PM · KDE Connect

Jan 19 2019

eduisters added a comment to D17627: Simplify receiving multiple files using only 1 notification.

ping -s 1 -c 1 -q

Jan 19 2019, 12:29 PM · KDE Connect

Jan 17 2019

eduisters committed R225:8e93e3253fbb: Use androidx version of AlertDialog (authored by eduisters).

Use androidx version of AlertDialog

Jan 17 2019, 4:21 PM

eduisters closed D18298: Use androidx version of AlertDialog.

Jan 17 2019, 4:21 PM · KDE Connect

Jan 16 2019

eduisters planned changes to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

I'll implement Alberts 1st idea because the second is just not fool-proof and will only allow read-only access to the sdcard.
As soon as we can handle disabled plugins properly I think it's better to disable the plugin until storage locations have been configured

Jan 16 2019, 3:41 PM · KDE Connect

eduisters added a reviewer for D18298: Use androidx version of AlertDialog: KDE Connect.

Jan 16 2019, 3:16 PM · KDE Connect

eduisters requested review of D18298: Use androidx version of AlertDialog.

Jan 16 2019, 3:11 PM · KDE Connect

eduisters committed R224:4834b6353778: Just set UDSEntry::UDS_NAME to the actual directory name instead of the… (authored by eduisters).

Just set UDSEntry::UDS_NAME to the actual directory name instead of the…

Jan 16 2019, 1:56 PM

eduisters closed D18223: Just set UDSEntry::UDS_NAME to the actual directory name instead of the hardcoded string "folder" and don't set UDSEntry::UDS_DISPLAY_NAME at all.

Jan 16 2019, 1:56 PM · KDE Connect

eduisters committed R225:8466a6f85337: Update for Android Studio 3.3 (authored by eduisters).

Update for Android Studio 3.3

Jan 16 2019, 1:52 PM

eduisters closed D18264: Update for Android Studio 3.3.

Jan 16 2019, 1:52 PM · KDE Connect

Jan 15 2019

eduisters added a reviewer for D18264: Update for Android Studio 3.3: KDE Connect.

Jan 15 2019, 7:49 PM · KDE Connect

eduisters removed a reviewer for D18181: Allow disabling persistent notification in Android 8.0 and up: eduisters.

+1 Look good to me

Jan 15 2019, 2:51 PM · KDE Connect

eduisters resigned from D18181: Allow disabling persistent notification in Android 8.0 and up.

Jan 15 2019, 2:37 PM · KDE Connect

eduisters requested review of D18264: Update for Android Studio 3.3.

Jan 15 2019, 2:16 PM · KDE Connect

Jan 13 2019

eduisters added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

In D18212#392520, @sredman wrote:

The downside of this patch is it changes the default: I was very confused that I couldn't immediately see my USB drive and internal storage from Dolphin. Our per-plugin settings are very non-obvious :/. Is it possible to either display a dummy "you need to configure settings" file, or to show everything by default (as things currently are) and leave the settings so advanced users can hide filesystems if they like?

Jan 13 2019, 4:36 PM · KDE Connect

eduisters claimed T5384: Fix the SFTP plugin on some phones (use Android Storage Access Framework?).

Should be fixed by D18212

Jan 13 2019, 4:15 PM · KDE Connect

eduisters placed T8289: Share whole folder up for grabs.

Releasing this task for now

Jan 13 2019, 4:10 PM · Junior Jobs, KDE Connect

eduisters updated the test plan for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Jan 13 2019, 2:52 PM · KDE Connect

eduisters updated the test plan for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Jan 13 2019, 2:52 PM · KDE Connect

eduisters updated the diff for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Properly handle the situation where no storage locations have been configured
Handle preference changes
Allow deleting of the last storage location
Always create the right FileSystemView depending on Build.VERSION
Remove erroneous leftover from re-fractoring SftpSettingsActivity into SftpSettingsFragment
Commented out entries needed to debug org.apache.sshd
Remove unused variables
Remove optional WRITE_EXTERNAL_STORAGE permission because it is always granted on Build.VERSION < KITKAT
Remove required WRITE_EXTERNAL_STORAGE permission because it is always granted on Build.VERSION < 23 at installation time and we now use SaF starting Build.VERSION >= 21
Remove unneeded PreferenceFragmentCompat.OnPreferenceStartScreenCallback

Jan 13 2019, 2:27 PM · KDE Connect

eduisters requested review of D18223: Just set UDSEntry::UDS_NAME to the actual directory name instead of the hardcoded string "folder" and don't set UDSEntry::UDS_DISPLAY_NAME at all.

Jan 13 2019, 1:53 PM · KDE Connect

eduisters abandoned D18211: Android now exports a virtual root containing only the configured storage display names as root entries.

Commit message and title are completely wrong for this patch, starting over

Jan 13 2019, 1:48 PM · KDE Connect

eduisters planned changes to D18211: Android now exports a virtual root containing only the configured storage display names as root entries.

Fixing a bug

Jan 13 2019, 9:14 AM · KDE Connect

Jan 12 2019

eduisters planned changes to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Forgot to remove some WIP stuff

Jan 12 2019, 10:37 PM · KDE Connect

eduisters added a reviewer for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above): KDE Connect.

Jan 12 2019, 6:45 PM · KDE Connect

eduisters added a reviewer for D18211: Android now exports a virtual root containing only the configured storage display names as root entries: KDE Connect.

Jan 12 2019, 6:39 PM · KDE Connect

eduisters requested review of D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Jan 12 2019, 6:32 PM · KDE Connect

eduisters requested review of D18211: Android now exports a virtual root containing only the configured storage display names as root entries.

Jan 12 2019, 6:29 PM · KDE Connect

eduisters requested changes to D18181: Allow disabling persistent notification in Android 8.0 and up.

I think changing the title to "Persistent Notification" and summary to "Click to enable/disable in Notification settings" would be better for Oreo and newer

Jan 12 2019, 11:40 AM · KDE Connect

Jan 11 2019

eduisters requested changes to D18181: Allow disabling persistent notification in Android 8.0 and up.

The "Show persistent notifications" switch should represent reality. If it's on the notification should be displayed and if it's off the notification should not be visible.

Jan 11 2019, 1:07 PM · KDE Connect