Differential D17409

Do not create a new content fragment on orientation change
ClosedPublic
Actions

Authored by eduisters on Dec 7 2018, 5:22 PM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R225:3a189d1af4d0: Do not create a new content fragment on orientation change
Summary

When an orientation change occurs the fragment manager will automatically
re-create the content fragment for us.

Test Plan

Set the content fragment to DeviceFragment and change orientation
Result: DeviceFragment is shown for the correct device and the correct navigation view menu item is checked

Set the content fragment to PairingFragment and change orientation
Result: PairingFragment is shown for the correct device and the "Pair new device" navigation view menu item is checked

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eduisters created this revision.Dec 7 2018, 5:22 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 7 2018, 5:22 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Dec 7 2018, 5:22 PM
nicolasfella accepted this revision.Dec 7 2018, 7:37 PM
This revision is now accepted and ready to land.Dec 7 2018, 7:37 PM
Closed by commit R225:3a189d1af4d0: Do not create a new content fragment on orientation change (authored by eduisters). · Explain WhyDec 8 2018, 1:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 47105

View Options

src/org/kde/kdeconnect/UserInterface/MainActivity.java

Loading...