Differential D17236

Align NetworkPacket.hasPayload with desktop
ClosedPublic
Actions

Authored by eduisters on Nov 29 2018, 3:39 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R225:4dd651b386ea: Align NetworkPacket.hasPayload with desktop

Summary

On desktop NetworkPacket.hasPayload() tests m_payloadSize
On android NetworkPacket.hasPayload() tests mPayload

This patch makes android also test mPayloadSize to make things more consistent

Diff Detail

Repository

R225 KDE Connect - Android application

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

eduisters created this revision.Nov 29 2018, 3:39 PM

Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 29 2018, 3:39 PM

Restricted Application added a subscriber: kdeconnect. · View Herald Transcript

eduisters requested review of this revision.Nov 29 2018, 3:39 PM

Harbormaster completed remote builds in B5505: Diff 46482.Nov 29 2018, 3:39 PM

eduisters mentioned this in D17235: Handle receiving an empty file.Nov 29 2018, 4:43 PM

albertvaka accepted this revision.Nov 29 2018, 10:19 PM

This revision is now accepted and ready to land.Nov 29 2018, 10:19 PM

Rebased onto master

Harbormaster completed remote builds in B5534: Diff 46532.Nov 30 2018, 7:39 AM

Closed by commit R225:4dd651b386ea: Align NetworkPacket.hasPayload with desktop (authored by eduisters). · Explain WhyNov 30 2018, 7:41 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java (3 lines)
M			src/org/kde/kdeconnect/NetworkPacket.java (2 lines)

Diff 46533

src/org/kde/kdeconnect/Backends/LanBackend/LanLink.java

Loading...

src/org/kde/kdeconnect/NetworkPacket.java

Loading...