Reorder placeholders for i18n c-format compatibility
ClosedPublic

Authored by sdepiets on Dec 19 2018, 2:09 PM.

Details

Summary

Currently a2po exports files with a c-format tag, which means that plural forms "Failed receiving file from %2$s" are invalid for instance (it should be %1 to %n). Translations are subsequently blocked by the subversion pre-commit hooks.

This fix reorders the placeholders.

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
i18n_plurals
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6183
Build 6201: arc lint + arc unit
sdepiets created this revision.Dec 19 2018, 2:09 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 19 2018, 2:09 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
sdepiets requested review of this revision.Dec 19 2018, 2:09 PM
sdepiets retitled this revision from Change placeholders order for i18n c-format compatibility to Reorder placeholders for i18n c-format compatibility.Dec 19 2018, 2:11 PM
sdepiets edited the summary of this revision. (Show Details)
sdepiets added a reviewer: KDE Connect.
sdepiets updated this revision to Diff 47847.Dec 19 2018, 2:14 PM

Fix parameters order

eduisters accepted this revision.Dec 20 2018, 2:36 PM
This revision is now accepted and ready to land.Dec 20 2018, 2:36 PM
sdepiets closed this revision.Dec 20 2018, 3:41 PM