Differential D17259

Clear currentShareInfo when transfer is complete
ClosedPublic
Actions

Authored by eduisters on Nov 30 2018, 2:53 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:6fb6ea7e2bcb: Clear currentShareInfo when transfer is complete
Summary

currentShareInfo needs to be nulled when a transfer is complete if not the next transfer will
have incorrect notification information and will never finish

Test Plan

Send 2 files from desktop to android, notification is as expected (eg (File 1 of 2) followed by (File 2 of 2)
When transfer is complete send 2 files again, notification is as expected and is finished when transfer is done

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eduisters created this revision.Nov 30 2018, 2:53 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptNov 30 2018, 2:53 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Nov 30 2018, 2:53 PM
eduisters planned changes to this revision.Nov 30 2018, 3:05 PM

Needs to be done in onError as well

eduisters updated this revision to Diff 46568.Nov 30 2018, 3:30 PM
  • Always clear currentShareInfo in FinishReceivingRunnable
albertvaka accepted this revision.Nov 30 2018, 4:45 PM
This revision is now accepted and ready to land.Nov 30 2018, 4:45 PM
Closed by commit R225:6fb6ea7e2bcb: Clear currentShareInfo when transfer is complete (authored by eduisters). · Explain WhyNov 30 2018, 4:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 46575

View Options

src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java

Loading...