Differential D17875

Do not continue displaying the previous track's album art image when the new track's albumArtUrl is empty
ClosedPublic
Actions

Authored by eduisters on Dec 30 2018, 5:45 PM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R225:abba7f11328f: Do not continue displaying the previous track's album art image when the new…
Summary

When a new track starts playing and does not have album art the previously displayed
album art image will be displayed until a new track starts playing that does have
album art

Test Plan

Before applying this patch play a track that has album art followed by a song
that does not have album art. Notice that when the track without album art starts
playing the album art of the previous track is still displayed

Apply patch, repeat previous test and notice that the album art placeholder is displayed
when the track without album art start playing

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
eduisters created this revision.Dec 30 2018, 5:45 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptDec 30 2018, 5:45 PM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
eduisters requested review of this revision.Dec 30 2018, 5:45 PM
nicolasfella accepted this revision.Jan 5 2019, 6:51 PM
This revision is now accepted and ready to land.Jan 5 2019, 6:51 PM
Closed by commit R225:abba7f11328f: Do not continue displaying the previous track's album art image when the new… (authored by eduisters). · Explain WhyJan 6 2019, 11:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 48791

View Options

src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java

Loading...