Feed Advanced Search

Mar 14 2017

vpilo added reviewers for D4799: Delay notifications until desktop session has loaded: davidedmundson, dfaure, broulik, graesslin, mck182.
Mar 14 2017, 10:06 AM · Plasma, Frameworks
vpilo added reviewers for D5012: Delay notifications until desktop session has loaded: graesslin, dfaure, davidedmundson, broulik, mck182.
Mar 14 2017, 10:05 AM · Plasma

Mar 10 2017

vpilo added reviewers for D5012: Delay notifications until desktop session has loaded: Plasma, Plasma: Workspaces.
Mar 10 2017, 11:26 PM · Plasma
vpilo updated the diff for D4799: Delay notifications until desktop session has loaded.

New patchset.
I moved the waiting program to plasma-workspace, as per the suggestions (thanks). I also didn't like it much there, but didn't know where it would have fitted better.

Mar 10 2017, 11:25 PM · Plasma, Frameworks
vpilo added a dependency for D5012: Delay notifications until desktop session has loaded: D4799: Delay notifications until desktop session has loaded.
Mar 10 2017, 11:24 PM · Plasma
vpilo added a dependent revision for D4799: Delay notifications until desktop session has loaded: D5012: Delay notifications until desktop session has loaded.
Mar 10 2017, 11:24 PM · Plasma, Frameworks
vpilo created D5012: Delay notifications until desktop session has loaded.
Mar 10 2017, 11:24 PM · Plasma

Mar 9 2017

vpilo updated the diff for D4799: Delay notifications until desktop session has loaded.

New version, using the idea suggested by @davidedmundson .

Mar 9 2017, 12:41 AM · Plasma, Frameworks

Mar 3 2017

vpilo committed R260:04f2546d62f2: Allow hiding the status bar (authored by vpilo).
Allow hiding the status bar
Mar 3 2017, 11:12 AM
vpilo closed D4901: Fix bug 202414 - Allow hiding the status bar by committing R260:04f2546d62f2: Allow hiding the status bar.
Mar 3 2017, 11:12 AM · KDE Applications
vpilo added a comment to D4901: Fix bug 202414 - Allow hiding the status bar.

Thanks! On a side note, how do I find out who are the best people to assign reviews to per every repository I'd like to submit to?

Mar 3 2017, 9:42 AM · KDE Applications

Mar 2 2017

vpilo updated the summary of D4901: Fix bug 202414 - Allow hiding the status bar.
Mar 2 2017, 6:27 PM · KDE Applications
vpilo updated the diff for D4901: Fix bug 202414 - Allow hiding the status bar.

Fix full screen switching

Mar 2 2017, 6:26 PM · KDE Applications
vpilo created D4901: Fix bug 202414 - Allow hiding the status bar.
Mar 2 2017, 6:25 PM · KDE Applications
vpilo added a comment to D4799: Delay notifications until desktop session has loaded.

There is another solution that would work without any changes to KNotification.

DBus has a solution to buffer messages and wait for a name to become available, it happens in DBus activation. If plasmashell was DBus activated on org.freedesktop.Notifications we wouldn't have this problem at all.

Making plasmashell do that is probably a bit weird, but there is a hack we can do that I've seen done in Telepathy. Instead of activating plasmashell we have a small binary that gets DBus activated but simply idles waits for org.freedesktop.Notifications to become available then quits.

DBus-daemon thinks it's launched something and happily waits for the name to become available queuing the messages. Knotification can just fire and forget as normal.
The only time there's any performance penalty is if you do send a notification pre-plasmashell starting up, and it's quite minor.

I've tested this using, https://paste.kde.org/pwdqvevvo
running "notify-send foobar"
then waiting 10 seconds and starting plasmashell

Notification appeared perfectly.

We'd need to re-implement mc-wait-for-name in Plasma code (or just use Exec=sleep 30)

Mar 2 2017, 11:58 AM · Plasma, Frameworks

Mar 1 2017

vpilo committed R289:76ca9bc01c6f: Removed some dead code. (authored by vpilo).
Removed some dead code.
Mar 1 2017, 6:46 PM
vpilo closed D4801: KNotifications cleanup by committing R289:76ca9bc01c6f: Removed some dead code..
Mar 1 2017, 6:46 PM · Frameworks

Feb 28 2017

vpilo added a comment to D4799: Delay notifications until desktop session has loaded.
In D4799#91109, @dfaure wrote:

Yes interface->isServiceRegistered(dbusServiceName) is technically blocking, but it can't block for a long time, since it's only talking to the dbus daemon. The reply comes in rather quickly, unlike a blocking call to another KDE process which could be busy or where the call itself could take a long time to be processed.
In summary, I don't think an existing call to isServiceRegistered can be used as an argument for making (potentially much much longer) blocking calls.

Feb 28 2017, 9:50 PM · Plasma, Frameworks
vpilo added a comment to D4799: Delay notifications until desktop session has loaded.

@mck182 I didn't notice before, but KNotifications is already making blocking calls on creation:

Feb 28 2017, 8:50 AM · Plasma, Frameworks

Feb 27 2017

vpilo updated the summary of D4801: KNotifications cleanup.
Feb 27 2017, 2:49 PM · Frameworks

Feb 26 2017

vpilo added a comment to D4799: Delay notifications until desktop session has loaded.
In D4799#90169, @dfaure wrote:

About the code in kded that calls ksplash: that code is obsolete and currently only kept for compatibility reasons, see https://git.reviewboard.kde.org/r/129010/
IOW you can ignore that code completely.

Feb 26 2017, 9:08 PM · Plasma, Frameworks
vpilo added a comment to D4799: Delay notifications until desktop session has loaded.

@graesslin I disagree. Some popups might be useful, some are very useful; we should aim to never drop any. Just as an example, the popup with the Yakuake console toggle key is pretty fundamental to be reminded of, the first few times you start it up.

Feb 26 2017, 6:38 PM · Plasma, Frameworks
vpilo added a comment to D4799: Delay notifications until desktop session has loaded.
In D4799#89931, @mck182 wrote:

Thanks for the patch! I wanted to do exactly this a long
time ago. However this solution brings a burden to all
apps using KNotification in form of a blocking dbus call
which is further only relevant when used in Plasma.

That's a no-no I'm afraid, we'd have to find a better solution.

Feb 26 2017, 12:29 AM · Plasma, Frameworks

Feb 25 2017

vpilo created D4801: KNotifications cleanup.
Feb 25 2017, 11:45 PM · Frameworks
vpilo created D4799: Delay notifications until desktop session has loaded.
Feb 25 2017, 11:39 PM · Plasma, Frameworks