mck182 (Martin Klapetek)
Executive

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2015, 10:22 AM (239 w, 3 d)
Availability
Available

Recent Activity

Aug 6 2019

mck182 removed a member for Plasma: Mobile: mck182.
Aug 6 2019, 6:26 PM

Mar 10 2019

mck182 accepted D19649: Add COPYING file.

👍

Mar 10 2019, 6:03 PM

Jun 6 2018

Alexander Akulich <a.akulich@omprussia.ru> committed R145:2ed0b9ee71a7: [declarative] Add getters to MessageModel for lastMessage and… (authored by mck182).
[declarative] Add getters to MessageModel for lastMessage and…
Jun 6 2018, 10:35 AM
Alexander Akulich <a.akulich@omprussia.ru> committed R145:e1aa825d1487: [declarative] Add roles to MessagesModel that allows painting the messages… (authored by mck182).
[declarative] Add roles to MessagesModel that allows painting the messages…
Jun 6 2018, 10:35 AM
Alexander Akulich <a.akulich@omprussia.ru> committed R145:33fc59f091b8: [declarative] Add "ready" property to TelepathyManager and call becomeReady()… (authored by mck182).
[declarative] Add "ready" property to TelepathyManager and call becomeReady()…
Jun 6 2018, 10:35 AM
Alexander Akulich <a.akulich@omprussia.ru> committed R145:cf0c7572692f: [declarative] Allow later setting of Tp::Account to Conversation (authored by mck182).
[declarative] Allow later setting of Tp::Account to Conversation
Jun 6 2018, 10:35 AM

Sep 1 2017

mck182 added a comment to D7633: [Digital Clock] Compact and move to the end font setup.

The horizontal alignment of the label is off compared to the rest of the labels, I guess it's because it's not in a groupbox.

Sep 1 2017, 9:50 AM · Plasma
mck182 added a comment to F3893899: Screenshot_20170831_171303.png.

The horizontal alignment of the label is off compared to the rest of the labels, I guess it's because it's not in a groupbox.

Sep 1 2017, 9:49 AM

Jul 28 2017

mck182 updated subscribers of D6963: Don't block starting notification service.

@dvratil has slightly more elaborate solution at https://phabricator.kde.org/D6960

Jul 28 2017, 4:33 PM · Frameworks

Jun 2 2017

mck182 added a comment to D6059: Add a test that adds a notification and closes it.

That's up to Kai/VDG, I guess. I was just wondering what changed
from the previous patch where everyone agreed to not do it because
it would be confusing.

Jun 2 2017, 11:05 PM · Plasma

Jun 1 2017

mck182 added a comment to D6059: Add a test that adds a notification and closes it.

This was discussed at length in https://phabricator.kde.org/D4215

Jun 1 2017, 3:21 PM · Plasma

May 8 2017

mck182 added a comment to D5727: Disable create form while creating new accounts.

Well, technically you cannot add new strings only
and new features only, adding the busy spinner
would be ok as it's a fix for a bug.

May 8 2017, 3:05 PM
mck182 added a comment to D5727: Disable create form while creating new accounts.

I think this could also use some loading
indicator? Like the busy widget or at least
some label somewhere saying "Please wait"?

May 8 2017, 2:45 PM

May 5 2017

mck182 accepted D5718: Improve apidox.

Thank you!

May 5 2017, 3:15 PM · Frameworks

Apr 19 2017

mck182 added a comment to D5503: No "KDE Daemon" in password dialogs.

+1 looks good, although "Dialog hesla" je zvláštní češtin :)

Apr 19 2017, 2:57 PM · Frameworks

Apr 15 2017

mck182 accepted D5424: [Notifications] Introduce "settings" action.

Ah, I see. Good to go then, unless you want to wait for VDG input.

Apr 15 2017, 8:54 PM · Plasma
mck182 added a comment to D5424: [Notifications] Introduce "settings" action.

While I like this, I wonder - for apps that will send "settings"
action there will now be no way to access the KNotification
settings, right (from the notification itself)? As in, the app can
use the "settings" action for an entirely different thing, thus
blocking the standard config UI, maybe?

Apr 15 2017, 8:15 PM · Plasma

Apr 11 2017

mck182 accepted D5346: DigitalClock: Use correct language for month and day names.

Same as the other diff, if safe, good to go.

Apr 11 2017, 2:57 AM · Plasma
mck182 accepted D5345: Calendar: Use correct language for month and day names.

...provided the usage of uiLanguages[0] is safe like this.

Apr 11 2017, 2:54 AM · Frameworks, Plasma

Apr 6 2017

mck182 added a comment to D5324: Revert "[calendar] Use ui language for getting the month name".

I disagree with this because we currently don't have any
easy and/or sensible way to change date formats and so
we simply suggest using different locales for the different
formats. However, if your UI language is all Spanish and
you want to use the US date formatting, the month name
labels would suddenly be in English while they should
remain Spanish (and this is what the code you're removing
does).

Apr 6 2017, 7:00 PM · Frameworks, Plasma

Mar 9 2017

mck182 added a comment to D4799: Delay notifications until desktop session has loaded.

Looks like this could work. The KDE_FULL_SESSION check is
really old, I'm not sure if this has any implications.

Mar 9 2017, 4:26 PM · Plasma, Frameworks

Feb 26 2017

mck182 added a comment to D4799: Delay notifications until desktop session has loaded.
  1. A quick check if KSplashQML is found in the processes list (afaics, there's no alternatives to ksplash)
  2. KNotifications could send an async call to KSplash with a very quick timeout and start deciding on its queued notifications if/after the answer arrives
Feb 26 2017, 6:07 AM · Plasma, Frameworks
mck182 added a comment to D4663: Allow setting the timeout value..

To expand on what Thomas said, SNI is just a specification,
the implementation is fully up to the shells. We chose to
implement it as systray icons, but some innovation there
could take it to much different places. So far nobody has
come with ideas of what that innovation may be, however.

Feb 26 2017, 5:52 AM · Frameworks
mck182 added a comment to D4799: Delay notifications until desktop session has loaded.

Thanks for the patch! I wanted to do exactly this a long
time ago. However this solution brings a burden to all
apps using KNotification in form of a blocking dbus call
which is further only relevant when used in Plasma.

Feb 26 2017, 12:01 AM · Plasma, Frameworks

Feb 25 2017

mck182 accepted D4629: Install camelcase headers.

Are you sure this doesn't break any existing stuff that is using these headers?

Feb 25 2017, 4:12 AM

Feb 23 2017

mck182 accepted D4720: Show icons of account services.

I think this is good. Might look a bit weird when you
have a whole bunch of services with default icons
but oh well.

Feb 23 2017, 3:59 AM
mck182 accepted D4723: Ask confirmation before removing accounts.
Feb 23 2017, 3:57 AM

Feb 22 2017

mck182 added a comment to D4720: Show icons of account services.

Ok, can you perhaps put some other/generic/nice icon
if the iconName() is empty? Just to keep the list consistent?
Or maybe put the icon elsewhere so that it won't affect the
alignment? But I ain't no designer..

Feb 22 2017, 5:21 PM
mck182 added a comment to D4720: Show icons of account services.

What happens when the service provides no icon
name or an icon that cannot be found? Can you
please test that?

Feb 22 2017, 5:12 PM
mck182 added a comment to D4663: Allow setting the timeout value..
I don't think that KNotification as a framework should hide this feature from the developer.
Feb 22 2017, 2:36 AM · Frameworks

Feb 21 2017

mck182 added a comment to D4663: Allow setting the timeout value..

Well, I would argue that Android is using exactly indicators
which we know as SNIs. It's the same thing - it's an icon in
your top panel and when you pull the panel down, you see
the title, text and available actions. This is _exactly_ what
SNI does, it just so happens that on desktop the representation
is always an icon with context menu. It has title, text and
actions and is often accompanied by a popup notification.

Feb 21 2017, 3:02 PM · Frameworks

Feb 18 2017

mck182 accepted D4638: Add Google Drive scopes.

I'm happy to (try to) hand over the access to the set of keys used for KAccounts if there's some action towards that. It should probably be handled by sysadmin in the name of KDE e.V. while granting manage rights to (KAccounts) developers.

Feb 18 2017, 6:54 PM
mck182 added a comment to D4663: Allow setting the timeout value..

I see your usecase, but I think there might be better solution overall
and that would involve not actually depending on the notification. As
you say, servers should enforce maximum timeout, Plasma does just
that and there's no safe way to predict what other servers would do.

Feb 18 2017, 6:49 PM · Frameworks
mck182 added a comment to D4663: Allow setting the timeout value..

This was discussed couple times before and the reason
this was never added is because of potential misuse of
this by setting extremely high value, making the bubble
virtually sticked to your screen forever. This should be
handled by the server that should do the right thing(tm)
like eg. Plasma does a word count and then with simple
heuristic determines the display time. Regardless of
Plasma however, the server should always have a sensible
default that all apps should follow, therefore this option
was never added and I still think it shouldn't be there
today; I can't see a reason why would you want the
bubble to be displayed for either very short time or very
long time. For anything in between the server default
should be good enough.

Feb 18 2017, 3:42 PM · Frameworks
mck182 added a comment to D4638: Add Google Drive scopes.

so that it's all managed "centrally".

Feb 18 2017, 12:54 AM

Feb 17 2017

mck182 added a comment to D4638: Add Google Drive scopes.

Ok, it's enabled now, but please beware that there are quotas in effect:

Feb 17 2017, 3:27 PM
mck182 added inline comments to D4638: Add Google Drive scopes.
Feb 17 2017, 3:19 PM
mck182 added a comment to D4638: Add Google Drive scopes.

I'll see if I still have access.

Feb 17 2017, 3:16 PM

Feb 16 2017

mck182 added a comment to D4632: [Notifications] Never manually hide() the NotificationPopup.

it's quite a mess

Feb 16 2017, 8:22 PM · Plasma

Feb 13 2017

mck182 added a comment to D4545: Centralize interaction with notifications.

Can we please fix and ship this quickly? https://phabricator.kde.org/D4142 shouldn't really have been shipped in that state.

Feb 13 2017, 4:57 PM · Plasma

Feb 4 2017

mck182 added a comment to D4416: Send desktopfilename as part of notifyByPopup hints.
In D4416#82951, @hein wrote:

Gnome-only spec? Why aren't they contributing to fd.o?

Feb 4 2017, 3:32 PM · Frameworks, Plasma

Feb 1 2017

mck182 accepted D4357: Re-enable Log-to-File for KNotifications.

Looks good, should be fine.

Feb 1 2017, 3:52 PM · Frameworks

Jan 24 2017

mck182 added a comment to D4215: Make notifications execute the "default" action on click..

Thanks, that's a nice list. I think real examples using actual native apps would provide better insight (like calendar, low battery or music player notification), but that'd be like a weekend project, so it's ok.

Jan 24 2017, 4:46 PM · Plasma

Jan 23 2017

mck182 added a reviewer for D4253: redesign gwenview icon: andreask.
Jan 23 2017, 6:59 PM · Frameworks
mck182 added a comment to D4215: Make notifications execute the "default" action on click..

Fair enough.

Jan 23 2017, 5:22 AM · Plasma

Jan 21 2017

mck182 added a comment to D4215: Make notifications execute the "default" action on click..

Well there you go then. Just implement the default action to be always the top-most button in our actions list and make clicking the popup always execute the first action in the list. That way, if there are buttons, the user will know that clicking the popup will trigger the first action. No buttons means clicking won't do anything.

Jan 21 2017, 6:51 PM · Plasma
mck182 added a comment to D4215: Make notifications execute the "default" action on click..

I think Plasma is the only notification system that does close-on-activate instead of executing some action

Jan 21 2017, 6:35 AM · Plasma

Jan 20 2017

mck182 added a comment to D4215: Make notifications execute the "default" action on click..

I have never considered unpredictable on Android that when I press the "new e-mail" notification I get the e-mail client with the new e-mail.

Jan 20 2017, 6:47 PM · Plasma
mck182 added a comment to D4215: Make notifications execute the "default" action on click..

If you just want to close then you have the big X, no?

Jan 20 2017, 4:46 PM · Plasma
mck182 added a comment to D4215: Make notifications execute the "default" action on click..

-1, I don't want to keep thinking "am I now going to close the notification or execute an action" everytime I'm about to click the notification popup.

Jan 20 2017, 3:46 PM · Plasma

Jan 9 2017

mck182 added a comment to D4050: add a "Plasma made by KDE" sign in the splash.

If I may add a slightly unrelated comment - the circly parts of the new logo seem to throw the spinner a bit off visually, I think it could use some larger spacing in between those two.

Jan 9 2017, 6:42 PM · Plasma

Jan 3 2017

mck182 resigned from D3811: Use KPlugin for calendar applet plugins.

Code looks good to me but I also don't have a setup to test this on anymore.

Jan 3 2017, 3:55 AM · Frameworks

Sep 10 2016

mck182 committed R108:250e5751ce65: [kwin] Client of type NET::Notification should have no borders (authored by mck182).
[kwin] Client of type NET::Notification should have no borders
Sep 10 2016, 6:33 AM
mck182 committed R108:ec2bbf049432: [kwin] Make KWin place the OSD (authored by mck182).
[kwin] Make KWin place the OSD
Sep 10 2016, 6:33 AM
mck182 committed R108:bd017beea00a: Fix an assert on KWin shutdown (authored by mck182).
Fix an assert on KWin shutdown
Sep 10 2016, 6:32 AM
mck182 committed R108:57d036eec769: Port to KF5 renaming changes (authored by mck182).
Port to KF5 renaming changes
Sep 10 2016, 6:31 AM
mck182 committed R108:f469ec9baa47: Inform KSplash via DBus about kwin startup (authored by mck182).
Inform KSplash via DBus about kwin startup
Sep 10 2016, 6:30 AM
mck182 committed R154:5bcc36d7d093: Bump version to 0.8.0 (authored by mck182).
Bump version to 0.8.0
Sep 10 2016, 4:13 AM
mck182 committed R145:3ab5991f6e08: Don't install removed header (authored by mck182).
Don't install removed header
Sep 10 2016, 4:09 AM
mck182 committed R145:779bd2089346: Tp::ContactPtr -> KTp::ContactPtr (authored by mck182).
Tp::ContactPtr -> KTp::ContactPtr
Sep 10 2016, 4:09 AM
mck182 committed R145:d361bc412fa5: Fix build issues (authored by mck182).
Fix build issues
Sep 10 2016, 4:09 AM
mck182 committed R145:9bbf969c125d: Remove remaining nickname and alias roles usage (authored by mck182).
Remove remaining nickname and alias roles usage
Sep 10 2016, 4:09 AM
mck182 committed R145:affbd32a7642: Handle tubes more generically in the filter (authored by mck182).
Handle tubes more generically in the filter
Sep 10 2016, 4:09 AM
mck182 committed R145:199a2a70aca1: Port to new model roles, part 1 (authored by mck182).
Port to new model roles, part 1
Sep 10 2016, 4:09 AM
mck182 committed R145:cc4d6d619fb2: Remove FilterByMediaCallCapability, the role is gone from the models now (authored by mck182).
Remove FilterByMediaCallCapability, the role is gone from the models now
Sep 10 2016, 4:09 AM
mck182 committed R145:b59093ee551c: Remove sorting modes (authored by mck182).
Remove sorting modes
Sep 10 2016, 4:09 AM
mck182 committed R145:5732da4b096c: Port to KTp roles (authored by mck182).
Port to KTp roles
Sep 10 2016, 4:09 AM
mck182 committed R145:bb9b185e2319: Fix typo (authored by mck182).
Fix typo
Sep 10 2016, 4:09 AM
mck182 committed R145:74e4e8319925: ContactModelRole -> ContactsModelRole (authored by mck182).
ContactModelRole -> ContactsModelRole
Sep 10 2016, 4:08 AM
mck182 committed R146:bdd41807a9cd: Make the presence message persistant (ie. it stays when the contact list is… (authored by mck182).
Make the presence message persistant (ie. it stays when the contact list is…
Sep 10 2016, 4:00 AM
mck182 committed R146:d601b558ccaf: Preparation for groups expanding upon startup (authored by mck182).
Preparation for groups expanding upon startup
Sep 10 2016, 4:00 AM
mck182 committed R146:b3d8dc58e258: Notification icons test (authored by mck182).
Notification icons test
Sep 10 2016, 4:00 AM
mck182 committed R146:0c9e7d4001b6: Prevent avatars going impossibly too big in remove dialog (authored by mck182).
Prevent avatars going impossibly too big in remove dialog
Sep 10 2016, 4:00 AM
mck182 committed R146:00a2582c87f4: Use shared channel hint for bypassing the plasmoid when launching chats. (authored by davidedmundson).
Use shared channel hint for bypassing the plasmoid when launching chats.
Sep 10 2016, 3:59 AM
mck182 committed R146:079eba048fb5: Update FindKTp.cmake (authored by Daniele E. Domenichelli <daniele.domenichelli@gmail.com>).
Update FindKTp.cmake
Sep 10 2016, 3:59 AM
mck182 committed R146:5393ba2d5ad6: Port to the updated AccountsFilterModel (authored by Daniele E. Domenichelli <daniele.domenichelli@gmail.com>).
Port to the updated AccountsFilterModel
Sep 10 2016, 3:59 AM
mck182 committed R146:aa94b03e763a: Add support for showing available rooms in join chat room dialog (authored by cermak).
Add support for showing available rooms in join chat room dialog
Sep 10 2016, 3:59 AM
mck182 committed R146:8a10f16676f0: Last bunch of porting \o/ (authored by mck182).
Last bunch of porting \o/
Sep 10 2016, 3:59 AM
mck182 committed R146:806b46f07424: Porting+++ (authored by mck182).
Porting+++
Sep 10 2016, 3:59 AM
mck182 committed R146:ae77b86a43bd: Porting++ (authored by mck182).
Porting++
Sep 10 2016, 3:59 AM
mck182 committed R146:b8493cc1141a: Fix typo (authored by mck182).
Fix typo
Sep 10 2016, 3:59 AM
mck182 committed R106:6f0be2cd8d9f: Port to KF5 renaming changes (authored by mck182).
Port to KF5 renaming changes
Sep 10 2016, 3:59 AM
mck182 committed R146:2b3d3dca0a80: Update contact-overlays to the new model roles (authored by mck182).
Update contact-overlays to the new model roles
Sep 10 2016, 3:59 AM
mck182 committed R146:4d7e50aa9310: First bunch of refactors (authored by mck182).
First bunch of refactors
Sep 10 2016, 3:59 AM

Jul 20 2016

mck182 added a comment to D2212: Reduce Calendar size in Digital clock.
In D2212#41055, @drosca wrote:

The calendar popup size is fine for me (with patched plasma-framework), what I *still* think is broken is the gridSize scaling - see https://git.reviewboard.kde.org/r/125773/

You can also test it simply by switching font to DejaVu Sans.

Jul 20 2016, 1:20 PM · Plasma

Jul 19 2016

mck182 added a comment to D2212: Reduce Calendar size in Digital clock.

Can you post a screenshot of before/after?

Jul 19 2016, 2:48 AM · Plasma

Jun 11 2016

mck182 committed R164:d897475c11d2: [app] Send the text from the emoji QTextDocument instead of the TextArea… (authored by mck182).
[app] Send the text from the emoji QTextDocument instead of the TextArea…
Jun 11 2016, 7:27 PM · SpaceBar
mck182 committed R164:9d775d251350: [app] Move a connection out of EmojiTextAera as it does not belong there (authored by mck182).
[app] Move a connection out of EmojiTextAera as it does not belong there
Jun 11 2016, 7:27 PM · SpaceBar
mck182 committed R164:d5af32d85b84: [app] Some leftovers (authored by mck182).
[app] Some leftovers
Jun 11 2016, 7:27 PM · SpaceBar
mck182 committed R164:d99d60c952e4: [app] Improve the emojis OverlaySheet significantly (authored by mck182).
[app] Improve the emojis OverlaySheet significantly
Jun 11 2016, 7:27 PM · SpaceBar
mck182 committed R164:e3ba17be9227: [app] Split the emoji handling TextArea to separate file (authored by mck182).
[app] Split the emoji handling TextArea to separate file
Jun 11 2016, 7:27 PM · SpaceBar
mck182 moved T1790: Support persistent unread message state from Issues to sort out to In progress on the SpaceBar board.
Jun 11 2016, 6:57 PM · SpaceBar
mck182 closed T2203: Opening second conversation needs to close the first one first as Resolved.
Jun 11 2016, 6:57 PM · SpaceBar
mck182 moved T2203: Opening second conversation needs to close the first one first from In progress to Done (to show closed tasks click 'All Tasks View' on the left) on the SpaceBar board.
Jun 11 2016, 6:56 PM · SpaceBar
mck182 moved T2203: Opening second conversation needs to close the first one first from Issues to sort out to In progress on the SpaceBar board.
Jun 11 2016, 6:55 PM · SpaceBar
mck182 closed T2329: Emojis support as Resolved.
Jun 11 2016, 6:54 PM · SpaceBar
mck182 closed T2201: Message input needs to be autoextending text view as Resolved.
Jun 11 2016, 6:54 PM · SpaceBar
mck182 moved T2329: Emojis support from In progress to Done (to show closed tasks click 'All Tasks View' on the left) on the SpaceBar board.
Jun 11 2016, 6:54 PM · SpaceBar
mck182 moved T2201: Message input needs to be autoextending text view from In progress to Done (to show closed tasks click 'All Tasks View' on the left) on the SpaceBar board.
Jun 11 2016, 6:54 PM · SpaceBar
mck182 closed T2200: Presence icon missing in conversation when offline as Resolved.
Jun 11 2016, 6:54 PM · SpaceBar