Differential D4801

KNotifications cleanup
ClosedPublic
Actions

Authored by vpilo on Feb 25 2017, 11:45 PM.

Details

Reviewers
apol
Commits
R289:76ca9bc01c6f: Removed some dead code.
Summary

Removed some dead code, killed exactly 2 years ago by commit ac03fd69dece.
Moving notifications plugins used directly by KNotificationsManager made some context and pixmap updating code redundant, but it was never removed.

Diff Detail

Repository
R289 KNotifications
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vpilo created this revision.Feb 25 2017, 11:45 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 25 2017, 11:45 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
vpilo edited the summary of this revision. (Show Details)Feb 27 2017, 2:49 PM
apol accepted this revision.Mar 1 2017, 12:22 PM
apol added a subscriber: apol.

Good catch!

This revision is now accepted and ready to land.Mar 1 2017, 12:22 PM
Closed by commit R289:76ca9bc01c6f: Removed some dead code. (authored by vpilo). · Explain WhyMar 1 2017, 6:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/knotificationmanager.cpp (16 lines)

Diff 12031

View Options

src/knotificationmanager.cpp

Loading...