Better commit message

Thanks

Tests needed :)

In D22143#526887, @rikmills wrote:

This is installing BOTH /etc/xdg/kactivities-stats.categories AND/usr/share/qlogging-categories5/kactivities-stats.categories which is surely wrong?

I'd do the opposite, remove DESCRIPTION and URL from knotification's CMakeLists.txt and only leave the PURPOSE line.

LGTM

@kossebau @vkrause @apol something else to change?

ok, please change the remaining kconf/KCONF to kconfig/KCONFIG and it should be fine.

This shall be compliant with the minimum ECM version set in the project.

+1 LGTM. Probably needs to be rebased

Unless someone has objections, I'll push this tomorrow.

use ${prefix} for the exec line.
For the others, it's a bit trickier since you can use either relative or
absolute paths when calling CMake.

fix path

Note: the ecm_generate_pkgconfig_file macro cannot be used since it doesn't support extra CFLAGS (yet)

LGTM

Good idea

KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS and XDG_DATA_DIRS or even the binary installation dir.

how many users are there?

attic/modules/FindTaglib.cmake shall be deleted.

Maybe also update the commit message to 'Create specific directory for Qt logging categories file'

In D21313#469311, @mlaurent wrote:

Ping ?

Looks mostly fine safe for the directory name that needs the major version to avoid conflicts when libfoo.categories built using KF5 will have to coexist with KF6.
It needs a '5' in its name.

In D21214#465253, @vkrause wrote:

This was added to fix static builds (for which we also need private link dependencies here too). I guess putting that into an if (NOT @BUILD_SHARED_LIBS@) conditional might be the right solution?