Looks good to me.

Makes sense to me, maybe we will use it someday and it doesn't hurt to implement the API.

One point that I think is fundamental to make is that we don't want to be as excluding as Ubuntu and Sailfish did (note that we have several apps ported to Android but none to either of those, because they're far more restrictive!!!!). In principle any Linux application should work on the Plasma Phone so rather than trying to push down a very specific technology we can leverage the whole Linux platform as whole.

In D7752#146072, @brauch wrote:

Ok, you're right ... I looked some more. Try "-pipe", qmake passes that here, that seems to be what breaks things if I'm not mistaken.

In D7752#146024, @brauch wrote:

There are some arguments which we shouldn't pass on, for example I have a qmake project here which does QMAKE_CXXFLAGS += -Werror=return-type and that completely breaks everything (no highlighting any more whatsoever, parsing of all files fails, ...), Not even sure why, but I guess -Werror arguments should never be passed on in our case.

Should I make extraArguments() return a string list and add a blacklist for those? Better ideas?

Use the configured settings if nothing was provided

Good point. I wouldn't go into merging, the whole point of this is to have the file parser use the same settings that the build system will use.

Use flatpak_installed_ref_load_metadata to read the metadata

Here's an issue related to the next version of the patch: https://github.com/flatpak/flatpak/issues/1014

few changes

Cool!
Can we have a unit test too? It shouldn't be hard to adapt one of the current ones.

Also you maybe can move this code into the tests subdirectory, so it only needs to be run in BUILD_TESTING.

Addressed Milian's comments

Rene, you submitted it to the wrong repository.

I like the feature. Thanks!

LGTM

I think we first need to get D7543 in, to be able to depend from the ECM version.

Oh, also I tested it and I confirm it works for me.

The issue has been fixed upstream and the runtimes rebuilt.

The icon is clearly there:

flatpak run --command=find org.kde.kube /usr /app -name password-show-on.svg*
/usr/share/icons/breeze-dark/actions/16/password-show-on.svg
/usr/share/icons/breeze-dark/actions/24/password-show-on.svg
/usr/share/icons/breeze-dark/actions/22/password-show-on.svg
/usr/share/icons/breeze/actions/16/password-show-on.svg
/usr/share/icons/breeze/actions/24/password-show-on.svg
/usr/share/icons/breeze/actions/22/password-show-on.svg
/app/share/icons/kube/actions/16/password-show-on.svg
/app/share/icons/kube/actions/24/password-show-on.svg
/app/share/icons/kube/actions/22/password-show-on.svg