Differential D7866

Set progress for CMakeServerImportJobs
ClosedPublic
Actions

Authored by flherne on Sep 17 2017, 10:09 PM.

Details

Reviewers
apol
Group Reviewers
KDevelop
Commits
R32:ae0976f79c3e: Set progress for CMakeServerImportJob
Summary

This avoids a spam of "unhandled message" warnings to the terminal.

Not using setProgressAmount, because 'progressMaximum' seems to always be 1000 and none of the KJob::Unit options make sense.

TBH, I'm not sure this is useful, wouldn't mind just adding 'progress' to the known-but-ignored check.

Test Plan

Tested that the percentage is set to a sane value with each message. No more stderr spam when loading CMake projects.

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
flherne created this revision.Sep 17 2017, 10:09 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptSep 17 2017, 10:09 PM
apol accepted this revision.Sep 17 2017, 11:25 PM

Makes sense to me, maybe we will use it someday and it doesn't hurt to implement the API.

This revision is now accepted and ready to land.Sep 17 2017, 11:25 PM
Closed by commit R32:ae0976f79c3e: Set progress for CMakeServerImportJob (authored by flherne). · Explain WhySep 18 2017, 12:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 19628

View Options

plugins/cmake/cmakeserverimportjob.cpp

Loading...