Differential D7875

Remove the final endl at the end of qDebug &co
ClosedPublic
Actions

Authored by ltoscano on Sep 18 2017, 8:26 PM.

Tags

Subscribers

Details

Reviewers

Commits

R313:dcc123af2496: Remove the final endl at the end of qDebug &co

Summary

Definitely not needed. A bit less clutter before switching to
categorized logging.

Test Plan

Still compiles, and the debug output does not contain extra
newlines.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ltoscano created this revision.Sep 18 2017, 8:26 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptSep 18 2017, 8:26 PM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

apol accepted this revision.Sep 19 2017, 9:44 AM

This revision is now accepted and ready to land.Sep 19 2017, 9:44 AM

Closed by commit R313:dcc123af2496: Remove the final endl at the end of qDebug &co (authored by ltoscano). · Explain WhySep 20 2017, 3:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/css/css_base.cpp (2 lines)
M			src/css/css_valueimpl.cpp (2 lines)
M			src/css/cssparser.cpp (7 lines)
M			src/css/cssstyleselector.cpp (8 lines)
M			src/dom/QualifiedName.cpp (4 lines)
M			src/ecma/kjs_html.cpp (6 lines)
M			src/editing/editor.cpp (10 lines)
M			src/editing/htmlediting_impl.cpp (144 lines)
M			src/editing/jsediting.cpp (2 lines)
M			src/html/html_elementimpl.cpp (2 lines)
M			src/html/htmlparser.cpp (2 lines)
M			src/html/htmltokenizer.cpp (2 lines)
M			src/imload/decoders/qimageioloader.cpp (4 lines)
M			src/java/kjavaapplet.cpp (2 lines)
M			src/java/kjavaappletcontext.cpp (8 lines)
M			src/java/kjavaappletserver.cpp (28 lines)
M			src/java/kjavaappletwidget.cpp (2 lines)
M			src/java/kjavadownloader.cpp (4 lines)
M			src/java/kjavaprocess.cpp (6 lines)
M			src/khtml_caret.cpp (9 lines)
M			src/khtml_part.cpp (2 lines)
M			src/khtmlview.cpp (18 lines)
M			src/rendering/RenderPath.cpp (2 lines)
M			src/rendering/RenderSVGInlineText.cpp (2 lines)
M			src/rendering/RenderSVGRoot.cpp (10 lines)
M			src/rendering/RenderSVGText.cpp (2 lines)
M			src/rendering/SVGInlineTextBox.cpp (6 lines)
M			src/rendering/SVGRootInlineBox.cpp (24 lines)
M			src/rendering/bidi.cpp (4 lines)
M			src/rendering/render_block.cpp (7 lines)
M			src/rendering/render_container.cpp (2 lines)
M			src/rendering/render_flow.cpp (2 lines)
M			src/rendering/render_form.cpp (2 lines)
M			src/rendering/render_object.cpp (2 lines)
M			src/rendering/render_position.cpp (48 lines)
M			src/rendering/render_replaced.cpp (2 lines)
M			src/rendering/render_table.cpp (10 lines)
M			src/rendering/render_text.cpp (38 lines)
M			src/svg/SVGDocumentExtensions.cpp (2 lines)
M			src/svg/SVGElement.cpp (14 lines)
M			src/svg/SVGGradientElement.cpp (2 lines)
M			src/svg/SVGLinearGradientElement.cpp (4 lines)
M			src/svg/SVGPolyElement.cpp (2 lines)
M			src/svg/SVGRectElement.cpp (2 lines)
M			src/svg/SVGSVGElement.cpp (8 lines)
M			src/svg/SVGStopElement.cpp (2 lines)
M			src/svg/SVGStyleElement.cpp (8 lines)
M			src/svg/SVGTextElement.cpp (2 lines)
M			src/svg/SVGTextPositioningElement.cpp (2 lines)
M			src/svg/SVGURIReference.cpp (4 lines)
M			src/svg/graphics/SVGPaintServerLinearGradient.cpp (2 lines)
M			src/svg/graphics/qt/SVGPaintServerGradientQt.cpp (8 lines)
M			src/svg/graphics/qt/SVGPaintServerRadialGradientQt.cpp (2 lines)
M			src/ui/findbar/khtmlfind.cpp (2 lines)
M			src/xml/dom_docimpl.cpp (8 lines)
M			src/xml/dom_elementimpl.cpp (12 lines)
M			src/xml/dom_position.cpp (44 lines)
M			src/xml/dom_selection.cpp (28 lines)
M			tests/test_regression_gui_window.cpp (10 lines)

Diff 19694

src/css/css_base.cpp

Loading...

src/css/css_valueimpl.cpp

Loading...

src/css/cssparser.cpp

Loading...

src/css/cssstyleselector.cpp

Loading...

src/dom/QualifiedName.cpp

Loading...

src/ecma/kjs_html.cpp

Loading...

src/editing/editor.cpp

Loading...

src/editing/htmlediting_impl.cpp

Loading...

src/editing/jsediting.cpp

Loading...

src/html/html_elementimpl.cpp

Loading...

src/html/htmlparser.cpp

Loading...

src/html/htmltokenizer.cpp

Loading...

src/imload/decoders/qimageioloader.cpp

Loading...

src/java/kjavaapplet.cpp

Loading...

src/java/kjavaappletcontext.cpp

Loading...

src/java/kjavaappletserver.cpp

Loading...

src/java/kjavaappletwidget.cpp

Loading...

src/java/kjavadownloader.cpp

Loading...

src/java/kjavaprocess.cpp

Loading...

src/khtml_caret.cpp

Loading...

src/khtml_part.cpp

Loading...

src/khtmlview.cpp

Loading...

src/rendering/RenderPath.cpp

Loading...

src/rendering/RenderSVGInlineText.cpp

Loading...

src/rendering/RenderSVGRoot.cpp

Loading...

src/rendering/RenderSVGText.cpp

Loading...

src/rendering/SVGInlineTextBox.cpp

Loading...

src/rendering/SVGRootInlineBox.cpp

Loading...

src/rendering/bidi.cpp

Loading...

src/rendering/render_block.cpp

Loading...

src/rendering/render_container.cpp

Loading...

src/rendering/render_flow.cpp

Loading...

src/rendering/render_form.cpp

Loading...

src/rendering/render_object.cpp

Loading...

src/rendering/render_position.cpp

Loading...

src/rendering/render_replaced.cpp

Loading...

src/rendering/render_table.cpp

Loading...

src/rendering/render_text.cpp

Loading...

src/svg/SVGDocumentExtensions.cpp

Loading...

src/svg/SVGElement.cpp

Loading...

src/svg/SVGGradientElement.cpp

Loading...

src/svg/SVGLinearGradientElement.cpp

Loading...

src/svg/SVGPolyElement.cpp

Loading...

src/svg/SVGRectElement.cpp

Loading...

src/svg/SVGSVGElement.cpp

Loading...

src/svg/SVGStopElement.cpp

Loading...

src/svg/SVGStyleElement.cpp

Loading...

src/svg/SVGTextElement.cpp

Loading...

src/svg/SVGTextPositioningElement.cpp

Loading...

src/svg/SVGURIReference.cpp

Loading...

src/svg/graphics/SVGPaintServerLinearGradient.cpp

Loading...

src/svg/graphics/qt/SVGPaintServerGradientQt.cpp

Loading...

src/svg/graphics/qt/SVGPaintServerRadialGradientQt.cpp

Loading...

src/ui/findbar/khtmlfind.cpp

Loading...

src/xml/dom_docimpl.cpp

Loading...

src/xml/dom_elementimpl.cpp

Loading...

src/xml/dom_position.cpp

Loading...

src/xml/dom_selection.cpp

Loading...

tests/test_regression_gui_window.cpp

Loading...