Don't make requests if we didn't manage to connect
ClosedPublic
Actions

Authored by apol on Sep 12 2017, 5:31 PM.

Details

Reviewers

Commits

R134:8280fa0c802b: Don't make requests if we didn't manage to connect

Summary

Use QtConcurrent::run instead of QThread. QThread will issue the thread
immediately and that will overload the operating system giving "too many files
opened errors". QtConcurrent will do the appropriate balancing for us.

Test Plan

Doesn't crash on me anymore

Diff Detail

Repository

R134 Discover Software Store

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

apol created this revision.Sep 12 2017, 5:31 PM

Restricted Application added a project: Plasma. · View Herald TranscriptSep 12 2017, 5:31 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Looks good to me and also seems to work pretty well.

This revision is now accepted and ready to land.Sep 13 2017, 6:44 AM

Closed by commit R134:8280fa0c802b: Don't make requests if we didn't manage to connect (authored by apol). · Explain WhySep 13 2017, 10:16 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		libdiscover/backends/FlatpakBackend/CMakeLists.txt (7 lines)
M		libdiscover/backends/FlatpakBackend/FlatpakBackend.h (2 lines)
M		libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp (108 lines)
M		libdiscover/backends/FlatpakBackend/FlatpakFetchDataJob.h (38 lines)
M		libdiscover/backends/FlatpakBackend/FlatpakFetchDataJob.cpp (128 lines)
D	M	libdiscover/backends/FlatpakBackend/FlatpakFetchUpdatesJob.h (52 lines)
D	M	libdiscover/backends/FlatpakBackend/FlatpakFetchUpdatesJob.cpp (55 lines)
M		libdiscover/backends/FlatpakBackend/FlatpakNotifier.cpp (24 lines)
M		libdiscover/backends/SnapBackend/SnapBackend.cpp (1 line)