Don't make requests if we didn't manage to connect
ClosedPublic

Authored by apol on Tue, Sep 12, 5:31 PM.

Details

Summary

Use QtConcurrent::run instead of QThread. QThread will issue the thread
immediately and that will overload the operating system giving "too many files
opened errors". QtConcurrent will do the appropriate balancing for us.

Test Plan

Doesn't crash on me anymore

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Tue, Sep 12, 5:31 PM
Restricted Application added a project: Plasma. · View Herald TranscriptTue, Sep 12, 5:31 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jgrulich accepted this revision.Wed, Sep 13, 6:44 AM

Looks good to me and also seems to work pretty well.

This revision is now accepted and ready to land.Wed, Sep 13, 6:44 AM
This revision was automatically updated to reflect the committed changes.