create the whole plugin structure in the build directory
ClosedPublic

Authored by mart on Wed, Sep 13, 7:52 AM.

Details

Summary

when building copy all qml files in build/org/kde/kirigami.2
as well generating the binary plugin there.
this is neccessary to be able to load and test the whole QML
import without installing it system wide

Test Plan

after make, the hierarchy under build is complete with the same files
that end up being installed

Diff Detail

Repository
R169 Kirigami
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Wed, Sep 13, 7:52 AM
Restricted Application added a project: Kirigami. · View Herald TranscriptWed, Sep 13, 7:52 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart updated this revision to Diff 19473.Wed, Sep 13, 8:51 AM
  • alternative approach
apol added a subscriber: apol.Wed, Sep 13, 10:10 AM

Also you maybe can move this code into the tests subdirectory, so it only needs to be run in BUILD_TESTING.

I am not sure if this is going to work but I agree that if it has any opportunity then it's probably along these lines...

src/CMakeLists.txt
33

Why do you need to GLOB? can't you just copy the whole directory over with all of the styles/controls inside?

mart added a comment.Mon, Sep 18, 9:14 AM
In D7794#145371, @apol wrote:

Also you maybe can move this code into the tests subdirectory, so it only needs to be run in BUILD_TESTING.

I am not sure if this is going to work but I agree that if it has any opportunity then it's probably along these lines...

i tought the direction now was to make things usable also when not installed, which would make it needed not only for tests

mart added inline comments.Mon, Sep 18, 9:36 AM
src/CMakeLists.txt
33

if instead of the GLOB i put in the copy command directly the directory name, it seems to not actually copy anything

mart updated this revision to Diff 19636.Mon, Sep 18, 11:31 AM
  • get rid of GLOB
mart updated this revision to Diff 19637.Mon, Sep 18, 11:37 AM
  • remove dead code
apol accepted this revision.Mon, Sep 18, 11:38 AM

Looks good to me.

This revision is now accepted and ready to land.Mon, Sep 18, 11:38 AM
mart updated this revision to Diff 19638.Mon, Sep 18, 11:39 AM
  • lowercase
apol accepted this revision.Mon, Sep 18, 11:40 AM
This revision was automatically updated to reflect the committed changes.