Feed Advanced Search

May 4 2018

apol committed R134:4487b4f74296: Fix build (authored by apol).
Fix build
May 4 2018, 5:34 PM
apol committed R134:33d0fa4de7df: Remove unneeded, redundant interface (authored by apol).
Remove unneeded, redundant interface
May 4 2018, 5:33 PM
apol committed R134:bf9fe2adeaa0: Fix warning (authored by apol).
Fix warning
May 4 2018, 5:33 PM
apol committed R134:39f104324858: Fix warnings (authored by apol).
Fix warnings
May 4 2018, 5:33 PM
apol committed R134:9ecdb5343e0a: Flatpak: Use a more descriptive object name (authored by apol).
Flatpak: Use a more descriptive object name
May 4 2018, 4:01 PM
apol committed R134:4d4d8c4165ff: Flatpak: also sort findResourceByPackageName results (authored by apol).
Flatpak: also sort findResourceByPackageName results
May 4 2018, 4:01 PM
apol committed R134:2e57488edcd4: Don't show the missing backends header if there's no missing backends (authored by apol).
Don't show the missing backends header if there's no missing backends
May 4 2018, 4:01 PM
apol committed R134:a122b93badc2: Use a nicer delegate for the missing backends items in the sources (authored by apol).
Use a nicer delegate for the missing backends items in the sources
May 4 2018, 3:43 PM
apol committed R134:ea0f631cd052: Include a title for the missing backends control in the sources page (authored by apol).
Include a title for the missing backends control in the sources page
May 4 2018, 3:41 PM
apol committed R134:0f823c0bed40: Make it possible to choose which is the favorite flatpak source (authored by apol).
Make it possible to choose which is the favorite flatpak source
May 4 2018, 3:22 PM
apol committed R134:b34e097811a3: Destroy backends when closing (authored by apol).
Destroy backends when closing
May 4 2018, 3:22 PM

May 3 2018

apol committed R134:a331ff888459: Merge branch 'Plasma/5.12' (authored by apol).
Merge branch 'Plasma/5.12'
May 3 2018, 6:57 PM
apol committed R134:67410504cab7: Dummy: fix remove sources (authored by apol).
Dummy: fix remove sources
May 3 2018, 6:57 PM
apol committed R257:f1a0c1793adf: Backport Qt scaling patch (authored by apol).
Backport Qt scaling patch
May 3 2018, 10:52 AM

May 2 2018

apol added inline comments to D12670: Share RemoteKeyboard implementation.
May 2 2018, 11:40 PM · KDE Connect
apol accepted D12669: Start cleaning up RemoteKeyboard QML code.
May 2 2018, 11:39 PM · KDE Connect
apol committed R134:656ee2a80bdd: Have flatpak packagename include the version (authored by apol).
Have flatpak packagename include the version
May 2 2018, 3:13 PM
apol committed R134:2fc8f0c31e76: De-duplicate redundant updates (authored by apol).
De-duplicate redundant updates
May 2 2018, 2:58 PM
apol added a comment to D12610: Avoid crashing on failed flatpak_installation_list_installed_refs_for_update.

Ugh sorry, saw the bug report and fixed it before going through the e-mails...

May 2 2018, 1:30 PM · Plasma
apol added a comment to T8625: Stream audio across devices.

Could be related to T4661 for the microphone feature.

May 2 2018, 1:29 PM · KDE Connect
apol added a comment to D12616: Akregator feed detector plugin: Port away from KDELibs4Support.

LGTM overall +1

May 2 2018, 1:28 PM
apol added a comment to T8611: Support dbus-broker.

Looks reasonable. Could you turn this into a patch so it can be properly reviewed?

May 2 2018, 1:04 PM · Junior Jobs, KDE Connect
apol committed R108:c0226fe74481: Clear both cursor caches (authored by apol).
Clear both cursor caches
May 2 2018, 12:56 PM
apol closed D12542: Clear both cursor caches.
May 2 2018, 12:56 PM · KWin
apol committed R134:36643a92cd30: Fix updates count when listing resources that point to the same package (authored by apol).
Fix updates count when listing resources that point to the same package
May 2 2018, 12:51 PM
apol committed R134:34a91690be72: Notifier: Don't crash if we failed to check the remote (authored by apol).
Notifier: Don't crash if we failed to check the remote
May 2 2018, 12:16 PM

Apr 29 2018

apol added a comment to T7205: create call for locations for Akademy 2019.

Small addition: for next year we are open to include proposals outside Europe. Would it be possible to include that in the text?

Apr 29 2018, 2:02 PM · KDE e.V., Akademy

Apr 27 2018

apol accepted D12546: Support multiple players in MprisRemote.
Apr 27 2018, 10:20 PM · KDE Connect
apol requested changes to D12552: Use title, album and artist in UI.
Apr 27 2018, 10:19 PM · KDE Connect
apol added a comment to T8601: Add Clarification for Ellipsis Use.

+1
Create a patch and let's discuss over the wording?

Apr 27 2018, 9:54 PM · KDE Human Interface Guidelines
apol committed R899:c1e8fc31136e: Fix build (authored by apol).
Fix build
Apr 27 2018, 2:25 PM
apol added inline comments to D12552: Use title, album and artist in UI.
Apr 27 2018, 10:06 AM · KDE Connect
apol added a comment to D12546: Support multiple players in MprisRemote.

Other than that looks good to me. Thanks!

Apr 27 2018, 10:06 AM · KDE Connect
apol accepted D12550: Request status when connecting.
Apr 27 2018, 9:57 AM · KDE Connect

Apr 26 2018

apol accepted D12543: Support title, artist and album in MprisRemote.
Apr 26 2018, 5:52 PM · KDE Connect
apol added a comment to R32:ab2fcd3b2789: shell: Display generic project managers again.

It doesn't seem to be working here, I just merged 5.2 to master and it's still broken for me.

Apr 26 2018, 5:49 PM
apol committed R32:967f42fd37bf: Merge remote-tracking branch 'origin/5.2' (authored by apol).
Merge remote-tracking branch 'origin/5.2'
Apr 26 2018, 5:45 PM
apol requested review of D12542: Clear both cursor caches.
Apr 26 2018, 2:45 PM · KWin
apol committed R108:ebfc71393639: Improve cursor size setup (authored by apol).
Improve cursor size setup
Apr 26 2018, 2:43 PM
apol committed R108:6adc785168b3: Merge branch 'Plasma/5.12' (authored by apol).
Merge branch 'Plasma/5.12'
Apr 26 2018, 2:43 PM
apol committed R169:9d5beea70b59: Don't warn when using Page {} outside of a pageStack (authored by apol).
Don't warn when using Page {} outside of a pageStack
Apr 26 2018, 9:51 AM
apol closed D12514: Don't warn when using Page {} outside of a pageStack.
Apr 26 2018, 9:51 AM · Kirigami
apol added inline comments to D12517: Wayland: when blocking remember latest config change instead of crashing.
Apr 26 2018, 9:50 AM · Plasma
apol added a comment to D12506: Fix another DBus connection in Kirigami app.

What does not make sense? That it doesn't work, the fix or that it still does not work?

Apr 26 2018, 9:47 AM · KDE Connect

Apr 25 2018

apol committed R223:58c09cd47c69: QtQuick: Use proper drawer API (authored by apol).
QtQuick: Use proper drawer API
Apr 25 2018, 10:35 PM
apol committed R223:bf6f5f74dc07: QtQuick: Don't reset zoom when scrollbars appear (authored by apol).
QtQuick: Don't reset zoom when scrollbars appear
Apr 25 2018, 4:08 PM
apol committed R223:df35e22314c9: QtQuick: make certain properties readonly (authored by apol).
QtQuick: make certain properties readonly
Apr 25 2018, 4:08 PM
apol committed R223:374d953e39d1: QtQuick: remove unnecessary use of QQuickPixmapItem (authored by apol).
QtQuick: remove unnecessary use of QQuickPixmapItem
Apr 25 2018, 4:08 PM
apol committed R223:77dfe3ddc6e2: QtQuick: Port from Text to proper Kirigami.Units (authored by apol).
QtQuick: Port from Text to proper Kirigami.Units
Apr 25 2018, 4:08 PM
apol committed R223:84854afb6426: QtQuick: Only emit when there's something to change (authored by apol).
QtQuick: Only emit when there's something to change
Apr 25 2018, 2:02 PM
apol committed R223:a7b165c0f2fb: QtQuick: Adopt more assertive behavior upon document change (authored by apol).
QtQuick: Adopt more assertive behavior upon document change
Apr 25 2018, 2:02 PM
apol committed R223:c51419dd9f44: QtQuick: use the right bounds when painting (authored by apol).
QtQuick: use the right bounds when painting
Apr 25 2018, 2:02 PM
apol committed R223:19222f27ca9b: QtQuick: fix visual corruption (authored by apol).
QtQuick: fix visual corruption
Apr 25 2018, 2:02 PM
apol added a comment to T6133: Tags support in Ocsv1Controller.

Related patches:
https://phabricator.kde.org/D6512
https://phabricator.kde.org/D6513

Apr 25 2018, 1:17 PM · KDE Store
apol requested review of D12514: Don't warn when using Page {} outside of a pageStack.
Apr 25 2018, 10:59 AM · Kirigami
apol added a comment to D12506: Fix another DBus connection in Kirigami app.

That doesn't make a lot of sense...

Apr 25 2018, 9:13 AM · KDE Connect
apol accepted D12505: Fix DBus connection in Kirigami app.
Apr 25 2018, 9:11 AM · KDE Connect

Apr 24 2018

apol committed R857:831803d2f38f: Android: Properly pass arguments to the application git clone (authored by apol).
Android: Properly pass arguments to the application git clone
Apr 24 2018, 8:39 PM
apol committed R659:88e8d88ce8f4: Include AppStream information (authored by apol).
Include AppStream information
Apr 24 2018, 7:19 PM
apol committed R857:33fc9240565a: Android: Include missing script (authored by apol).
Android: Include missing script
Apr 24 2018, 4:40 PM
apol committed R7:9a40c27e28c8: Include AndroidManifest.xml (authored by apol).
Include AndroidManifest.xml
Apr 24 2018, 4:35 PM
apol committed R7:93051ec03a75: Make it possible to use qrc when building locally (authored by apol).
Make it possible to use qrc when building locally
Apr 24 2018, 4:35 PM
apol committed R108:6e84645e355a: Reparse the input configuration when we are notified that it changed (authored by apol).
Reparse the input configuration when we are notified that it changed
Apr 24 2018, 2:41 PM
apol committed R108:4403e86acc8c: Don't try to filter null key combinations (authored by apol).
Don't try to filter null key combinations
Apr 24 2018, 2:24 PM
apol closed D12416: Don't try to filter null key combinations.
Apr 24 2018, 2:24 PM · KWin
apol committed R993:225200e8e9fd: Add quotes around env var (authored by apol).
Add quotes around env var
Apr 24 2018, 9:14 AM
apol committed R993:b535a92b0e4a: Android: Try setting environment variables in a different way (authored by apol).
Android: Try setting environment variables in a different way
Apr 24 2018, 9:06 AM
apol committed R993:1859cfd774b2: Revert "Android: Fix konvi2x build" (authored by apol).
Revert "Android: Fix konvi2x build"
Apr 24 2018, 9:06 AM
apol added a reverting change for R993:c2308f6b6252: Android: Fix konvi2x build: R993:1859cfd774b2: Revert "Android: Fix konvi2x build".
Apr 24 2018, 9:06 AM

Apr 23 2018

apol updated the diff for D5961: Adoption of KUserFeedback for Discover.

adapt

Apr 23 2018, 5:22 PM · Plasma
apol committed R993:c2308f6b6252: Android: Fix konvi2x build (authored by apol).
Android: Fix konvi2x build
Apr 23 2018, 3:19 PM
apol updated the diff for D5961: Adoption of KUserFeedback for Discover.

Rebase to master

Apr 23 2018, 2:20 PM · Plasma
apol updated the diff for D12416: Don't try to filter null key combinations.

Add test

Apr 23 2018, 2:08 PM · KWin
apol added a comment to T8281: Make runcommand great again.

What do you think about introducing hooks that commands could be connected to? E.g. run foo on device connected/disconnected. Or connect commands to DBus signals.

Apr 23 2018, 12:44 PM · KDE Connect
apol added a comment to T8281: Make runcommand great again.
  • Make it more discoverable
  • Integrate with KNS/Discover

decided against this one.

Apr 23 2018, 12:14 PM · KDE Connect
apol committed R134:ff6f7b86a94c: Improve display of Progress element (authored by apol).
Improve display of Progress element
Apr 23 2018, 11:09 AM

Apr 22 2018

apol committed R223:2648ad7b7389: Correctly list the supported file suffixes (authored by apol).
Correctly list the supported file suffixes
Apr 22 2018, 9:01 PM
apol committed R223:077d0219fe79: Did not meant to commit that (authored by apol).
Did not meant to commit that
Apr 22 2018, 9:01 PM
apol committed R223:1fb77446a737: Make it possible to disable the build of okularkirigami (authored by apol).
Make it possible to disable the build of okularkirigami
Apr 22 2018, 8:23 PM
apol closed D12352: Make it possible to disable the build of okularkirigami.
Apr 22 2018, 8:23 PM · Okular
apol updated the summary of D12416: Don't try to filter null key combinations.
Apr 22 2018, 5:36 PM · KWin
apol committed R284:fbb5609001ab: Fix KCompletionBox on wayland (authored by apol).
Fix KCompletionBox on wayland
Apr 22 2018, 5:35 PM
apol closed D12448: Fix KCompletionBox on wayland.
Apr 22 2018, 5:35 PM · Frameworks
apol added a comment to D12448: Fix KCompletionBox on wayland.

Why not

static const auto flags = qGuiApp->platformName() == QLatin1String("wayland") ? Qt::WindowFlags(Qt::ToolTip | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint) :
                                                                                Qt::WindowFlags(Qt::Window | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint);
q->setWindowFlags(flags);

It's not need to check in every completion construction.

Apr 22 2018, 5:35 PM · Frameworks
apol committed R993:d64e449152f0: Android. Have konversation wip/qtquick branch built into an apk (authored by apol).
Android. Have konversation wip/qtquick branch built into an apk
Apr 22 2018, 5:31 PM
apol committed R857:f54554c737ac: Android: build-standalone error handling (authored by apol).
Android: build-standalone error handling
Apr 22 2018, 5:26 PM
apol committed R857:775e99806dbc: Android: allow to request a special branch when building an app (authored by apol).
Android: allow to request a special branch when building an app
Apr 22 2018, 5:26 PM
apol committed R7:9dc539dd3d3b: Have konvi2x compile against Android (authored by apol).
Have konvi2x compile against Android
Apr 22 2018, 5:18 PM
apol closed D12453: Have konvi2x compile against Android.
Apr 22 2018, 5:18 PM
apol requested review of D12453: Have konvi2x compile against Android.
Apr 22 2018, 5:05 PM
apol committed R7:6bdba46a4389: Android: fix build (authored by apol).
Android: fix build
Apr 22 2018, 4:59 PM
apol requested review of D12448: Fix KCompletionBox on wayland.
Apr 22 2018, 2:20 PM · Frameworks
apol committed R993:3ca82d8a3cb6: Android: Force okular to link against poppler (authored by apol).
Android: Force okular to link against poppler
Apr 22 2018, 2:03 PM
apol accepted D12331: Always use the clang builtin headers for the libclang version we use.

Fair enough.
It's working for me anyway, I'd say land this, we land my other patch, then we see how we proceed. Makes sense?

Apr 22 2018, 9:53 AM

Apr 21 2018

apol added a reviewer for D12416: Don't try to filter null key combinations: KWin.
Apr 21 2018, 4:37 PM · KWin
apol updated the summary of D12416: Don't try to filter null key combinations.
Apr 21 2018, 4:37 PM · KWin
apol updated the diff for D12416: Don't try to filter null key combinations.

Don't try to filter null key combinations

Apr 21 2018, 4:36 PM · KWin
apol requested review of D12416: Don't try to filter null key combinations.
Apr 21 2018, 4:36 PM · KWin
apol committed R857:46c3b1427296: Android: Backport verbosity patch (authored by apol).
Android: Backport verbosity patch
Apr 21 2018, 2:59 PM
apol committed R857:8e7895320781: Android: Make /opt writable (authored by apol).
Android: Make /opt writable
Apr 21 2018, 2:59 PM