- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
May 4 2018
May 3 2018
May 2 2018
Ugh sorry, saw the bug report and fixed it before going through the e-mails...
Could be related to T4661 for the microphone feature.
LGTM overall +1
Looks reasonable. Could you turn this into a patch so it can be properly reviewed?
Apr 29 2018
Small addition: for next year we are open to include proposals outside Europe. Would it be possible to include that in the text?
Apr 27 2018
+1
Create a patch and let's discuss over the wording?
Other than that looks good to me. Thanks!
Apr 26 2018
It doesn't seem to be working here, I just merged 5.2 to master and it's still broken for me.
In D12506#253541, @nicolasfella wrote:What does not make sense? That it doesn't work, the fix or that it still does not work?
Apr 25 2018
Related patches:
https://phabricator.kde.org/D6512
https://phabricator.kde.org/D6513
That doesn't make a lot of sense...
Apr 24 2018
Apr 23 2018
adapt
Rebase to master
Add test
In T8281#139329, @nicolasfella wrote:What do you think about introducing hooks that commands could be connected to? E.g. run foo on device connected/disconnected. Or connect commands to DBus signals.
- Make it more discoverable
- Integrate with KNS/Discover
decided against this one.
Apr 22 2018
In D12448#251908, @anthonyfieroni wrote:Why not
static const auto flags = qGuiApp->platformName() == QLatin1String("wayland") ? Qt::WindowFlags(Qt::ToolTip | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint) : Qt::WindowFlags(Qt::Window | Qt::FramelessWindowHint | Qt::BypassWindowManagerHint); q->setWindowFlags(flags);It's not need to check in every completion construction.
Fair enough.
It's working for me anyway, I'd say land this, we land my other patch, then we see how we proceed. Makes sense?
Apr 21 2018
Don't try to filter null key combinations