Differential D12669

Start cleaning up RemoteKeyboard QML code
ClosedPublic
Actions

Authored by nicolasfella on May 2 2018, 7:14 PM.

Details

Reviewers
apol
Group Reviewers
KDE Connect
Commits
R224:4d8863bacce2: Start cleaning up RemoteKeyboard QML code
Summary

The code for visually disabling the input field is not needed any more since the field is completely hidden when not needed. Also drop the custom available property from the text field.

More cleanups will follow. My long-term goal is to reuse the code in the app to enable remote keyboard input on non-Plasma DEs

Test Plan

(De)activate the remote keyboard on Android.

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.May 2 2018, 7:14 PM
Restricted Application added a project: KDE Connect. · View Herald TranscriptMay 2 2018, 7:14 PM
nicolasfella requested review of this revision.May 2 2018, 7:14 PM
nicolasfella edited the summary of this revision. (Show Details)May 2 2018, 7:17 PM
apol accepted this revision.May 2 2018, 11:39 PM
apol added a subscriber: apol.
apol added inline comments.
plasmoid/package/contents/ui/DeviceDelegate.qml
169–170

Probably should drop the style altogether.

This revision is now accepted and ready to land.May 2 2018, 11:39 PM
Closed by commit R224:4d8863bacce2: Start cleaning up RemoteKeyboard QML code (authored by nicolasfella). · Explain WhyMay 8 2018, 11:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33855

View Options

plasmoid/package/contents/ui/DeviceDelegate.qml

Loading...