Wayland: when blocking remember latest config change instead of crashing
ClosedPublic
Actions

Authored by romangg on Apr 25 2018, 1:33 PM.

Details

Reviewers

davidedmundson

Group Reviewers

Plasma

Commits

Summary

Configuration change requests by clients while the Wayland server is
processing a change lead to a failing assert in blockSignals().

Instead in such a situation remember the latest configuration change request
and apply it after the current change has been processed.

Test Plan

Auto test exposing the problem. Also manually with my output color correction
code.

Repository

R110 KScreen Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

romangg requested review of this revision.Apr 25 2018, 1:33 PM

apol added inline comments.

tests/kwayland/waylandtestserver.cpp
156	maybe it's a bit easier to understand if you add an else instead of a return?
161	Won't the using code expect `configChanged` to be emitted after `configReceived`?

This revision is now accepted and ready to land.Jul 3 2018, 5:45 PM

tests/kwayland/waylandtestserver.cpp
156	The coding style recommendation in general is to return as early as possible instead of using else.
161	In `testApplyOnPending` it waits on `configReceived` and then on `configChanged`.

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/testkwaylandconfig.cpp (55 lines)
M			backends/kwayland/waylandconfig.h (2 lines)
M			backends/kwayland/waylandconfig.cpp (18 lines)
M			tests/kwayland/waylandtestserver.h (5 lines)
M			tests/kwayland/waylandtestserver.cpp (23 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	33067	bb29e0d		Apr 25 2018, 1:33 PM	★	★
Diff 2	37132	feb1099	R110:af609c37ddfd71dbdd4f8cec4e45639a1d3ed18f	Jul 4 2018, 6:52 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
745899d7e9c4	7e85b27650e7	deec5da820ae	Roman Gilg	Add autotest	Apr 25 2018, 1:20 PM
deec5da820ae	c0c2feaa7fd5	bb29e0d4ea32	Roman Gilg	Remember pending config on blocking signal	Apr 25 2018, 10:23 AM