Differential D12506

Fix another DBus connection in Kirigami app
ClosedPublic
Actions

Authored by nicolasfella on Apr 24 2018, 11:26 PM.

Details

Reviewers
None
Group Reviewers
KDE Connect
Commits
R224:aa5aeedf0a6b: Fix another DBus connection in Kirigami app
Summary

When a DevicePage is created from FindDevicePage the device is not passed correctly, resulting in some device is null warnings. The pair button still does not work, but it seems to be another issue.

Test Plan

I could set the button text to the device id, so the device is passed correctly. The button still does not work as intended though.

Diff Detail

Repository
R224 KDE Connect
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Apr 24 2018, 11:26 PM
nicolasfella created this revision.
apol added a subscriber: apol.Apr 25 2018, 9:13 AM

That doesn't make a lot of sense...

Feel free to land though, if it helps you keep working on it.

nicolasfella added a comment.Apr 25 2018, 11:14 AM

What does not make sense? That it doesn't work, the fix or that it still does not work?

apol added a comment.Apr 26 2018, 9:47 AM
In D12506#253541, @nicolasfella wrote:

What does not make sense? That it doesn't work, the fix or that it still does not work?

Passing a url on that first argument should work. Could be a bug in Kirigami.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 27 2018, 10:25 PM
Closed by commit R224:aa5aeedf0a6b: Fix another DBus connection in Kirigami app (authored by nicolasfella). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapp/qml/FindDevicesPage.qml (7 lines)

Diff 33225

View Options

app/qml/FindDevicesPage.qml

Loading...