Feed Advanced Search

Apr 26 2020

dantti accepted D29112: [applet] Port to Kirigami.PlaceholderMessage.

thanks

Apr 26 2020, 2:05 PM

Apr 1 2020

dantti accepted D28479: use httpAssembleURI not httpAssembleURIf.
Apr 1 2020, 2:23 PM
dantti added a comment to D28479: use httpAssembleURI not httpAssembleURIf.

LGTM, is the new function available since old CUPS versions? Just to make sure it won't break usage with old versions.

Apr 1 2020, 1:59 PM

Mar 13 2020

dantti added a comment to D28036: [Applet] Port to ExpandableListItem.

Well I still think that this applet rewrite is very useless, very little care about their printers, it's the print jobs that matter, still the patch looks fine, although I see the buttons showing up before the selection is fully expanded.

Mar 13 2020, 8:29 PM

Mar 12 2020

dantti accepted D23403: Fix authentication.

Looks Great To Me!

Mar 12 2020, 1:32 PM

Dec 2 2019

dantti accepted D25623: Fix crash when cups returns jobs with duplicate id.

LGTM

Dec 2 2019, 1:51 PM

Dec 1 2019

dantti added a comment to D25623: Fix crash when cups returns jobs with duplicate id.

Well I think your approach is probably the best to this, I'd only change the sanitize loop to use iterators and erase as afair they are a little faster.

Dec 1 2019, 7:25 PM
dantti added a comment to D25623: Fix crash when cups returns jobs with duplicate id.

But the remove old jobs code would also need fixing to account with the dups

Dec 1 2019, 7:20 PM
dantti added a comment to D25623: Fix crash when cups returns jobs with duplicate id.

Oh, now I see the problem with this, I tried many times reproduce but never managed to see the issue with the dups IDs.

Dec 1 2019, 7:19 PM

Nov 5 2019

dantti accepted D25155: Add "authenticate" action.

Lgtm thanks

Nov 5 2019, 11:08 AM

Aug 27 2019

dantti accepted D23407: Don't fetch server settings for preferences button.

Ok, while not an ideal change, these options aren't the kind of options that should be changing that often so I'm ok. Thanks

Aug 27 2019, 5:20 PM

Aug 26 2019

dantti added a comment to D23407: Don't fetch server settings for preferences button.

Yes, the idea is to be up to date, the issue it seems to be that some CUPS installations keep asking the server password on each query instead of having it cached.

Aug 26 2019, 3:06 PM

Apr 1 2019

dantti accepted D20156: Use friendlier Name for notification file.

thanks

Apr 1 2019, 10:41 AM

Mar 21 2019

dantti accepted D19951: Prevent crashing Apper on PackageModel::clearSelectedNotPresent().

Thanks +1

Mar 21 2019, 7:51 PM

Mar 18 2019

dantti accepted D19793: Enable HiDPI pixmaps.

thanks

Mar 18 2019, 1:43 AM

Feb 20 2019

dantti added a comment to D19035: Help build on Windows with usage of CMake Targets.

I ended up compiling it using vcpkg toolchain directly on Windows, which showed this isn't required.

Feb 20 2019, 11:22 AM · Frameworks, Kate

Feb 15 2019

dantti added a comment to D19035: Help build on Windows with usage of CMake Targets.

I'm not entirely sure this is really needed on Windows, but when cross-compiling this allowed to search for the katehighlightingindexer.exe which wouldn't run because I was on Linux...

Feb 15 2019, 12:52 PM · Frameworks, Kate
dantti requested review of D19035: Help build on Windows with usage of CMake Targets.
Feb 15 2019, 12:50 PM · Frameworks, Kate

Feb 1 2019

dantti accepted D18648: Show more information on CUPS auth dialog.

LGTM Thanks!

Feb 1 2019, 5:12 PM

Jan 10 2019

dantti committed R658:b5b6edbe2488: Small fixes (authored by dantti).
Small fixes
Jan 10 2019, 1:14 PM

Sep 23 2018

dantti committed R658:20d54acea93d: Fix kded metadata (authored by dantti).
Fix kded metadata
Sep 23 2018, 6:40 PM
dantti committed R549:d55b1677cbf9: Fix apperd metadata (authored by dantti).
Fix apperd metadata
Sep 23 2018, 6:37 PM

Sep 17 2018

dantti committed R241:1f24f49baba4: Fix WebDAV destination header on COPY and MOVE operations (authored by dantti).
Fix WebDAV destination header on COPY and MOVE operations
Sep 17 2018, 5:47 PM
dantti closed D14006: Fix WebDAV destination header on COPY and MOVE operations.
Sep 17 2018, 5:47 PM · Frameworks

Sep 10 2018

dantti accepted D15323: Hide printer applet if no printer is configured.

LGTM

Sep 10 2018, 2:20 PM
dantti accepted D15324: Show printer and job name if only one job is being printed.

LGTM

Sep 10 2018, 2:20 PM

Sep 9 2018

dantti added a comment to D14006: Fix WebDAV destination header on COPY and MOVE operations.

Well the issue will probably depend on the server,
for example Apache2 with Nextcloud it returns forbidden for both operations,
in Cloudlyst which does:
QUrl::fromEncoded(QStringLiteral("file:///speçiál").toLatin1()).toLocalFile();
you get a file with a different file name as URL.
Since 'ç' is extended ASCII this "fails" only because URL are sopposed
to use only printable ASCII chars

Sep 9 2018, 3:05 PM · Frameworks
dantti added a comment to D14006: Fix WebDAV destination header on COPY and MOVE operations.

Test plan:

Sep 9 2018, 5:40 AM · Frameworks

Sep 8 2018

dantti added a comment to D14006: Fix WebDAV destination header on COPY and MOVE operations.

Ping? This is a pretty obvious fix, desturl is QString which later becomes latin1 loosing characters...

Sep 8 2018, 2:43 PM · Frameworks

Jul 10 2018

dantti added a comment to D14006: Fix WebDAV destination header on COPY and MOVE operations.
Jul 10 2018, 1:25 AM · Frameworks

Jul 9 2018

dantti added a reviewer for D14006: Fix WebDAV destination header on COPY and MOVE operations: dfaure.
Jul 9 2018, 3:08 PM · Frameworks
dantti requested review of D14006: Fix WebDAV destination header on COPY and MOVE operations.
Jul 9 2018, 3:07 PM · Frameworks

Jun 6 2018

dantti committed R363:fefa0fd010ff: Simplify accessing a job object (authored by dantti).
Simplify accessing a job object
Jun 6 2018, 8:29 PM
dantti committed R363:5d3c5f7bc417: Possibly fix a crash by updating a row before moving it (authored by dantti).
Possibly fix a crash by updating a row before moving it
Jun 6 2018, 8:24 PM

Mar 21 2018

dantti accepted D11546: handle sigquit properly.

LGTM I only confused about why do you need QRegExp :P

Mar 21 2018, 2:28 PM
dantti added a comment to D11546: handle sigquit properly.

AFAIK this is the wrong way of handling signals, don't recall exactly what the problem is, but Qt documentation says to create a pipe, attach a QSocketNotifier to it, and write data to it when the signal is caught, then the QSN signal will call qApp->quit();

Mar 21 2018, 12:54 PM

Mar 17 2018

dantti accepted D11429: Fix build with Qt 5.11 (missing QRegExpValidator).
Mar 17 2018, 9:11 PM

Mar 8 2018

dantti accepted D10967: Remove custom compact representation.

LGTM

Mar 8 2018, 2:12 PM

Feb 21 2018

dantti committed R549:c34888dd5461: Fix compilation when EDIT_ORIGNS_DESKTOP_NAME is defined (authored by dantti).
Fix compilation when EDIT_ORIGNS_DESKTOP_NAME is defined
Feb 21 2018, 8:19 PM
dantti accepted D10707: Fix build without AppStream.

OK, thanks I'll probably make it mandatory for 1.1.0 as it's a simple dep and the less ifdefs the better

Feb 21 2018, 11:54 AM
dantti added a comment to D10706: Install apper binary as TARGET instead of PROGRAM.

master please

Feb 21 2018, 11:52 AM
dantti accepted D10706: Install apper binary as TARGET instead of PROGRAM.

oops my bad

Feb 21 2018, 10:15 AM
dantti added a comment to D10707: Fix build without AppStream.

Thanks, I've been thinking into making this dependency mandatory, could you please tell me why would you like to build without AppStream or are you just fixing the bug? thanks

Feb 21 2018, 10:14 AM

Feb 20 2018

dantti committed R549:4b812d3899bb: Fix showing Close button on session task finished (authored by dantti).
Fix showing Close button on session task finished
Feb 20 2018, 8:09 PM
dantti committed R549:7aa0542db56d: Fix screenshots (authored by dantti).
Fix screenshots
Feb 20 2018, 8:09 PM
dantti committed R549:c0597cdddf94: Fix screenshot/thumbnails viewer (authored by dantti).
Fix screenshot/thumbnails viewer
Feb 20 2018, 8:09 PM

Feb 19 2018

dantti committed R549:3e7d4d95845d: Some more autos and fixes (authored by dantti).
Some more autos and fixes
Feb 19 2018, 11:00 PM

Feb 7 2018

dantti committed R363:7a3208bc0b47: trivial: Post release version bump (authored by dantti).
trivial: Post release version bump
Feb 7 2018, 5:06 PM
dantti committed R363:a7f1ca98ce53: A few code improvements on configure-printer (authored by dantti).
A few code improvements on configure-printer
Feb 7 2018, 12:42 AM
dantti committed R363:8771d213301b: Fix switching pages and handlying Apply button on Configure Printer dialog (authored by dantti).
Fix switching pages and handlying Apply button on Configure Printer dialog
Feb 7 2018, 12:42 AM

Feb 6 2018

dantti accepted D10351: Fix Plasma applet printer job count.

LGTM

Feb 6 2018, 9:32 PM

Jan 28 2018

dantti committed R549:d0efb3d82088: Reduce build time by properly including mocs (authored by dantti).
Reduce build time by properly including mocs
Jan 28 2018, 9:05 PM
dantti committed R363:58283ab3e7d0: Don't lazy register the DBus stuff (authored by dantti).
Don't lazy register the DBus stuff
Jan 28 2018, 8:57 PM
dantti committed R363:e827a139a9e4: cleanup kded module (authored by dantti).
cleanup kded module
Jan 28 2018, 8:57 PM
dantti committed R363:74cc553cd822: Fix action to configure newly added printer broken by commit… (authored by dantti).
Fix action to configure newly added printer broken by commit…
Jan 28 2018, 8:57 PM
dantti committed R363:aad3a355f943: Make kded module async, fix crash, modernize it's code, fix leak (authored by dantti).
Make kded module async, fix crash, modernize it's code, fix leak
Jan 28 2018, 8:57 PM
dantti committed R363:9187e96a96c3: Fix GetReady notify sound (authored by dantti).
Fix GetReady notify sound
Jan 28 2018, 8:57 PM
dantti committed R363:ad0bd5f63a81: More use of initializer lists (authored by dantti).
More use of initializer lists
Jan 28 2018, 8:57 PM

Jan 27 2018

dantti committed R363:57f40f44c74e: Fix desktop file name for kde-add-printer so we get an icon on Wayland (authored by dantti).
Fix desktop file name for kde-add-printer so we get an icon on Wayland
Jan 27 2018, 3:37 AM
dantti committed R363:2f85d7390825: Change sort order when adding a new printer (authored by dantti).
Change sort order when adding a new printer
Jan 27 2018, 3:12 AM
dantti committed R363:ad261afa38de: Do not sort printers by default and remote (authored by dantti).
Do not sort printers by default and remote
Jan 27 2018, 1:10 AM

Jan 26 2018

dantti committed R549:cea869a0eae3: Fix loading KPixmapSequence (authored by dantti).
Fix loading KPixmapSequence
Jan 26 2018, 9:21 PM
dantti committed R363:6547b707093e: Allow canceling a job with Delete key shortcut (authored by dantti).
Allow canceling a job with Delete key shortcut
Jan 26 2018, 9:21 PM
dantti committed R363:ab9c8293c488: Use initilizer lists (authored by dantti).
Use initilizer lists
Jan 26 2018, 9:21 PM

Jan 25 2018

dantti committed R363:4bce8ae8b513: Fix not accepting cups-pdf urls (authored by dantti).
Fix not accepting cups-pdf urls
Jan 25 2018, 6:28 PM
dantti committed R363:fd2bfeb16693: Bump version to 0.4.0 (authored by dantti).
Bump version to 0.4.0
Jan 25 2018, 6:28 PM
dantti committed R363:7220560631aa: Fix plasma startup crash (authored by dantti).
Fix plasma startup crash
Jan 25 2018, 6:28 PM
dantti committed R363:3b43309693df: Fix build on Qt >= 5.8 (authored by dantti).
Fix build on Qt >= 5.8
Jan 25 2018, 6:28 PM
dantti committed R363:cd2074ee6140: Fix long messages in message widget by enabling word wrap (authored by dantti).
Fix long messages in message widget by enabling word wrap
Jan 25 2018, 6:28 PM
dantti committed R363:df841705fa01: Set the project version using the CMake project command (authored by dantti).
Set the project version using the CMake project command
Jan 25 2018, 6:28 PM
dantti committed R547:a46bd8bfb2f1: Modernize code with C++11 and Qt5 features (authored by dantti).
Modernize code with C++11 and Qt5 features
Jan 25 2018, 1:58 AM
dantti committed R363:5647d8111a3a: Reduce build time by including mocs files (authored by dantti).
Reduce build time by including mocs files
Jan 25 2018, 1:52 AM
dantti committed R363:2a568ebd67bf: Some code C++11 changes and cleanups (authored by dantti).
Some code C++11 changes and cleanups
Jan 25 2018, 1:52 AM
dantti committed R363:d019fa1ff4c9: Add QT_NO_CAST_FROM_ASCII definition (authored by dantti).
Add QT_NO_CAST_FROM_ASCII definition
Jan 25 2018, 1:52 AM
dantti committed R363:be54a009bdef: Add QT_NO_CAST_FROM_BYTEARRAY definition (authored by dantti).
Add QT_NO_CAST_FROM_BYTEARRAY definition
Jan 25 2018, 1:52 AM
dantti committed R363:571fe54d6da1: Disable deprecated before Qt 5.9 (authored by dantti).
Disable deprecated before Qt 5.9
Jan 25 2018, 1:52 AM
dantti committed R363:da0155478e63: Make use of new for range loops (authored by dantti).
Make use of new for range loops
Jan 25 2018, 1:52 AM
dantti committed R363:0c0bce67695c: Get rid of slow sender() calls (authored by dantti).
Get rid of slow sender() calls
Jan 25 2018, 1:52 AM
dantti committed R363:7d68c1d6531b: Make use of C++11 auto (authored by dantti).
Make use of C++11 auto
Jan 25 2018, 1:52 AM
dantti committed R363:13c6bc65a974: Add a missing connect change (authored by dantti).
Add a missing connect change
Jan 25 2018, 1:52 AM
dantti committed R363:adae1b4fcf4b: Finish porting to new Qt5 connect syntax (authored by dantti).
Finish porting to new Qt5 connect syntax
Jan 25 2018, 1:52 AM

Jan 19 2018

dantti committed R549:b3f58307a146: Fix getting icons from Appstream (authored by dantti).
Fix getting icons from Appstream
Jan 19 2018, 8:30 PM
dantti committed R549:6b606f9e6e5e: fix mem leak (authored by dantti).
fix mem leak
Jan 19 2018, 2:59 PM
dantti committed R549:0fe56facda3f: cleanups (authored by dantti).
cleanups
Jan 19 2018, 2:35 PM
dantti committed R549:3cb70376fd83: Fix some dialogs (authored by dantti).
Fix some dialogs
Jan 19 2018, 2:24 PM

Jan 18 2018

dantti committed R549:0b7b9e5d3c40: Be more strict with strings (authored by dantti).
Be more strict with strings
Jan 18 2018, 10:53 PM
dantti committed R549:ded5167bba65: Fix deprecated Qt usage (authored by dantti).
Fix deprecated Qt usage
Jan 18 2018, 9:09 PM
dantti committed R549:a873e6600567: PackageKit Session interface fixed (authored by dantti).
PackageKit Session interface fixed
Jan 18 2018, 9:02 PM
dantti committed R549:da97d8bea05e: Some fixes on file watching (authored by dantti).
Some fixes on file watching
Jan 18 2018, 2:35 PM

Jan 17 2018

dantti committed R549:378c0e33dacb: More and more fixes (authored by dantti).
More and more fixes
Jan 17 2018, 9:15 PM
dantti committed R549:ea4a8cc2a56e: More fixes (authored by dantti).
More fixes
Jan 17 2018, 5:37 PM

Jan 16 2018

dantti committed R549:b50b1fb2a39d: more improvements (authored by dantti).
more improvements
Jan 16 2018, 8:43 PM
dantti committed R549:5edb0254db98: Fix setting locale (authored by dantti).
Fix setting locale
Jan 16 2018, 8:03 PM
dantti committed R549:61bfb8a97b13: Fix icon returned in PkIcons (authored by dantti).
Fix icon returned in PkIcons
Jan 16 2018, 7:59 PM
dantti committed R549:f68e13000450: more fixes (authored by dantti).
more fixes
Jan 16 2018, 7:58 PM
dantti committed R549:ba91b4f27feb: Fix crashes in package model (authored by dantti).
Fix crashes in package model
Jan 16 2018, 1:31 PM

Jan 15 2018

dantti committed R549:ee899f268fdd: Turn Apper KCM into a standalone app (authored by dantti).
Turn Apper KCM into a standalone app
Jan 15 2018, 8:21 PM
dantti committed R549:2d6d19e9e84e: Modernize code (authored by dantti).
Modernize code
Jan 15 2018, 7:42 PM

Jan 12 2018

dantti committed R549:a90aeecc56dd: More updates (authored by dantti).
More updates
Jan 12 2018, 10:20 PM
dantti committed R549:0f9aa83ad308: Remove kde4support (authored by dantti).
Remove kde4support
Jan 12 2018, 8:58 PM