Feed Advanced Search

Wed, Jun 6

dantti committed R363:fefa0fd010ff: Simplify accessing a job object (authored by dantti).
Simplify accessing a job object
Wed, Jun 6, 8:29 PM
dantti committed R363:5d3c5f7bc417: Possibly fix a crash by updating a row before moving it (authored by dantti).
Possibly fix a crash by updating a row before moving it
Wed, Jun 6, 8:24 PM

Mar 21 2018

dantti accepted D11546: handle sigquit properly.

LGTM I only confused about why do you need QRegExp :P

Mar 21 2018, 2:28 PM
dantti added a comment to D11546: handle sigquit properly.

AFAIK this is the wrong way of handling signals, don't recall exactly what the problem is, but Qt documentation says to create a pipe, attach a QSocketNotifier to it, and write data to it when the signal is caught, then the QSN signal will call qApp->quit();

Mar 21 2018, 12:54 PM

Mar 17 2018

dantti accepted D11429: Fix build with Qt 5.11 (missing QRegExpValidator).
Mar 17 2018, 9:11 PM

Mar 8 2018

dantti accepted D10967: Remove custom compact representation.

LGTM

Mar 8 2018, 2:12 PM

Feb 21 2018

dantti committed R549:c34888dd5461: Fix compilation when EDIT_ORIGNS_DESKTOP_NAME is defined (authored by dantti).
Fix compilation when EDIT_ORIGNS_DESKTOP_NAME is defined
Feb 21 2018, 8:19 PM
dantti accepted D10707: Fix build without AppStream.

OK, thanks I'll probably make it mandatory for 1.1.0 as it's a simple dep and the less ifdefs the better

Feb 21 2018, 11:54 AM
dantti added a comment to D10706: Install apper binary as TARGET instead of PROGRAM.

master please

Feb 21 2018, 11:52 AM
dantti accepted D10706: Install apper binary as TARGET instead of PROGRAM.

oops my bad

Feb 21 2018, 10:15 AM
dantti added a comment to D10707: Fix build without AppStream.

Thanks, I've been thinking into making this dependency mandatory, could you please tell me why would you like to build without AppStream or are you just fixing the bug? thanks

Feb 21 2018, 10:14 AM

Feb 20 2018

dantti committed R549:4b812d3899bb: Fix showing Close button on session task finished (authored by dantti).
Fix showing Close button on session task finished
Feb 20 2018, 8:09 PM
dantti committed R549:7aa0542db56d: Fix screenshots (authored by dantti).
Fix screenshots
Feb 20 2018, 8:09 PM
dantti committed R549:c0597cdddf94: Fix screenshot/thumbnails viewer (authored by dantti).
Fix screenshot/thumbnails viewer
Feb 20 2018, 8:09 PM

Feb 19 2018

dantti committed R549:3e7d4d95845d: Some more autos and fixes (authored by dantti).
Some more autos and fixes
Feb 19 2018, 11:00 PM

Feb 7 2018

dantti committed R363:7a3208bc0b47: trivial: Post release version bump (authored by dantti).
trivial: Post release version bump
Feb 7 2018, 5:06 PM
dantti committed R363:a7f1ca98ce53: A few code improvements on configure-printer (authored by dantti).
A few code improvements on configure-printer
Feb 7 2018, 12:42 AM
dantti committed R363:8771d213301b: Fix switching pages and handlying Apply button on Configure Printer dialog (authored by dantti).
Fix switching pages and handlying Apply button on Configure Printer dialog
Feb 7 2018, 12:42 AM

Feb 6 2018

dantti accepted D10351: Fix Plasma applet printer job count.

LGTM

Feb 6 2018, 9:32 PM

Jan 28 2018

dantti committed R549:d0efb3d82088: Reduce build time by properly including mocs (authored by dantti).
Reduce build time by properly including mocs
Jan 28 2018, 9:05 PM
dantti committed R363:58283ab3e7d0: Don't lazy register the DBus stuff (authored by dantti).
Don't lazy register the DBus stuff
Jan 28 2018, 8:57 PM
dantti committed R363:e827a139a9e4: cleanup kded module (authored by dantti).
cleanup kded module
Jan 28 2018, 8:57 PM
dantti committed R363:74cc553cd822: Fix action to configure newly added printer broken by commit… (authored by dantti).
Fix action to configure newly added printer broken by commit…
Jan 28 2018, 8:57 PM
dantti committed R363:aad3a355f943: Make kded module async, fix crash, modernize it's code, fix leak (authored by dantti).
Make kded module async, fix crash, modernize it's code, fix leak
Jan 28 2018, 8:57 PM
dantti committed R363:9187e96a96c3: Fix GetReady notify sound (authored by dantti).
Fix GetReady notify sound
Jan 28 2018, 8:57 PM
dantti committed R363:ad0bd5f63a81: More use of initializer lists (authored by dantti).
More use of initializer lists
Jan 28 2018, 8:57 PM

Jan 27 2018

dantti committed R363:57f40f44c74e: Fix desktop file name for kde-add-printer so we get an icon on Wayland (authored by dantti).
Fix desktop file name for kde-add-printer so we get an icon on Wayland
Jan 27 2018, 3:37 AM
dantti committed R363:2f85d7390825: Change sort order when adding a new printer (authored by dantti).
Change sort order when adding a new printer
Jan 27 2018, 3:12 AM
dantti committed R363:ad261afa38de: Do not sort printers by default and remote (authored by dantti).
Do not sort printers by default and remote
Jan 27 2018, 1:10 AM

Jan 26 2018

dantti committed R549:cea869a0eae3: Fix loading KPixmapSequence (authored by dantti).
Fix loading KPixmapSequence
Jan 26 2018, 9:21 PM
dantti committed R363:6547b707093e: Allow canceling a job with Delete key shortcut (authored by dantti).
Allow canceling a job with Delete key shortcut
Jan 26 2018, 9:21 PM
dantti committed R363:ab9c8293c488: Use initilizer lists (authored by dantti).
Use initilizer lists
Jan 26 2018, 9:21 PM

Jan 25 2018

dantti committed R363:4bce8ae8b513: Fix not accepting cups-pdf urls (authored by dantti).
Fix not accepting cups-pdf urls
Jan 25 2018, 6:28 PM
dantti committed R363:fd2bfeb16693: Bump version to 0.4.0 (authored by dantti).
Bump version to 0.4.0
Jan 25 2018, 6:28 PM
dantti committed R363:7220560631aa: Fix plasma startup crash (authored by dantti).
Fix plasma startup crash
Jan 25 2018, 6:28 PM
dantti committed R363:3b43309693df: Fix build on Qt >= 5.8 (authored by dantti).
Fix build on Qt >= 5.8
Jan 25 2018, 6:28 PM
dantti committed R363:cd2074ee6140: Fix long messages in message widget by enabling word wrap (authored by dantti).
Fix long messages in message widget by enabling word wrap
Jan 25 2018, 6:28 PM
dantti committed R363:df841705fa01: Set the project version using the CMake project command (authored by dantti).
Set the project version using the CMake project command
Jan 25 2018, 6:28 PM
dantti committed R547:a46bd8bfb2f1: Modernize code with C++11 and Qt5 features (authored by dantti).
Modernize code with C++11 and Qt5 features
Jan 25 2018, 1:58 AM
dantti committed R363:5647d8111a3a: Reduce build time by including mocs files (authored by dantti).
Reduce build time by including mocs files
Jan 25 2018, 1:52 AM
dantti committed R363:2a568ebd67bf: Some code C++11 changes and cleanups (authored by dantti).
Some code C++11 changes and cleanups
Jan 25 2018, 1:52 AM
dantti committed R363:d019fa1ff4c9: Add QT_NO_CAST_FROM_ASCII definition (authored by dantti).
Add QT_NO_CAST_FROM_ASCII definition
Jan 25 2018, 1:52 AM
dantti committed R363:be54a009bdef: Add QT_NO_CAST_FROM_BYTEARRAY definition (authored by dantti).
Add QT_NO_CAST_FROM_BYTEARRAY definition
Jan 25 2018, 1:52 AM
dantti committed R363:571fe54d6da1: Disable deprecated before Qt 5.9 (authored by dantti).
Disable deprecated before Qt 5.9
Jan 25 2018, 1:52 AM
dantti committed R363:da0155478e63: Make use of new for range loops (authored by dantti).
Make use of new for range loops
Jan 25 2018, 1:52 AM
dantti committed R363:0c0bce67695c: Get rid of slow sender() calls (authored by dantti).
Get rid of slow sender() calls
Jan 25 2018, 1:52 AM
dantti committed R363:7d68c1d6531b: Make use of C++11 auto (authored by dantti).
Make use of C++11 auto
Jan 25 2018, 1:52 AM
dantti committed R363:13c6bc65a974: Add a missing connect change (authored by dantti).
Add a missing connect change
Jan 25 2018, 1:52 AM
dantti committed R363:adae1b4fcf4b: Finish porting to new Qt5 connect syntax (authored by dantti).
Finish porting to new Qt5 connect syntax
Jan 25 2018, 1:52 AM

Jan 19 2018

dantti committed R549:b3f58307a146: Fix getting icons from Appstream (authored by dantti).
Fix getting icons from Appstream
Jan 19 2018, 8:30 PM
dantti committed R549:6b606f9e6e5e: fix mem leak (authored by dantti).
fix mem leak
Jan 19 2018, 2:59 PM
dantti committed R549:0fe56facda3f: cleanups (authored by dantti).
cleanups
Jan 19 2018, 2:35 PM
dantti committed R549:3cb70376fd83: Fix some dialogs (authored by dantti).
Fix some dialogs
Jan 19 2018, 2:24 PM

Jan 18 2018

dantti committed R549:0b7b9e5d3c40: Be more strict with strings (authored by dantti).
Be more strict with strings
Jan 18 2018, 10:53 PM
dantti committed R549:ded5167bba65: Fix deprecated Qt usage (authored by dantti).
Fix deprecated Qt usage
Jan 18 2018, 9:09 PM
dantti committed R549:a873e6600567: PackageKit Session interface fixed (authored by dantti).
PackageKit Session interface fixed
Jan 18 2018, 9:02 PM
dantti committed R549:da97d8bea05e: Some fixes on file watching (authored by dantti).
Some fixes on file watching
Jan 18 2018, 2:35 PM

Jan 17 2018

dantti committed R549:378c0e33dacb: More and more fixes (authored by dantti).
More and more fixes
Jan 17 2018, 9:15 PM
dantti committed R549:ea4a8cc2a56e: More fixes (authored by dantti).
More fixes
Jan 17 2018, 5:37 PM

Jan 16 2018

dantti committed R549:b50b1fb2a39d: more improvements (authored by dantti).
more improvements
Jan 16 2018, 8:43 PM
dantti committed R549:5edb0254db98: Fix setting locale (authored by dantti).
Fix setting locale
Jan 16 2018, 8:03 PM
dantti committed R549:61bfb8a97b13: Fix icon returned in PkIcons (authored by dantti).
Fix icon returned in PkIcons
Jan 16 2018, 7:59 PM
dantti committed R549:f68e13000450: more fixes (authored by dantti).
more fixes
Jan 16 2018, 7:58 PM
dantti committed R549:ba91b4f27feb: Fix crashes in package model (authored by dantti).
Fix crashes in package model
Jan 16 2018, 1:31 PM

Jan 15 2018

dantti committed R549:ee899f268fdd: Turn Apper KCM into a standalone app (authored by dantti).
Turn Apper KCM into a standalone app
Jan 15 2018, 8:21 PM
dantti committed R549:2d6d19e9e84e: Modernize code (authored by dantti).
Modernize code
Jan 15 2018, 7:42 PM

Jan 12 2018

dantti committed R549:a90aeecc56dd: More updates (authored by dantti).
More updates
Jan 12 2018, 10:20 PM
dantti committed R549:0f9aa83ad308: Remove kde4support (authored by dantti).
Remove kde4support
Jan 12 2018, 8:58 PM

Jan 10 2018

dantti committed R549:b043d9dc76d9: Port Requirements to QDialog (authored by dantti).
Port Requirements to QDialog
Jan 10 2018, 2:39 PM
dantti committed R549:3e7855a9592d: Port RepoSig to QDialog (authored by dantti).
Port RepoSig to QDialog
Jan 10 2018, 2:29 PM
dantti committed R549:3bc09487cee9: Port ApplicationLauncher to QDialog (authored by dantti).
Port ApplicationLauncher to QDialog
Jan 10 2018, 2:17 PM
dantti committed R549:14f03afcd80a: Some more deprecation removal (authored by dantti).
Some more deprecation removal
Jan 10 2018, 2:07 PM
dantti committed R549:226a606599b8: Remove more deprecated stuff (authored by dantti).
Remove more deprecated stuff
Jan 10 2018, 12:49 PM

Jan 9 2018

dantti committed R549:83542af7db2a: Remove deprecated usage of KMenu (authored by dantti).
Remove deprecated usage of KMenu
Jan 9 2018, 9:17 PM
dantti committed R549:21d684902930: Fix more deprecated stuff (authored by dantti).
Fix more deprecated stuff
Jan 9 2018, 9:08 PM
dantti committed R549:8eb1e5c4d527: Further fixes (authored by dantti).
Further fixes
Jan 9 2018, 8:30 PM
dantti committed R549:55b8fc8c2d1a: Make it build with packagekit-qt 1.0.0 (authored by dantti).
Make it build with packagekit-qt 1.0.0
Jan 9 2018, 8:07 PM

Sep 7 2017

dantti accepted D7325: KCupsConnection: Exit authentication loop after too many retries..

The patch looks good to me, though I could not test it myself yet, I see no reason not to push it.
Thanks

Sep 7 2017, 2:00 AM

Aug 16 2017

dantti committed R363:0827f9e83db0: Remove deprecated usage of QStyleOptionViewItemV4 (authored by dantti).
Remove deprecated usage of QStyleOptionViewItemV4
Aug 16 2017, 3:04 PM

Mar 27 2017

dantti added a comment to D5194: Make various bits of the Apper tool chain optional.

Since pk-session code needs libapper I'm not sure spliting would easy anything...

Mar 27 2017, 1:16 PM
dantti accepted D5194: Make various bits of the Apper tool chain optional.

+1

Mar 27 2017, 12:39 PM
dantti accepted D5193: Port away from KUniqueApplication to QApplication with KDBusService.

+1

Mar 27 2017, 12:39 PM

Nov 23 2016

dantti committed R183:4ade375094aa: Update to Cutelyst 1.0.0 stable (authored by dantti).
Update to Cutelyst 1.0.0 stable
Nov 23 2016, 10:04 PM