Enable HiDPI pixmaps
Needs RevisionPublic

Authored by kadabash on Mar 15 2019, 8:03 PM.

Details

Reviewers
dantti
aacid
Summary

BUG: 390844

Diff Detail

Repository
R549 Apper
Branch
hidpi_pixmaps (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9641
Build 9659: arc lint + arc unit
kadabash requested review of this revision.Mar 15 2019, 8:03 PM
kadabash created this revision.

I tested this on Ubuntu 18.10, the difference is clearly visible in the attached screenshots.

kadabash updated this revision to Diff 53977.EditedMar 15 2019, 9:20 PM

Scale package description text properly

The text is painted in a QPixmap, whose pixel scaling ratio needs to be
adjusted manually to use HiDPI.

Here are two screenshots showing the difference of the second change.
The pixelated description text is in the "Name" column of the package list.

dantti accepted this revision.Mar 18 2019, 1:43 AM

thanks

This revision is now accepted and ready to land.Mar 18 2019, 1:43 AM
aacid added a subscriber: aacid.Sep 13 2019, 8:56 AM

Our servers don't allow this commit unfortunately

remote: Audit failure - Non-full name: Kadabash

aacid requested changes to this revision.Sep 13 2019, 8:58 AM
This revision now requires changes to proceed.Sep 13 2019, 8:58 AM

Sorry, I don't understand what it is you would like me to do.
I do not have access to a KDE development setup, so I cannot push any new commits.
In my Phabricator account settings, a full name is set, which is not "Kadabash", however.

aacid added a comment.Sep 14 2019, 9:27 AM

We need your full name to be able to commit it to git

Tim __ is not your full name (i hope)

cfeck added a subscriber: cfeck.Nov 21 2019, 3:37 PM

Tim, if you don't want to be attributed, are you okey with someone else showing up as the author in commit logs?

Yes, that is perfectly fine for me.