Show printer and job name if only one job is being printed
ClosedPublic

Authored by broulik on Sep 7 2018, 9:03 AM.

Details

Summary

This is the common case, show some information about the active print job

Test Plan

Before it would just show "One print job is active"

Diff Detail

Repository
R363 Print Manager
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Sep 7 2018, 9:03 AM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptSep 7 2018, 9:03 AM
broulik requested review of this revision.Sep 7 2018, 9:03 AM
broulik updated this revision to Diff 41138.Sep 7 2018, 9:06 AM
  • Job name can be empty, check for that
ngraham added a subscriber: ngraham.Sep 7 2018, 1:15 PM

Nice!

plasmoid/package/contents/ui/printmanager.qml
53

"on" -> "with" or "using"

55

"on" -> "with" or "using"

broulik updated this revision to Diff 41154.Sep 7 2018, 1:36 PM

on → with

ngraham accepted this revision as: VDG.Sep 7 2018, 1:40 PM
dantti accepted this revision.Sep 10 2018, 2:20 PM
dantti added a subscriber: dantti.

LGTM

This revision is now accepted and ready to land.Sep 10 2018, 2:20 PM
This revision was automatically updated to reflect the committed changes.