the latter is for when the last argument is a format string. which I
believe is not the case here. or perhaps more importantly if it was a
format string it'd be an invalid call because we pass no values in
Details
Details
- Reviewers
dantti - Commits
- R363:1d30388fca52: use httpAssembleURI not httpAssembleURIf
- make two printers
- pause them
- print job to one printer
- open printer queue
- right click job to move to other printer
- job is now on other printer
Diff Detail
Diff Detail
- Repository
- R363 Print Manager
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I take it the library isn't actually api-stable? So we could also change that function name, it should really be assembleUri given the arguments.
Comment Actions
Oh and FWIW, this fixes build problems on debian where -Werror=format-security is set by default (and consequently tripping over format strings without arguments).
Comment Actions
LGTM, is the new function available since old CUPS versions? Just to make sure it won't break usage with old versions.
Comment Actions
Yep, they are both API version 1.2 https://opensource.apple.com/source/cups/cups-450/cups/doc/help/api-httpipp.html#httpAssembleURI