Differential D19951

Prevent crashing Apper on PackageModel::clearSelectedNotPresent()
ClosedPublic
Actions

Authored by gepardo on Mar 21 2019, 7:03 PM.

Details

Reviewers
dantti
apol
Commits
R549:d486706f3e9f: Prevent crashing Apper on PackageModel::clearSelectedNotPresent()
Summary

m_checkedPackages.erase() is called, but the iterator is not increased, therefore on the next iteration we use an invalid iterator

BUG: 405433
BUG: 401461
BUG: 402170

Test Plan

I just rebuilt Apper, ran it and installed the updates with it. The bug does not appear.

Diff Detail

Repository
R549 Apper
Branch
fix-crash-on-update (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9952
Build 9970: arc lint + arc unit
gepardo requested review of this revision.Mar 21 2019, 7:03 PM
gepardo created this revision.
gepardo retitled this revision from Prevent crashing Ark on PackageModel::clearSelectedNotPresent() to Prevent crashing Apper on PackageModel::clearSelectedNotPresent().Mar 21 2019, 7:05 PM
gepardo updated this revision to Diff 54506.Mar 21 2019, 7:05 PM

Fix commit message: Ark -> Apper

gepardo updated this revision to Diff 54508.Mar 21 2019, 7:16 PM

Use a more compact way, as suggested in IRC

dantti accepted this revision.Mar 21 2019, 7:51 PM

Thanks +1

This revision is now accepted and ready to land.Mar 21 2019, 7:51 PM
gepardo added a comment.EditedMar 21 2019, 7:53 PM

You are welcome :)

Can you push it into the repository? I can't do it myself.

aacid closed this revision.Mar 21 2019, 10:11 PM

Revision Contents
Changeset List

PathPackages
Mlibapper/PackageModel.cpp (2 lines)

Diff 54508

View Options

libapper/PackageModel.cpp

Loading...