When the user is not member of a system group pressing the System Preferences button triggers a password dialog because of the getServerSettings() call. When the dialog finished the menu is closed again. We don't actually need to fetch the settings since its already done on startup
Needs D23403 to be effective.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
+1
Does it actually monitor those settings? Maybe that was the reason it queried it, so the menu is always up to date.
Yes, the idea is to be up to date, the issue it seems to be that some CUPS installations keep asking the server password on each query instead of having it cached.
Does removing this line will keep this menu updated when an user change some setting from it?
When I change settings from the menu the state is always correct. I assume that if I change the settings from the outside (like the CUPS web interface) the menu state would be wrong
Ok, while not an ideal change, these options aren't the kind of options that should be changing that often so I'm ok. Thanks