Fix build without AppStream
ClosedPublic

Authored by arojas on Feb 21 2018, 9:56 AM.

Details

Summary

Don't try to link to AppStream-Qt if building with APPSTREAM=OFF

Test Plan

Builds and runs fine without AppStream

Diff Detail

Repository
R549 Apper
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas requested review of this revision.Feb 21 2018, 9:56 AM
arojas created this revision.

Thanks, I've been thinking into making this dependency mandatory, could you please tell me why would you like to build without AppStream or are you just fixing the bug? thanks

Thanks, I've been thinking into making this dependency mandatory, could you please tell me why would you like to build without AppStream or are you just fixing the bug? thanks

I have no interest - in fact, I'm building it with AppStream on Arch. I'm just fixing it since it is currently optional (and disabled by default).

dantti accepted this revision.Feb 21 2018, 11:54 AM

OK, thanks I'll probably make it mandatory for 1.1.0 as it's a simple dep and the less ifdefs the better

This revision is now accepted and ready to land.Feb 21 2018, 11:54 AM
This revision was automatically updated to reflect the committed changes.