[Applet] Port to ExpandableListItem
AcceptedPublic

Authored by ngraham on Fri, Mar 13, 5:27 PM.

Details

Reviewers
dantti
davidedmundson
Group Reviewers
VDG
Plasma
Summary

Depends on D28033

Test Plan

All functionality still works. There are minimal visual changes, mostly little things
to make the appearance consistent with other applets using the new ExpandableListItem
component.

Diff Detail

Repository
R363 Print Manager
Branch
port-to-ExpandableListItem (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 23890
Build 23908: arc lint + arc unit
ngraham created this revision.Fri, Mar 13, 5:27 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptFri, Mar 13, 5:27 PM
ngraham requested review of this revision.Fri, Mar 13, 5:27 PM

Well I still think that this applet rewrite is very useless, very little care about their printers, it's the print jobs that matter, still the patch looks fine, although I see the buttons showing up before the selection is fully expanded.

very little care about their printers, it's the print jobs that matter

Yeah, making the applet show print jobs might be nice. That sounds sensible enough to me to do in the future.

still the patch looks fine, although I see the buttons showing up before the selection is fully expanded.

I'll see if I can fix that in the ExpandableListItem itself.

Added a little opacity animation for the expanded view contents in D28033.

davidedmundson accepted this revision.Sun, Mar 15, 7:24 PM
davidedmundson added a subscriber: davidedmundson.

I like red patches.

This revision is now accepted and ready to land.Sun, Mar 15, 7:24 PM
ngraham updated this revision to Diff 77698.Mon, Mar 16, 3:22 AM

Use consistent highlight durations

ngraham updated this revision to Diff 77939.Wed, Mar 18, 4:25 PM

ExpandableListItem is now in PlasmaExtras

ngraham updated this revision to Diff 77943.Wed, Mar 18, 5:17 PM

Remove now-unnecessary imports