Details
- Reviewers
dhaumann vkrause dantti - Group Reviewers
Framework: Syntax Highlighting
Diff Detail
- Repository
- R216 Syntax Highlighting
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 8327 Build 8345: arc lint + arc unit
I'm not entirely sure this is really needed on Windows, but when cross-compiling this allowed to search for the katehighlightingindexer.exe which wouldn't run because I was on Linux...
But in any case if this doesn't break the cross-compile with an external katehighlightingindexer executable I believe this would cause no harm then.
I think I let Volker decide that, for non-cross compile stuff this is more or less a nop and I never do cross compiling ;)
I ended up compiling it using vcpkg toolchain directly on Windows, which showed this isn't required.
In fact even when cross-compiling this won't fix anything because the tool must run on the host OS.
So I only still think this is useful because the user will notice that it tried to compile and run an .EXE which won't work on their host, I don't think this will cause any harm but I didn't test if this still works when specifiyng the indexer path variable.
> I will abandon it.
I compile syntax-highlighting btw. nightly, too, in the AbsInt compile farm on Windows (MSVC) and macOS (xcode toolchain) and see no issues with the current way.