Works great, I like it :-)

Sounds exciting! I'm trying to apply the patches one after the other, but 18505 and 18593 fail to apply. I'm doing

Thanks. The shortened patches are great for review.

Looks fine.

Looks fine

See also https://bugs.kde.org/show_bug.cgi?id=378767

Looks good to me. Please do another thorough test before pushing as discussed in IRC.

@rahn Can you review this as well? I'd like to have more eyes on it as it touches some pretty sensitive areas of the vector tiling pipeline.

Loks good on quick sight, though I would like a unit test for the building height extraction method as discussed.
Regarding the node reduction, how did you test this? I am missing changes in the osm plugin to ensure buildings are written to osm xml and o5m files. I guess that at the moment tools like kml2kml and likewise the vector tile creation tool do not write buildings anymore. Can you look into it?

Thanks, time to push it I'd say - Torsten?

I miss a "sane" constructor. What about introducing a unit test so the class is used in one place at least for a basic sanity check?

Looks good, please push.

In D6159#115442, @mnafees wrote:

I was creating tiles for the state of Ontario, Canada and it seems to get stuck after " [========================================>] 100% landmass cache tiles complete." Any idea what might be the problem?

You can generate tiles locally. The tile creation tool uses the marble library and therefore picks up changes like extracting more tags, so the locally created tiles will have the additional data. See https://techbase.kde.org/Marble/OSMVectorTileCreation

Looks fine :-)

In T6274#96978, @mnafees wrote:

I propose a similar UI as Google Maps to indicate and navigate the different levels in a building/area, which crudely means that we render the respective floor tags when a particular floor is selected.

Sounds good to me.

In T6273#96975, @mnafees wrote:

1. Do I just have to add the indoor tags as textual descriptions in Placemark.cpp?

declarative/Placemark.cpp is responsible for showing tag details when you select (tap on) some feature in Marble Maps. For keys like height this would be useful. Many tags will not be extracted by Marble at the moment however (e.g. indoor=room), so more changes are needed to extract/render them in the first place.

In T6287#97066, @mnafees wrote:

GeoDataPlacemark.h:186 says "please keep order (used in for loops)" so where should I add the HighwayElevator enum value?

In D1484#114891, @kossebau wrote:

Obviously no interest from maintainers to have this in, so dropping for now.

From what I remember the problem goes like this: On Android, change some setting, then open the application list and swipe Marble Maps to the right to kill it. The settings were not saved, so not restored upon the next start.

Looks fine to me. Last Windows installer I used windeployqt which created a folder translations. I can check and adjust that next time I tinker with it. So far no translations are used in Windows.

Torsten, I'm accepting as Marble now given the time passed.

Looks good to me.

Awesome work! The patch looks very clean and it integrates well with the current user interface.

Looks good, please push.

Now data is called uninitialized in data->sourceFile(), no? I think shentey meant this instead: