Introduced rotation the globe by right mouse button.
ClosedPublic

Authored by vdoroshchuk on Apr 29 2017, 11:14 AM.

Details

Summary

Also applied kinetic spinning like it is with changing position.

Test Plan

to-check: open a map and push the right button of mouse, the globe is going to be rotated by moving mouse by x and y axis.
Also if you unclick the button, kinetic spinning will be enabled like it is when you use left mouse button.

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vdoroshchuk created this revision.Apr 29 2017, 11:14 AM
nienhueser added a subscriber: Marble.

Awesome work! The patch looks very clean and it integrates well with the current user interface.

It also enables some nice follow-up tasks, e.g. taking heading into account in the compass plugin (more than two states as it has now) or rotating the map to follow the navigation direction during turn-by-turn navigation.

src/lib/marble/MarbleInputHandler.cpp
800

qAbs (does not compile with abs here, same for the other ones)

801

qAbs

src/lib/marble/kineticmodel.cpp
201

qAbs

nienhueser accepted this revision as: nienhueser.Apr 30 2017, 8:44 AM
This revision is now accepted and ready to land.Apr 30 2017, 8:44 AM
nienhueser added inline comments.Apr 30 2017, 2:04 PM
src/lib/marble/MarbleInputHandler.cpp
192

m_heading should be initialized here as well

vdoroshchuk marked 4 inline comments as done.May 4 2017, 6:06 AM
nienhueser accepted this revision.May 9 2017, 4:10 AM

Torsten, I'm accepting as Marble now given the time passed.

This revision was automatically updated to reflect the committed changes.