Lookup ECM once in toplevel CMakeLists.txt
AbandonedPublic

Authored by kossebau on Apr 25 2016, 8:17 AM.

Details

Reviewers
nienhueser
rahn
Summary

It seems more nice to look up ECM once instead of with duplicated code
everywhere.

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
kossebau updated this revision to Diff 3503.Apr 25 2016, 8:17 AM
kossebau retitled this revision from to Lookup ECM once in toplevel CMakeLists.txt (& fix mimetype installation).
kossebau updated this object.
kossebau edited the test plan for this revision. (Show Details)
kossebau added reviewers: rahn, nienhueser.
nienhueser edited edge metadata.Apr 27 2016, 4:18 AM

Does the scope change (ecm call now affects lib/marble and plugins) result in changes e.g. of installation dirs? I would like to keep the structure identical for qtonly vs. Kde builds. If so I'd rather make it a macro in MarbleMacros to be called in the now removed places.

Does the scope change (ecm call now affects lib/marble and plugins) result in changes e.g. of installation dirs? I would like to keep the structure identical for qtonly vs. Kde builds. If so I'd rather make it a macro in MarbleMacros to be called in the now removed places.

From what I know (and expect) just finding ECM should not yet result in any changes (though nastiness is possible). And the ECM_MODULE_PATH is only appended to CMAKE_MODULE_PATH, so should also not result in overriding any Marble modules.
Changes of e.g. installation paths should be only triggered by explicit usage of ECM stuff, e.g. include(KDEInstallDirs).
So in theory the answer is no, modulo real world bugs.

Biggest motivator for this patch is D1485, to be able to also centrally use ECMEnableSanitizers, so that all of Marble build results can be instrumented as needed for the ASAN-checking on KDE CI. Which would be a nice thing to have IMHO (next to unbreaking the test execution there, which currently otherwise will need extra support by CI, cmp. https://marc.info/?t=146157489200004&r=1&w=2).
Happy about ideas for better alternatives :)

kossebau added a comment.EditedApr 27 2016, 11:14 PM

While this is pending, created a separate patch for fixing the installation of the mimetype definitions, which should be also backported to 16/04: D1505

kossebau updated this revision to Diff 3748.May 10 2016, 3:59 PM
kossebau edited edge metadata.
kossebau removed R34 Marble as the repository for this revision.

Update to latest master

kossebau set the repository for this revision to R34 Marble.May 10 2016, 4:01 PM
kossebau retitled this revision from Lookup ECM once in toplevel CMakeLists.txt (& fix mimetype installation) to Lookup ECM once in toplevel CMakeLists.txt.
kossebau updated this object.
kossebau abandoned this revision.Jun 7 2017, 3:35 PM

Obviously no interest from maintainers to have this in, so dropping for now.

nienhueser edited edge metadata.Jun 8 2017, 4:01 PM

Obviously no interest from maintainers to have this in, so dropping for now.

I'd rather say we have no maintainers at the moment :-/