It seems more nice to look up ECM once instead of with duplicated code
everywhere.
Details
- Reviewers
nienhueser rahn
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Does the scope change (ecm call now affects lib/marble and plugins) result in changes e.g. of installation dirs? I would like to keep the structure identical for qtonly vs. Kde builds. If so I'd rather make it a macro in MarbleMacros to be called in the now removed places.
From what I know (and expect) just finding ECM should not yet result in any changes (though nastiness is possible). And the ECM_MODULE_PATH is only appended to CMAKE_MODULE_PATH, so should also not result in overriding any Marble modules.
Changes of e.g. installation paths should be only triggered by explicit usage of ECM stuff, e.g. include(KDEInstallDirs).
So in theory the answer is no, modulo real world bugs.
Biggest motivator for this patch is D1485, to be able to also centrally use ECMEnableSanitizers, so that all of Marble build results can be instrumented as needed for the ASAN-checking on KDE CI. Which would be a nice thing to have IMHO (next to unbreaking the test execution there, which currently otherwise will need extra support by CI, cmp. https://marc.info/?t=146157489200004&r=1&w=2).
Happy about ideas for better alternatives :)
While this is pending, created a separate patch for fixing the installation of the mimetype definitions, which should be also backported to 16/04: D1505