Add missing indoor OSM tags
Closed, ResolvedPublic

Description

Look into the already implemented indoor tags, and add the missing ones.

mnafees created this task.Jun 5 2017, 7:15 PM
mnafees added subscribers: rahn, nienhueser.EditedJun 8 2017, 9:52 AM

Copy-pasting what I had asked in the mail.

Some points of wonderment:

  1. Do I just have to add the indoor tags as textual descriptions in Placemark.cpp?
  2. What about the icons / glyphs for indoor tags like elevators?
  3. As suggested by @rahn regarding the introduction of GeoDataBuilding for indoor mapping, what's the approach I should be taking?

@nienhueser Your thoughts? :)

mnafees raised the priority of this task from Normal to High.Jun 8 2017, 9:53 AM
  1. Do I just have to add the indoor tags as textual descriptions in Placemark.cpp?

declarative/Placemark.cpp is responsible for showing tag details when you select (tap on) some feature in Marble Maps. For keys like height this would be useful. Many tags will not be extracted by Marble at the moment however (e.g. indoor=room), so more changes are needed to extract/render them in the first place.

  1. What about the icons / glyphs for indoor tags like elevators?

So far we mostly used https://github.com/gravitystorm/openstreetmap-carto and http://www.sjjb.co.uk/mapicons/contactsheet (take care, huge page) as well as self-drawn icons, some derived from icons from the Noun project. Also material icons for non-map icons in Marble Maps. Also see Torsten's answer by mail:

If you look at

http://www.openstreetmap.org/search?query=N%C3%BCrnberg%20Flughafen#map=19/49.49395/11.07899

(Nuremberg Airport = "Flughafen Nürnberg")

you see an elevator symbol there (the vertical double arrow). Currently we don't seem to render it although the icon is available inside the marble source code already:

~/marble/sources/data/svg/osmcarto/svg/transportation/elevator-12.svg

Check

git show 6bd4a388e7176dbcaf92ea5e3185a36164ac1677

to see how this can be done using the example of sport shops and copy shops. Make sure that the icon is displayed properly. Also make sure that any available and relevant tags for elevators are displayed properly in the description panel.

  1. As suggested by @rahn regarding the introduction of GeoDataBuilding for indoor mapping, what's the approach I should be taking?

I think this is unrelated for now.