Fix installation folder for qm files in KDE Apps release settings
ClosedPublic

Authored by kossebau on May 10 2017, 12:02 AM.

Details

Summary

Old CMake code for estimating the installation dir of the qm files
was broken, did not match where the code is looking and thus the
traditional path as used before by the separate KDE Application
translation release tarballs as well code using libmarblewidget
and explicitely loading the translation with ecm_create_qm_loader,
as it is needed.

Test Plan

Works now for installation on Linux.
Android only theoretically tested ;)
Windows & macOS... no idea

Diff Detail

Repository
R34 Marble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.May 10 2017, 12:02 AM
nienhueser accepted this revision.May 10 2017, 5:36 AM

Looks fine to me. Last Windows installer I used windeployqt which created a folder translations. I can check and adjust that next time I tinker with it. So far no translations are used in Windows.

This revision is now accepted and ready to land.May 10 2017, 5:36 AM
This revision was automatically updated to reflect the committed changes.