Allow to assign a z-Order to files
ClosedPublic

Authored by sanjibanb on Mar 30 2016, 3:36 AM.

Details

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
sanjibanb updated this revision to Diff 3020.Mar 30 2016, 3:36 AM
sanjibanb retitled this revision from to Allow to assign a z-Order to files.
sanjibanb updated this object.
sanjibanb edited the test plan for this revision. (Show Details)
sanjibanb added reviewers: nienhueser, rahn.
sanjibanb set the repository for this revision to R34 Marble.
sanjibanb added a project: Marble.
nienhueser edited edge metadata.Mar 31 2016, 8:15 AM

Hi Sanjiban,

read your mail which explains the changes to srtm.dgml. Quoting it here for @rahn "However, as for those black patches in Atlas, it turns out that the fix was pretty straightforward, and was hidden in the dgml file itself. I noticed that the "#" was missing for the brush color values for ne_50m_lakes and ne_50m_glaciated_areas in strm.dgml. After adding those, things are working fine, Greenland is not rendering black anymore and the lakes in North America (and elsewhere) have also started rendering blue, which was not the case earlier. There still remained some black patches around the Antarctica, and a couple of lakes in Africa and Kazakhstan, but I exchanged the brush and pen colors for ne_50m_antarctic_ice_shelves_polys, and ne_50m_lakes_historic respectively, and those got fixed as well.

Great catch! We should backport that part to older releases as well. Therefore it would be great if we could have separate commits for the brush/pen changes in srtml.dgml and the renderOrder feature implementation. I'd also like @rahn to have a look at srtm.dgml, especially the glacier areas in there. I wonder if it is possible to have the elevation model shine through (i.e. colorize ice instead of overpaint white)?

sanjibanb updated this revision to Diff 3110.Apr 3 2016, 6:22 PM
sanjibanb edited edge metadata.

Remove changes in strm.dgml file

sanjibanb updated this revision to Diff 3111.Apr 3 2016, 6:34 PM

Removed invalid color code from dgml

Although this patch solves the target problem only partially, this patch is pushed to master already. Should this be accepted?

sanjibanb removed a reviewer: rahn.May 26 2017, 3:05 AM
nienhueser accepted this revision.May 26 2017, 7:08 PM
This revision is now accepted and ready to land.May 26 2017, 7:08 PM
nienhueser closed this revision.May 26 2017, 7:08 PM