nienhueser (Dennis Nienhüser)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 5:20 AM (135 w, 2 d)
Availability
Available

Recent Activity

Sep 5 2017

nienhueser added inline comments to D7623: Remove the visual category "building".
Sep 5 2017, 4:34 AM

Sep 3 2017

nienhueser added inline comments to D7623: Remove the visual category "building".
Sep 3 2017, 9:42 AM
nienhueser committed R34:b17fd48753db: Fix fall-through case (authored by nienhueser).
Fix fall-through case
Sep 3 2017, 8:44 AM

Aug 31 2017

nienhueser accepted D7622: Render indoor walls, rooms and doors.
Aug 31 2017, 10:22 AM

Aug 23 2017

nienhueser added a comment to D7453: Marble Maps design revisions.

Works great, I like it :-)

Aug 23 2017, 7:21 PM · Marble
nienhueser added a comment to D7453: Marble Maps design revisions.

Sounds exciting! I'm trying to apply the patches one after the other, but 18505 and 18593 fail to apply. I'm doing

Aug 23 2017, 5:43 PM · Marble

Aug 20 2017

nienhueser accepted D7437: Kirigami Marble Maps design revisions .
Aug 20 2017, 5:55 PM · Marble: Material Maps
nienhueser added inline comments to D7353: Marble Maps design revisions using Kirigami.
Aug 20 2017, 10:28 AM · Kirigami, Marble: Material Maps

Aug 19 2017

nienhueser accepted D7353: Marble Maps design revisions using Kirigami.

Thanks. The shortened patches are great for review.

Aug 19 2017, 5:35 AM · Kirigami, Marble: Material Maps

Aug 17 2017

nienhueser accepted D7363: set comment on plasma applet desktop file.
Aug 17 2017, 3:13 PM

Aug 16 2017

nienhueser accepted D7353: Marble Maps design revisions using Kirigami.

Looks fine.

Aug 16 2017, 6:33 PM · Kirigami, Marble: Material Maps

Aug 14 2017

nienhueser accepted D7309: Add missing OSM symbols to StyleBuilder.

Looks fine

Aug 14 2017, 5:19 PM

Aug 7 2017

nienhueser added a comment to T837: Release Marble Maps at f-droid.

See also https://bugs.kde.org/show_bug.cgi?id=378767

Aug 7 2017, 4:52 AM · Marble

Jul 31 2017

nienhueser accepted D6884: Add a debug mode that filters level tag values.
Jul 31 2017, 6:42 PM

Jul 30 2017

nienhueser requested changes to D6884: Add a debug mode that filters level tag values.
Jul 30 2017, 6:04 AM
nienhueser added inline comments to D6884: Add a debug mode that filters level tag values.
Jul 30 2017, 6:04 AM

Jul 23 2017

nienhueser renamed T6326: Add a debug mode that filters level tag values from Add a debug mode that allows for selecting a particular "current level" for the selected building to Add a debug mode that filters level tag values.
Jul 23 2017, 4:17 PM · Marble: Indoor Maps

Jul 3 2017

nienhueser accepted D6303: Initial integration of the GeoDataBuilding into the parser and renderer.

Looks good to me. Please do another thorough test before pushing as discussed in IRC.

Jul 3 2017, 7:38 PM
nienhueser created T6448: Access to Publish Android Alpha Versions.
Jul 3 2017, 7:09 PM · Marble: Material Maps

Jul 2 2017

nienhueser requested changes to D6303: Initial integration of the GeoDataBuilding into the parser and renderer.

@rahn Can you review this as well? I'd like to have more eyes on it as it touches some pretty sensitive areas of the vector tiling pipeline.

Jul 2 2017, 5:09 PM

Jun 26 2017

nienhueser committed R34:45a6bffa2b2b: Remove opencaching.com plugin (service is dead) (authored by nienhueser).
Remove opencaching.com plugin (service is dead)
Jun 26 2017, 8:06 PM
nienhueser committed R34:ce6cbb18b148: Fix both plain map and political map showing no content at all (authored by nienhueser).
Fix both plain map and political map showing no content at all
Jun 26 2017, 7:59 PM
nienhueser committed R34:7b2207d2ab07: Fix function using xor operator when it should be using an and operator (authored by Dean Adamson <dadamson.dumping.ground@gmail.com>).
Fix function using xor operator when it should be using an and operator
Jun 26 2017, 7:06 PM
nienhueser committed R34:d1c9bb096f52: Fix rendering of polylines and polyrings after tileLevel refactoring (authored by tjakobi).
Fix rendering of polylines and polyrings after tileLevel refactoring
Jun 26 2017, 6:58 PM
nienhueser closed D6072: Fix rendering of polylines and polyrings after tileLevel refactoring by committing R34:d1c9bb096f52: Fix rendering of polylines and polyrings after tileLevel refactoring (authored by tjakobi).
Jun 26 2017, 6:58 PM · Marble
nienhueser accepted D6072: Fix rendering of polylines and polyrings after tileLevel refactoring.
Jun 26 2017, 6:57 PM · Marble

Jun 22 2017

nienhueser added a comment to D6303: Initial integration of the GeoDataBuilding into the parser and renderer.

Loks good on quick sight, though I would like a unit test for the building height extraction method as discussed.
Regarding the node reduction, how did you test this? I am missing changes in the osm plugin to ensure buildings are written to osm xml and o5m files. I guess that at the moment tools like kml2kml and likewise the vector tile creation tool do not write buildings anymore. Can you look into it?

Jun 22 2017, 4:30 AM

Jun 20 2017

nienhueser added inline comments to D6303: Initial integration of the GeoDataBuilding into the parser and renderer.
Jun 20 2017, 9:10 PM

Jun 16 2017

nienhueser accepted D6222: Introduce GeoDataBuilding.

Thanks, time to push it I'd say - Torsten?

Jun 16 2017, 5:50 PM

Jun 15 2017

nienhueser requested changes to D6222: Introduce GeoDataBuilding.

I miss a "sane" constructor. What about introducing a unit test so the class is used in one place at least for a basic sanity check?

Jun 15 2017, 8:48 PM
nienhueser requested changes to D6222: Introduce GeoDataBuilding.
Jun 15 2017, 6:31 PM
nienhueser requested changes to D6222: Introduce GeoDataBuilding.
Jun 15 2017, 4:50 PM

Jun 14 2017

nienhueser added inline comments to D6222: Introduce GeoDataBuilding.
Jun 14 2017, 6:32 PM
nienhueser accepted D2862: Current settings should be saved on killing app too (not only on closing app).

Looks good, please push.

Jun 14 2017, 3:45 AM · Marble

Jun 10 2017

nienhueser added a comment to D6159: Render caravan site / park icon.

I was creating tiles for the state of Ontario, Canada and it seems to get stuck after " [========================================>] 100% landmass cache tiles complete." Any idea what might be the problem?

Jun 10 2017, 10:54 PM · Marble

Jun 9 2017

nienhueser added a comment to D6159: Render caravan site / park icon.

You can generate tiles locally. The tile creation tool uses the marble library and therefore picks up changes like extracting more tags, so the locally created tiles will have the additional data. See https://techbase.kde.org/Marble/OSMVectorTileCreation

Jun 9 2017, 6:03 PM · Marble

Jun 8 2017

nienhueser accepted D6156: Introduces the elevator symbols onto the map.

Looks fine :-)

Jun 8 2017, 9:32 PM · Marble: Indoor Maps
nienhueser updated subscribers of T6274: Add UI to change levels in a building/area.

I propose a similar UI as Google Maps to indicate and navigate the different levels in a building/area, which crudely means that we render the respective floor tags when a particular floor is selected.

Sounds good to me.

Jun 8 2017, 6:32 PM · Marble: Indoor Maps
nienhueser added a comment to T6273: Add missing indoor OSM tags.
  1. Do I just have to add the indoor tags as textual descriptions in Placemark.cpp?

declarative/Placemark.cpp is responsible for showing tag details when you select (tap on) some feature in Marble Maps. For keys like height this would be useful. Many tags will not be extracted by Marble at the moment however (e.g. indoor=room), so more changes are needed to extract/render them in the first place.

Jun 8 2017, 6:19 PM · Marble: Indoor Maps
nienhueser added a comment to T6287: Elevator symbols.

GeoDataPlacemark.h:186 says "please keep order (used in for loops)" so where should I add the HighwayElevator enum value?

Jun 8 2017, 6:06 PM · Marble: Indoor Maps
nienhueser added a comment to D1484: Lookup ECM once in toplevel CMakeLists.txt.

Obviously no interest from maintainers to have this in, so dropping for now.

Jun 8 2017, 4:01 PM · Marble

May 29 2017

nienhueser closed T6092: Subscribe to marble-devel@kde.org as Resolved.
May 29 2017, 5:51 PM · Marble: Material Maps

May 26 2017

nienhueser requested changes to D2862: Current settings should be saved on killing app too (not only on closing app).

From what I remember the problem goes like this: On Android, change some setting, then open the application list and swipe Marble Maps to the right to kill it. The settings were not saved, so not restored upon the next start.

May 26 2017, 7:33 PM · Marble
nienhueser closed D1259: Allow to assign a z-Order to files.
May 26 2017, 7:08 PM · Marble
nienhueser accepted D1259: Allow to assign a z-Order to files.
May 26 2017, 7:08 PM · Marble

May 22 2017

nienhueser committed R34:f8e92ddbda00: Check coordinate validity (authored by nienhueser).
Check coordinate validity
May 22 2017, 6:52 PM
nienhueser committed R34:3bf73df7c944: Press and hold timer is for left mouse button only (authored by nienhueser).
Press and hold timer is for left mouse button only
May 22 2017, 6:52 PM
nienhueser committed R34:fd83b5dc58a3: Introduced rotation the globe by right mouse button. (authored by vdoroshchuk).
Introduced rotation the globe by right mouse button.
May 22 2017, 6:52 PM
nienhueser closed D5650: Introduced rotation the globe by right mouse button. by committing R34:fd83b5dc58a3: Introduced rotation the globe by right mouse button. (authored by vdoroshchuk).
May 22 2017, 6:52 PM · Marble

May 15 2017

nienhueser raised the priority of T6138: Research: Kirigami from Normal to Needs Triage.
May 15 2017, 7:29 PM · Marble: Material Maps
nienhueser created T6138: Research: Kirigami.
May 15 2017, 7:27 PM · Marble: Material Maps

May 11 2017

nienhueser moved T6092: Subscribe to marble-devel@kde.org from Backlog to June 2017 Coding Period on the Marble: Material Maps board.
May 11 2017, 8:15 PM · Marble: Material Maps
nienhueser created T6092: Subscribe to marble-devel@kde.org.
May 11 2017, 8:14 PM · Marble: Material Maps
nienhueser moved T6091: Subscribe to marble-devel@kde.org from Backlog to June 2017 Coding Period on the Marble: Indoor Maps board.
May 11 2017, 8:11 PM · Marble: Indoor Maps
nienhueser created T6091: Subscribe to marble-devel@kde.org.
May 11 2017, 8:11 PM · Marble: Indoor Maps
nienhueser added a member for Marble: Indoor Maps: nienhueser.
May 11 2017, 7:46 PM
nienhueser added a member for Marble: Indoor Maps: rahn.
May 11 2017, 7:46 PM
nienhueser updated the image for Marble: Material Maps from F3748455: fa-briefcase-blue.png to F3749088: profile.
May 11 2017, 7:42 PM
nienhueser set the icon for Marble: Material Maps to Project.
May 11 2017, 7:42 PM
nienhueser updated the image for Marble: Indoor Maps from F3749082: profile to F3749085: profile.
May 11 2017, 7:41 PM
nienhueser updated the image for Marble: Indoor Maps from F3748456: fa-briefcase-blue.png to F3749082: profile.
May 11 2017, 7:40 PM
nienhueser set the icon for Marble: Material Maps to Experimental.
May 11 2017, 7:39 PM
nienhueser added a member for Marble: Material Maps: nienhueser.
May 11 2017, 7:37 PM
nienhueser added a member for Marble: Material Maps: rahn.
May 11 2017, 7:37 PM
nienhueser added a member for Marble: Material Maps: juditbartha.
May 11 2017, 7:37 PM
nienhueser moved T6090: Add my blog to planet.kde.org from Backlog to June 2017 Coding Period on the Marble: Indoor Maps board.
May 11 2017, 7:32 PM · Marble: Indoor Maps
nienhueser edited projects for T6090: Add my blog to planet.kde.org, added: Marble: Indoor Maps; removed Marble.
May 11 2017, 7:32 PM · Marble: Indoor Maps
nienhueser created T6090: Add my blog to planet.kde.org.
May 11 2017, 7:31 PM · Marble: Indoor Maps

May 10 2017

nienhueser accepted D5792: Fix installation folder for qm files in KDE Apps release settings.

Looks fine to me. Last Windows installer I used windeployqt which created a folder translations. I can check and adjust that next time I tinker with it. So far no translations are used in Windows.

May 10 2017, 5:36 AM

May 9 2017

nienhueser accepted D5650: Introduced rotation the globe by right mouse button..

Torsten, I'm accepting as Marble now given the time passed.

May 9 2017, 4:10 AM · Marble

May 7 2017

nienhueser accepted D5738: Support also translated doc added in the KDE Application tarball.

Looks good to me.

May 7 2017, 1:03 PM

May 1 2017

nienhueser accepted D5648: Support translation catalogs added in KDE Application release tarball.
May 1 2017, 7:43 PM

Apr 30 2017

nienhueser added inline comments to D5650: Introduced rotation the globe by right mouse button..
Apr 30 2017, 2:04 PM · Marble
nienhueser accepted D5650: Introduced rotation the globe by right mouse button..
Apr 30 2017, 8:44 AM · Marble
nienhueser added a comment to D5650: Introduced rotation the globe by right mouse button..

Awesome work! The patch looks very clean and it integrates well with the current user interface.

Apr 30 2017, 8:44 AM · Marble
nienhueser added a project to D5650: Introduced rotation the globe by right mouse button.: Marble.
Apr 30 2017, 8:11 AM · Marble
nienhueser added a reviewer for D5396: Mismatch in parsed GeoDataDocument and GeoSceneGeodata in MarbleModelPrivate::assignFillColors(const QString &filePath): Marble.
Apr 30 2017, 8:10 AM · Marble
nienhueser accepted D5396: Mismatch in parsed GeoDataDocument and GeoSceneGeodata in MarbleModelPrivate::assignFillColors(const QString &filePath).

Looks good, please push.

Apr 30 2017, 8:10 AM · Marble

Apr 23 2017

nienhueser committed R34:b3a589369b01: Delete now unused NSIS file (authored by nienhueser).
Delete now unused NSIS file
Apr 23 2017, 9:07 AM
nienhueser committed R34:231a328868ce: Update version number for latest stable release (authored by nienhueser).
Update version number for latest stable release
Apr 23 2017, 9:06 AM
nienhueser committed R34:71a403067c21: Use windeployqt instead of manual Qt dependency hunting (authored by nienhueser).
Use windeployqt instead of manual Qt dependency hunting
Apr 23 2017, 9:06 AM
nienhueser committed R34:6fd0b7820436: Move win/mac installation files to common dir. Split iss files. (authored by nienhueser).
Move win/mac installation files to common dir. Split iss files.
Apr 23 2017, 9:06 AM
nienhueser committed R34:32fd8ce26e50: Use a Marble start menu folder, install website link (authored by nienhueser).
Use a Marble start menu folder, install website link
Apr 23 2017, 9:06 AM
nienhueser committed R34:a0ea586d3f09: Sync windows installer version (authored by nienhueser).
Sync windows installer version
Apr 23 2017, 9:06 AM
nienhueser committed R34:63573210c8fc: Switch from NSIS to Inno Setup (authored by nienhueser).
Switch from NSIS to Inno Setup
Apr 23 2017, 9:06 AM
nienhueser committed R34:a0665d48d937: Fix MSVC compilation (fails with C2308, concatenating mismatched strings) (authored by nienhueser).
Fix MSVC compilation (fails with C2308, concatenating mismatched strings)
Apr 23 2017, 9:06 AM
nienhueser committed R34:474fed24b048: Remove extra qualification (authored by nienhueser).
Remove extra qualification
Apr 23 2017, 9:06 AM
nienhueser committed R34:acff87ac0614: Use windeployqt instead of manual Qt dependency hunting (authored by nienhueser).
Use windeployqt instead of manual Qt dependency hunting
Apr 23 2017, 9:01 AM
nienhueser committed R34:71ec55753cdc: Move win/mac installation files to common dir. Split iss files. (authored by nienhueser).
Move win/mac installation files to common dir. Split iss files.
Apr 23 2017, 9:01 AM
nienhueser committed R34:4fd5e00703c6: Update version number for latest stable release (authored by nienhueser).
Update version number for latest stable release
Apr 23 2017, 9:01 AM
nienhueser committed R34:64a666bfdca7: Use a Marble start menu folder, install website link (authored by nienhueser).
Use a Marble start menu folder, install website link
Apr 23 2017, 9:01 AM
nienhueser committed R34:270f558f5517: Sync windows installer version (authored by nienhueser).
Sync windows installer version
Apr 23 2017, 9:01 AM
nienhueser committed R34:746438e18005: Switch from NSIS to Inno Setup (authored by nienhueser).
Switch from NSIS to Inno Setup
Apr 23 2017, 9:01 AM
nienhueser committed R34:e5ab56cecde7: No need for fabs (fixes MSVC compilation) (authored by nienhueser).
No need for fabs (fixes MSVC compilation)
Apr 23 2017, 9:01 AM
nienhueser committed R34:6fc5b18d3cf7: Fix MSVC compilation (fails with C2308, concatenating mismatched strings) (authored by nienhueser).
Fix MSVC compilation (fails with C2308, concatenating mismatched strings)
Apr 23 2017, 9:01 AM
nienhueser committed R34:2486ceb4ff26: Remove extra qualification (authored by nienhueser).
Remove extra qualification
Apr 23 2017, 9:01 AM

Apr 18 2017

nienhueser moved T5906: Fix clazy qstring-arg warnings from Backlog to Junior Jobs on the Marble board.
Apr 18 2017, 7:45 PM · Marble
nienhueser added a comment to D5396: Mismatch in parsed GeoDataDocument and GeoSceneGeodata in MarbleModelPrivate::assignFillColors(const QString &filePath).

Now data is called uninitialized in data->sourceFile(), no? I think shentey meant this instead:

Apr 18 2017, 7:44 PM · Marble
nienhueser placed T4817: Dynamic Tile Generation up for grabs.
Apr 18 2017, 7:36 PM · Marble
nienhueser placed T4703: Add a Splash Screen up for grabs.
Apr 18 2017, 7:35 PM · Marble