- User Since
- Apr 18 2015, 5:20 AM (118 w, 1 d)
Mon, Jul 3
Looks good to me. Please do another thorough test before pushing as discussed in IRC.
Sun, Jul 2
@rahn Can you review this as well? I'd like to have more eyes on it as it touches some pretty sensitive areas of the vector tiling pipeline.
Mon, Jun 26
Jun 22 2017
Loks good on quick sight, though I would like a unit test for the building height extraction method as discussed.
Regarding the node reduction, how did you test this? I am missing changes in the osm plugin to ensure buildings are written to osm xml and o5m files. I guess that at the moment tools like kml2kml and likewise the vector tile creation tool do not write buildings anymore. Can you look into it?
Jun 20 2017
Jun 16 2017
Thanks, time to push it I'd say - Torsten?
Jun 15 2017
I miss a "sane" constructor. What about introducing a unit test so the class is used in one place at least for a basic sanity check?
Jun 14 2017
Looks good, please push.
Jun 10 2017
Jun 9 2017
You can generate tiles locally. The tile creation tool uses the marble library and therefore picks up changes like extracting more tags, so the locally created tiles will have the additional data. See https://techbase.kde.org/Marble/OSMVectorTileCreation
Jun 8 2017
Looks fine :-)
Sounds good to me.
declarative/Placemark.cpp is responsible for showing tag details when you select (tap on) some feature in Marble Maps. For keys like height this would be useful. Many tags will not be extracted by Marble at the moment however (e.g. indoor=room), so more changes are needed to extract/render them in the first place.
May 29 2017
May 26 2017
From what I remember the problem goes like this: On Android, change some setting, then open the application list and swipe Marble Maps to the right to kill it. The settings were not saved, so not restored upon the next start.
May 22 2017
May 15 2017
May 11 2017
May 10 2017
Looks fine to me. Last Windows installer I used windeployqt which created a folder translations. I can check and adjust that next time I tinker with it. So far no translations are used in Windows.
May 9 2017
Torsten, I'm accepting as Marble now given the time passed.
May 7 2017
Looks good to me.
May 1 2017
Apr 30 2017
Awesome work! The patch looks very clean and it integrates well with the current user interface.
Looks good, please push.
Apr 23 2017
Apr 18 2017
Now data is called uninitialized in data->sourceFile(), no? I think shentey meant this instead:
Apr 17 2017
Apr 13 2017
Apr 11 2017
@shentey Any chance this is related to your latest refactoring in that area of the code?
Can this be reproduced easily? What's the effect?