Kirigami Marble Maps design revisions
Needs RevisionPublic
Actions

Authored by juditbartha on Aug 20 2017, 5:36 PM.

Details

Reviewers

nienhueser
aacid

Group Reviewers

Marble: Material Maps

Summary

Added About menu as a Kirigami page, available from the side panel.

Diff Detail

Repository

R34 Marble

Lint

Lint Skipped

Unit

Unit Tests Skipped

juditbartha created this revision.Aug 20 2017, 5:36 PM

juditbartha edited the summary of this revision. (Show Details)Aug 20 2017, 5:51 PM

nienhueser accepted this revision.Aug 20 2017, 5:55 PM

nienhueser added a subscriber: nienhueser.

nienhueser added inline comments.

src/apps/marble-maps/MainScreen.qml
120	There is also a monochrome version of the marble logo somewhere, Torsten once created that. Maybe it fits well here?

This revision is now accepted and ready to land.Aug 20 2017, 5:55 PM

Added bottom menu containing context-based buttons. When app is in "place" mode the bookmark button (filled / unfilled star.svg) is blurry, even though the Image has the "smooth" attribute, and the svg itself is, of course normal. This doesn't happen with the "route" button, which is used in the same way.

This patch doesn't apply anymore, is it because it was commited and you forgot to close it?

This revision now requires changes to proceed.Sep 5 2017, 8:50 PM

Revision Contents
Changeset List

			Path	Packages
M			src/apps/marble-maps/FlatButton.qml (3 lines)
M			src/apps/marble-maps/MainScreen.qml (830 lines)
M			src/apps/marble-maps/MarbleMaps.qrc (1 line)
M			src/apps/marble-maps/PlacemarkDialog.qml (38 lines)
M			src/apps/marble-maps/Search.qml (30 lines)
M			src/apps/marble-maps/SearchField.qml (3 lines)