In T9069#174025, @matheswaranshanmugam wrote:

Hello Sir, I'm interested in this .
will you elaborate me want to be done exactly.

Currently, the three main columns in Elisa interface cannot be resized by the user. The idea is to allow to resize them while keeping the current way of switching between views.

Hello Sir, I'm interested in this .
will you elaborate me want to be done exactly.

Thanks for your work.

In D17994#393062, @ngraham wrote:

In D17994#393059, @ashwind wrote:

I had to handle return keys separately as they dont trigger actions.

Maybe this is something we should fix at the QQC2-desktop-style level so all QQC/QML/Kirigami apps can get it too?

Everything there is pretty awesome!

maybe then we have to take a peek at it.

In D17994#393059, @ashwind wrote:

I had to handle return keys separately as they dont trigger actions.

Ok i will do as you have mentioned. I had to handle return keys separately as they dont trigger actions.

Thanks for your work. It works really well.

Nice!

I have updated the diff. Elements focused using tab key will be triggered by Return Key. SpaceBar is assigned global shortcut for play-pause action and won't trigger elements focussed using tab key. Should work for most part.

Ok lets look into it. It might be done through an ugly hack using event filters, but i have to research up a bit.

So maybe it should, or maybe using the space bar should continue to click the selected element when that element was selected using the tab key.

Yes, but elisa doesn't click the elements under focus even through the return key.

For example the mute/unmute button.

@ngraham can you please specify on which element did you navigate to. I tried to replicate it, it does as you mentioned, on the navigation action bar. But not on the elements outside it. And the purpose of the patch was to perform playpause action irrespective of focus. So probably blocking all the tab events of navigation action bar should do the job.

maybe i need to do the job using event filter instead of the usual shortcut mechanism used by Elisa

I notice that after navigating to an element using the tab key, hitting the spacebar does correctly trigger that element rather than doing play/pause, but then the just-triggered element is no longer selected afterwards. We should probably preserve that.

Added context to the diff. Thanks @shubham.

Ok i will start using archanist ASAP

In D17994#391102, @ashwind wrote:

I used archanist to apply the patch. It is working fine for me.

I used archanist to apply the patch. It is working fine for me.

Made the shortcut configurable. I actually did a "git pull" and updated the feature out from a fresh repo. It should work now.

Ok, I will look into it.

Thanks for your patch.

Thanks! I'll let @mgallien land this for you when he's ready.

Name: Ashwin Dhakaita
Email: ashwingpdhakaita@gmail.com

In the meantime, @ashwind, we will need you to provide your full name and email address so we can land this patch with the correct authorship information.

Thank you, @mgallien. I will apply for one after sometime then.

In D18017#390492, @ashwind wrote:

I don't have a developer account. Please land it for me.
Actually, I am new to KDE and don't know about Developer Account. I will sign up for one.

I don't have a developer account. Please land it for me.
Actually, I am new to KDE and don't know about Developer Account. I will sign up for one.

In D18017#390169, @mgallien wrote:

Nice work. Thanks for your help.

In D18017#389338, @ngraham wrote:

Oops, I should have realized that!

BTW @mgallien, it's off-topic for this patch, but I wanted to express my happiness over how good Elisa is these days. It's becoming really excellent. The full-screen view is so beautiful and compelling! I plan to contribute a lot in 2019. Once we get https://bugs.kde.org/show_bug.cgi?id=401969, I'm ditching Lollypop and moving to it full-time.

Nice work. Thanks for your help.

Well, I made the shortcuts configurable.

Sorry, I will look into it. 😕😕

Oops, I should have realized that!

Thanks for your patch.
In order to better integrate it in the application, it would need to be configurable like other existing shortcuts. In order to do that, you can look at the ElisaApplication class.

Very cool!!! Works great for me.

Thank you Sir 😊

This works great, I love it. It's up to the Elisa devs of course, but this gets a thumbs up from me.

Well I cleared up the trailing whitespaces.

Ok.

Thanks for the patch! There are a lot of unintentional trailing whitespace changes here. Do you think you can clean those up?