initial support for android music indexer and a very small kirigami2 UI
ClosedPublic

Authored by mgallien on Aug 23 2018, 6:17 AM.

Details

Summary

initial support for android music indexer and a very small kirigami2 UI

still very much a work in progress

I need something like 20 seconds to import all the music in the database.
This is not good from a performance point of view.

Test Plan

builds fine and display the list of my albums

Diff Detail

Repository
R255 Elisa
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien requested review of this revision.Aug 23 2018, 6:17 AM
mgallien created this revision.
mgallien updated this revision to Diff 40309.Aug 23 2018, 3:44 PM

rebase on top of master

mgallien updated this revision to Diff 40617.Aug 29 2018, 6:14 AM

rebase on top of master

I can't test on Android right now, so I'm just looking if it breaks on linux...
Do you plan to add an entirely new interface for android?

src/CMakeLists.txt
443

This causes cmake to fail on linux

I can't test on Android right now, so I'm just looking if it breaks on linux...
Do you plan to add an entirely new interface for android?

I do not know. I plan to add components from Kirigami2 as time permits. I also plan to fix the current interface to be usable on tablet form factor.

It all depends on available time to work on it.

src/CMakeLists.txt
443

Are you sure that it fails ?
I fail to understand how this could fail.

astippich added a comment.EditedOct 17 2018, 6:58 PM

hmm, maybe it was a cmake configuration issue, since I didn't have the kirigami libraries installed before. Anyways, this is working now.
But are the kirigami libraries actually required for desktop targets right now? I think they should be optional

mgallien updated this revision to Diff 43882.Oct 18 2018, 4:50 PM
  • let kirigami be required only on Android

Thanks. I have two more comments inline.

data/AndroidManifest.xml
2–3

Is android:versionName the version of Elisa? If so, this should be adjusted.

src/android/ElisaMainWindow.qml
19

qqc 2.4 is Qt 5.11 only. so either a Qt version bump is required or this must be lowered to 2.3.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 20 2018, 8:40 PM
This revision was automatically updated to reflect the committed changes.