I would put everything within the same activity so that people would find it under the same name for example relative positionning.

2-3 potential modes:

• like in missing_letter, a list of words and an image, we need to select the good word.
• like in missing_letter, a list of images and a word, we need to select the good image corresponding to the word.
• (in a 2.5 dimension world, having an item in the middle, a person to place on the asked position?)

We coudl add between
An example of images can be found here
http://jt44.free.fr/divers/Dominospel.pdf

Thank you,
merged in:
https://cgit.kde.org/gcompris.git/commit/?id=c7a267ace1e820d0a7b58e0c3d6fc7b87436a211
https://cgit.kde.org/gcompris.git/commit/?id=040e1d61ef2f5e02e8dcc9943c9a779572b2bed3
https://cgit.kde.org/gcompris.git/commit/?id=7d3b8ecf5c37552d03391d9427ef959de6c8a17d

In D18230#450369, @echarruau wrote:

Hi,
I am working from a fresh version of master and get the same problem when I want to apply diff for both D18230.diff

and D18600.diff.

error: patch failed: src/activities/activities.txt:119
Could you on your side apply your patch to see if it is working?
Thanks

Hi,
I am working from a fresh version of master and get the same problem when I want to apply diff for both D18230.diff
and D18600.diff.
error: patch failed: src/activities/activities.txt:119
Could you on your side apply your patch to see if it is working?
Thanks

@jjazeix I have updated the diff, please have a look whenever you have time :)

Made the following changes

• Added visual feedback for selected question(made the border color grey)
• Added the scroll buttons on the side
• Tab works intuitively
• Made the input text span multiple lines for longer texts.
• Fixed to some extent the problem of input texts being overridden even outside the panel, but some problem still exists for longer texts(working to solve that completely)

A few notes:

• The selected question should have a visual feedback
• There should be scroll buttons on the side to tell there are questions outside the visual zone
• The tab button does not give focus in an intuitive order (not from left to right or top to bottom)
• For text answers, the text area should contain multiple lines. Having only one line prevents knowing what has been written before.
• Questions are outside panel range and answer area can override answer: https://pasteboard.co/I7XcMoO6.png

Just a quick note, can you please fix those:
questions_answers.diff:740: trailing whitespace.

implicitHeight: Math.max(grid.cellHeight / 2, 40)

questions_answers.diff:981: trailing whitespace.

for( var i = 0; i < items.questions.length; i++){

questions_answers.diff:1166: trailing whitespace.

@echarruau Hi, i have updated the diff, please have a look whenever you have time :)

Added the adaptive TextArea in place of TextField that adjusts its size according to the text entered

Actually I'm not even sure this is a good activity concept, as it has the same flaws as the "intro gravity" activity we have. That is:
-increasing the size of something doesn't directly means increasing its mass (if you stretch something, it will take more space but have the same mass), that can lead to bad misconception for kids.
-increasing the size of a planet sounds very weird to me, as it's not realistic at all.

@dekumar there is a list above, feel free to test the activity and see what is still left to do. Then, feel free to add any improvements that can be useful for the children to learn about

@jjazeix I want to add this activity as task to complete in GSoC period ?
Can I know what more is left to be completed ?

Sorry, actually I this task is a left-over that I forgot to close after fixing the layout of this activity.
The current number of buttons is intended, and increase at each level to introduce new functionalities progressively.
As we don't want to remove features, I'm closing it now.

I moved around some elements of the current piano composition layout, I would like to hear suggestions to make it better...

@jjazeix yes,sure :)

@dekumar do a test and you'll see :)

@timotheegiet @jjazeix I have gone through the code of both the library the circuit-sandbox and the zupolgec/circuit-simulator.I think the zuplogec/circuit- simulator ( https://github.com/zupolgec/circuit-simulator ) is easy to use.But one thing I am not sure does Qt support the js with prototype and this keyword ?

@AkshayCHD we have a page on information we want to have for gsoc proposal, please check it: https://gcompris.net/wiki/GSOC_newcomers. We will only give feedback on "full" proposals, not parts.

@jjazeix @echarruau Hii, i was thinking on working on this activity as a part of my gsoc 2019 project if given a chance, I have prepared a proposal regarding it, please have a look https://docs.google.com/document/d/1n8cIcyAu1JpeSjr4-UGmUT5HA0TPtKNh0t2X2eCa_rQ/edit?usp=sharing , once it is reviewed i can include its content in my main proposal

Made the Following changes

1. Removed the two standard buttons and added single OK button in there place
2. Added image and animation to indicate that time is running
3. Submission button is visible when the first answer text is clicked
4. Splitting the json file into several smaller json files

Seeing Johnny's question I will try to be more precise about the mockup.
I would like to see the answer area close to the question, without equal. Take a resonnably large answer length. If the area fits on the same line keep it on the same line.
If it does not fit put it alone on the next line. The size of the answer area should be adaptive. It should increase with the number of characters entered if the answer is long.
This is because if from the beginning you fit the length of the answer area to the answer itself it will give hints for the pupil to choose the answer.

In D18230#409948, @echarruau wrote:

Here is the mockup I prepared for long sentences
https://snag.gy/IQLv5e.jpg

That's nice to hear! :)

Checked both behaviour and code. Beautiful piece of code :) Code is easy to understand, functions are well named, factorisation is well used everywhere it can be. Well done, congratulation!
Ready to be merged :)

Here is the mockup I prepared for long sentences
https://snag.gy/IQLv5e.jpg

Ok, I will see with Johnny if state is the good tool for it, I don't remember saying it used for this purpose.
About your last comment I did not ask you to remove submit button but the start button.
I will prepare a mockup to explain you the size of the fonts I have in mind, the test you have done on sentences length could also be useful there implement the change I have in mind.

https://snag.gy/AvZwbC.jpg
@echarruau when the question length is very long, even if the window.width > window.height, the rearrangement will take place, that is why i said that it has nothing to do with the playarea's width, and for this rearrangement i made use of states, without using states this question would have looked like, https://snag.gy/MwyHUI.jpg

Diff Update:

1. Made the answer text slide down when question length is too long
2. Moved the buttons up when window height > width

Could you please detail what you have done when submitting the final sum up.
Instead of writting "Made the changes" I need to know what has been changed.

Made the changes

Could you work the way questions and answers are displayed?
https://snag.gy/IiCuYd.jpg
We should try to have one question and answer per line, and if there is not enough place for a question in a single line you force the answer under the question.

Could you do a test please?
Remove the start button (only comment it in the code do not delete the lines).
Start should be done when user clicks the first time in any answer box.
Could you also add an item of you choice saying that time is running?
Something nice not stressful. You can look at how candies are animated in share activity to see how you can make objects moving slightly.

Warning message does not fit in the screen
https://snag.gy/a7Y8K1.jpg

In D18230#405313, @echarruau wrote:

I applied your diff and get this answer:
Script qrc:/gcompris/src/activities/question_and_answer/dataset.js unavailable
qrc:/gcompris/src/activities/question_and_answer/dataset.js: No such file or directory
Can you update the diff please?

Buttons start and restart overlapped by menu bar
https://snag.gy/XqvDzO.jpg

Dataset missing

dataset.js is still included in the code.

@jjazeix I have updated the diff

In D18230#405313, @echarruau wrote:

I applied your diff and get this answer:
Script qrc:/gcompris/src/activities/question_and_answer/dataset.js unavailable
qrc:/gcompris/src/activities/question_and_answer/dataset.js: No such file or directory
Can you update the diff please?

Made the necessary changes

I think you added an hard coded value for noOfQuestions, but I can not test since I do not have the js at the moment.

I applied your diff and get this answer:
Script qrc:/gcompris/src/activities/question_and_answer/dataset.js unavailable
qrc:/gcompris/src/activities/question_and_answer/dataset.js: No such file or directory
Can you update the diff please?

@jjazeix I have converted the dataset of this diff also to json format

Moved dataset to resource folder in json format.

When I reduce the window size, numbers are disappearing (see level 3). They should be reordered on a lower line.

Activity: Sudoku
Place unique symbols in a grid
Goal: The aim of the puzzle is to enter a symbol or numeral from 1 through 9 in each cell of a grid. In the official Sudoku the grid is 9x9 made up of 3x3 subgrids (called 'regions'). In GCompris we start at lower levels with a simpler version using symbols and with no regions. In all cases the grid is presented with various symbols or numerals given in some cells (the 'givens'). Each row, column and region must contain only one instance of each symbol or numeral (Source <http://en.wikipedia.org/wiki/Sudoku>).

In D18230#400393, @AkshayCHD wrote:

@jjazeix regarding the part of calculating the longest string, I think only a rough idea of length is needed, it doesn't need to be exact, another option can be to apply that text to the sample question and make comparison on the basis its height, what do you say?

@jjazeix regarding the part of calculating the longest string, I think only a rough idea of length is needed, it doesn't need to be exact, another option can be to apply that text to the sample question and make comparison on the basis its height, what do you say?

Made the changes

@echarruau I have updated the diff, made the changes as you told, also i've added a sample questions subactivity that would later be deleted just to demonstrate how the questions of different lengths can be accommodated in the activity.

Made the questions orientation more dynamic to support questions of all lengths.

Hi,
I don't know how much work you have done on it, if it comes from Amit or you but the activity seems much nicer than the last time I saw it.
I saw a few points to improve, even if I did not have a look to the code yet.

• When I reduce the size of GCompris the equal sign (=) goes under the numbers. You could work on font size to avoid this but in any case the = sign needs to stay on the same line
• In the admin config menu, numbers are too far from their select box and I did not know if the select box was assigned to the right or the left numbers
• Admin config: could you increase the fonts
• Admin config: when reducing some part of the questions disappear, you can rearange then with a flow

-Main window: if the display is too small to display all the questions, the up and down blue arrows used in the config window should appear.

@echarruau in response to your query on IRC, before making the diff I did a rebase with the latest master branch so the current diff is in sync with the master branch, you can have a look, the code might need some refactoring but, before that i just wanted to have an idea whether i am going in the right direction or not. :)

other libs to be checked: https://github.com/zupolgec/circuit-simulator
or maybe in C (need to check if easy to have it multiplatform): https://sourceforge.net/p/ngspice/ngspice/ci/master/tree/src/include/ngspice/sharedspice.h

@echarruau , @timotheegiet : is it good for you to merge it?

Sorry for delay.

• Renaming the activities to Ordering numbers, Ordering letters.

Sorry for delay, I fixed other issues within the patch:

• when you submit an answer, you may have 3 texts displayed on the right that was hidden by the light (too much color/not enough color...)
• I put the score on the left to avoid potential overriding and having a floating score
• I set a max value for the circle radius to avoid having it going too big.

Looks good to me on testing!

Fixed file permissions and display of text in certain window sizes.

code merged

Code merged

Code merged :)

GCCreationHandler is now integrated with all the configurable activities. Closing this task.