piano_composition activity
ClosedPublic

Authored by amankumargupta on Aug 10 2018, 12:11 PM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris: Activities
Maniphest Tasks
T1521: Port of Gtk+ piano composition
Summary

This is the patch file for Piano_composition activity to be submitted for final evaluation of GSoC.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
Restricted Application added a project: KDE Edu. · View Herald TranscriptAug 10 2018, 12:11 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
amankumargupta requested review of this revision.Aug 10 2018, 12:11 PM
jjazeix added inline comments.
src/activities/piano_composition/ActivityInfo.qml
53

createdInVersion

src/activities/piano_composition/OptionsRow.qml
133

qsTr()

src/activities/piano_composition/Piano_composition.qml
26

version

114

no ! for comparing int

amankumargupta marked 4 inline comments as done.Aug 10 2018, 4:09 PM
amankumargupta edited the summary of this revision. (Show Details)

Factorised keyboard binding code

jjazeix accepted this revision.Dec 1 2018, 12:00 PM

Code merged :)

This revision is now accepted and ready to land.Dec 1 2018, 12:00 PM
jjazeix closed this revision.Dec 1 2018, 12:00 PM