This diff file contains all the work done by me (@amankumargupta ) during Season of KDE 2018.
Details
Details
Diff Detail
Diff Detail
- Repository
- R2 GCompris
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
@echarruau , @timotheegiet : is it good for you to merge it?
src/activities/programmingMaze/ActivityInfo.qml | ||
---|---|---|
27 | we need to add the translator helpers (//: ...) | |
src/activities/programmingMaze/CMakeLists.txt | ||
1 | it would be better to put the instructions inside resource like for other activities |
src/activities/programmingMaze/ActivityInfo.qml | ||
---|---|---|
27 | Pushed to the branch. |
Comment Actions
Checked both behaviour and code. Beautiful piece of code :) Code is easy to understand, functions are well named, factorisation is well used everywhere it can be. Well done, congratulation!
Ready to be merged :)