Removed unnecessary volatile

Added a few random improvements and compilation warning fixes.

Just a rebase.

In D11862#239984, @markey wrote:

See, the problem with removing features like this is, there will be a huge outcry from users. That's guaranteed, even without knowing for sure how much the scripting feature is really used in the wild.

I was discussing about this with Heiko. Maybe QtScript could be replaced with QJSEngine, similar to how the following patch for another project attempts to do it?

https://phabricator.kde.org/D7033

See, the problem with removing features like this is, there will be a huge outcry from users. That's guaranteed, even without knowing for sure how much the scripting feature is really used in the wild.

Pushed to master.

Put some more image savings out of the GUI thread.

Thanks!

There seems to be a bug in clang. But it doesn't seem to get fixed anytime soon. I'll write a workaround.

I managed to fix the issue with missing QtWebEngine but I'm not sure what I can do about the missing qml module. Isn't it part of the WebEngine package?

Fixed issue with missing optional dependency Qt5WebEngine.

Generally this works for me now, but there are two more issues that I found:

Changed fileUrl() to filePath(). Builds now with older KPackage.

The method is only available since kpackage-5.42.0.

Fails to build here:

Previous diff relied on a function of QMetaObject added in Qt 5.10. This now works with older versions of Qt, too.

This does not build for me (GCC 7.2.0).

Fixed hang on shutdown

In D11170#222062, @heikobecker wrote:

While I personally have no problem with requiring 5.41.0, it's maybe a bit new. Apparently the current Ubuntu doesn't have it and we should possibly wait until 18.04 is released (26.04.)

While I personally have no problem with requiring 5.41.0, it's maybe a bit new. Apparently the current Ubuntu doesn't have it and we should possibly wait until 18.04 is released (26.04.)

Kirigami2 seems really nifty. Nice choice.

Just a note: Back in the day Amarok was actually using SQLite, but there were major performance issues for people with giant collections. E.g. I was just talking to a user on IRC with a 44k tracks collection.

Fixed with df9fc58c8ac5ea2c8ed64f8d15ee87bab1af6681

Thanks, that's very good news :)

Does the services still work for you? The site seems pretty disfunctional, at least if you need to register as a new user first, which makes it impossible for me to test your patch.

In D10923#215754, @markey wrote:

Is this patch meant for master? Because the branch is "webkit-optional".

Is this patch meant for master? Because the branch is "webkit-optional".