Differential D12315

Fixed crash at shutdown
ClosedPublic
Actions

Authored by malteveerman on Apr 18 2018, 4:25 PM.

Details

Reviewers

markey

Group Reviewers

Amarok

Commits

R181:9a022879122f: Fixed crash at shutdown

Summary

This fixes a crash at shutdown, when Threadweaver threads try to access already deleted objects like the sql registry. We just wait for them to finish before deleting those.

Diff Detail

Repository

R181 Amarok

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

malteveerman requested review of this revision.Apr 18 2018, 4:25 PM

malteveerman created this revision.

anthonyfieroni added a subscriber: anthonyfieroni.Apr 18 2018, 6:38 PM

anthonyfieroni added inline comments.

src/browsers/CollectionTreeItemModelBase.cpp
96	In C++ it's used atomic.

Removed unnecessary volatile

markey accepted this revision.Apr 21 2018, 12:40 PM

This revision is now accepted and ready to land.Apr 21 2018, 12:40 PM

markey closed this revision.Apr 21 2018, 1:01 PM

Revision Contents
Changeset List

			Path	Packages
M			src/App.cpp (6 lines)
M			src/browsers/CollectionTreeItemModelBase.h (8 lines)
M			src/browsers/CollectionTreeItemModelBase.cpp (50 lines)
M			src/core-impl/collections/db/sql/SqlCollection.h (2 lines)
M			src/core-impl/collections/db/sql/SqlCollection.cpp (25 lines)
M			src/scanner/AbstractDirectoryWatcher.h (2 lines)
M			src/scanner/AbstractDirectoryWatcher.cpp (2 lines)