Some small changes and fixes

Authored by malteveerman on Mar 20 2018, 11:10 PM.



Just a bunch of small fixes and some minor changes. Biggest change is porting of Logger to new signal/slot syntax.

Diff Detail

R181 Amarok
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
malteveerman requested review of this revision.Mar 20 2018, 11:10 PM
malteveerman created this revision.
markey accepted this revision.Mar 25 2018, 4:47 PM
This revision is now accepted and ready to land.Mar 25 2018, 4:47 PM
This revision was automatically updated to reflect the committed changes.
heikobecker added inline comments.

This line seems to cause a build error on FreeBSD, which uses clang (contrary to the Linux build):
"error: missing default argument on parameter 'args' void newProgressOperation( KJob *job, const QString &text, Object *obj = nullptr, Func slot = nullptr, Qt::ConnectionType type = Qt::AutoConnection, FuncArgs... args )

Full log:

There seems to be a bug in clang. But it doesn't seem to get fixed anytime soon. I'll write a workaround.