Port NetworkAccessManager to new signal/slot syntax
ClosedPublic

Authored by malteveerman on Mar 9 2018, 9:11 AM.

Details

Summary

This adds some template code to enable using NetworkAccessManager with member function pointers.

Diff Detail

Repository
R181 Amarok
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
malteveerman requested review of this revision.Mar 9 2018, 9:11 AM
malteveerman created this revision.
markey requested changes to this revision.Mar 13 2018, 7:23 PM
markey added a subscriber: markey.

This does not build for me (GCC 7.2.0).

Error: https://pastebin.com/5Pmk1ELp

This revision now requires changes to proceed.Mar 13 2018, 7:23 PM

Previous diff relied on a function of QMetaObject added in Qt 5.10. This now works with older versions of Qt, too.

markey accepted this revision.Mar 14 2018, 7:18 PM
This revision is now accepted and ready to land.Mar 14 2018, 7:18 PM
This revision was automatically updated to reflect the committed changes.