rebased patch

Thanks for the review but somebody already fixed that bug. Do I still land this patch ?

In T12372#214054, @KonqiDragon wrote:

Here a Artists category mockups, prompt me what to add about selected artist in addition to Name and Genre? Also than fill the empty space upstairs (where the search place)?

In T12372#214580, @ngraham wrote:

The main window can actually be quite small when you hide the playlist:

We should probably make the playlist hiding feature more obvious, and maybe make it auto-hide itself when the window is shrunk down to be very small, similar to hos the sidebar become icons-only for small window sizes.

In T12372#214062, @ndavis wrote:

In T12372#214029, @mgallien wrote:

I used to regularly test with Breeze dark color scheme but somehow forgot to do it for the current stable version. Please, if you can test and open bug reports, that would be really nice.

Here's an example. It's probably the only example.

The outlines are very dark, which looks unnatural for Breeze Dark.
Sliders normally look like this:

On the third point, I definitely need help on that. Why is 24 pixels a problem ?
I sometime have the impression that some icons are blurry. Maybe we could identify the problems and fix Elisa to use the correct icon size ?

A few icons are actually blurry (that's a breeze-icons problem) and not all monochrome icons in breeze-icons are available at 24px, but most KDE applications use 22px instead of 24px. I'm guessing this is because 22px is slightly closer to 2x the area of 16px than 24px, but I don't actually know.

Our 24px icons are really just 22px icons with an extra pixel of margin on each side. It might be possible to automatically generate 24px icons from 22px icons at build time.

In T9641#214088, @vonreth wrote:

Opening the settings dialog the first time takes quite long, clicking it the second time crashes elisa.
Maybe you should investigate before we release ^^

A simple music player that should be easy to use. It does not require any configuration before one can use it. It will read all your music.

The screenshot of Elisa running on Windows is here https://community.kde.org/File:Elisa-windows.png

Thanks for the review

• fix the elisa recipe for the patches

In T12372#214029, @mgallien wrote:

In T12372#214008, @ndavis wrote:

In T12372#213921, @ngraham wrote:

Based on this screenshot, I don't think Elisa needs a complete redesign. It mainly needs the following:

• More colorscheme compatibility, unless that has already been fixed
• We need to decide if some of the styling for its UI elements should be changed to match the Breeze widget style or if our widget style should be changed to match Elisa
• Pixel perfect icons (maybe colorful icons, but monochrome looks so nice here), but this is mainly a breeze-icons problem, unless Elisa is using 24px icons.

I agree with all those goals.

I used to regularly test with Breeze dark color scheme but somehow forgot to do it for the current stable version. Please, if you can test and open bug reports, that would be really nice.

In T12372#214006, @KonqiDragon wrote:

I made some changes, the most replacement thing is that i relocate a timeline to bottom.

In T12372#214008, @ndavis wrote:

In T12372#213921, @ngraham wrote:

Based on this screenshot, I don't think Elisa needs a complete redesign. It mainly needs the following:

• More colorscheme compatibility, unless that has already been fixed
• We need to decide if some of the styling for its UI elements should be changed to match the Breeze widget style or if our widget style should be changed to match Elisa
• Pixel perfect icons (maybe colorful icons, but monochrome looks so nice here), but this is mainly a breeze-icons problem, unless Elisa is using 24px icons.

In T12372#214006, @KonqiDragon wrote:

I made some changes, the most replacement thing is that i relocate a timeline to bottom.

sorry for the mess in the previous patch

@jguidon Thanks a lot for this new contribution. This is nice to see you continue to contribute on this part.

In D24563#572927, @ngraham wrote:

Thanks so much for this very nice contribution, @jguidon!

In D24563#572849, @ngraham wrote:

Can this land now?

I forgot to maybe give some explanations.

• switch default to the latest stable tag (0.4.2 version) for elisa
• remove all versions specified in elisa.py, only use version.ini

• switch default to the latest stable tag (0.4.2 version) for elisa

@vonreth Thanks for the review

set latest beta release version as default