partial solution to accept accentuated characters on windows
Needs ReviewPublic

Authored by mgallien on Fri, Nov 29, 10:29 PM.

Details

Reviewers
bruns
Group Reviewers
Windows
Summary

If filename contains accentuated characters, taglib fails to open it on windows if the QString is converted to utf8.

Test Plan

Elisa is now able to index files with simple accentuated characters like é, è

Diff Detail

Repository
R286 KFileMetaData
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 19290
Build 19308: arc lint + arc unit
mgallien created this revision.Fri, Nov 29, 10:29 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptFri, Nov 29, 10:29 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
mgallien requested review of this revision.Fri, Nov 29, 10:29 PM

I forgot to maybe give some explanations.

The documentation of the constructor of TagLib::FileStream takes a char* and "file should be a be a C-string in the local file system encoding".

This means that the proper fix would possibly involve doing changes in TagLib itself to better handle non ASCII characters on Windows.

taglibwriter should get the same treatment