Differential D25622

partial solution to accept accentuated characters on windows
ClosedPublic
Actions

Authored by mgallien on Nov 29 2019, 10:29 PM.

Details

Reviewers
bruns
Group Reviewers
Windows
Commits
R286:9220e5045687: partial solution to accept accentuated characters on windows
Summary

If filename contains accentuated characters, taglib fails to open it on windows if the QString is converted to utf8.

Test Plan

Elisa is now able to index files with simple accentuated characters like é, è

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mgallien created this revision.Nov 29 2019, 10:29 PM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptNov 29 2019, 10:29 PM
Restricted Application added subscribers: Baloo, kde-frameworks-devel. · View Herald Transcript
mgallien requested review of this revision.Nov 29 2019, 10:29 PM
mgallien added a comment.Nov 30 2019, 9:07 AM

I forgot to maybe give some explanations.

The documentation of the constructor of TagLib::FileStream takes a char* and "file should be a be a C-string in the local file system encoding".

This means that the proper fix would possibly involve doing changes in TagLib itself to better handle non ASCII characters on Windows.

astippich added a subscriber: astippich.Dec 2 2019, 8:39 AM

taglibwriter should get the same treatment

bruns accepted this revision.Dec 12 2019, 8:31 PM

Again, Windows does not care ...

This revision is now accepted and ready to land.Dec 12 2019, 8:31 PM
vonreth added a subscriber: vonreth.Dec 12 2019, 10:26 PM
In D25622#576498, @bruns wrote:

Again, Windows does not care ...

The team is very small...

Closed by commit R286:9220e5045687: partial solution to accept accentuated characters on windows (authored by mgallien). · Explain WhyDec 12 2019, 11:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/extractors/taglibextractor.cpp (4 lines)

Diff 71404

View Options

src/extractors/taglibextractor.cpp

Loading...